[Console] Disable export if no content#195178
Merged
sabarasaba merged 3 commits intoelastic:mainfrom Oct 7, 2024
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
Member
Author
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @sabarasaba |
ElenaStoeva
approved these changes
Oct 7, 2024
Contributor
ElenaStoeva
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Tested locally, changes lgtm.
Contributor
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 7, 2024
(cherry picked from commit 76e4ffa)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 7, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Console] Disable export if no content (#195178)](#195178) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"rivasign@gmail.com"},"sourceCommit":{"committedDate":"2024-10-07T11:33:14Z","message":"[Console] Disable export if no content (#195178)","sha":"76e4ffa0c9628d7b71400043e39c9c5973d34b7d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Console","Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[Console] Disable export if no content","number":195178,"url":"https://github.com/elastic/kibana/pull/195178","mergeCommit":{"message":"[Console] Disable export if no content (#195178)","sha":"76e4ffa0c9628d7b71400043e39c9c5973d34b7d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195178","number":195178,"mergeCommit":{"message":"[Console] Disable export if no content (#195178)","sha":"76e4ffa0c9628d7b71400043e39c9c5973d34b7d"}}]}] BACKPORT--> Co-authored-by: Ignacio Rivas <rivasign@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #195117
Summary
This PR disables the export request button if there isnt anything to export.