Skip to content

[APM][ECO] Removing Entities inventory from APM#195116

Merged
cauemarcondes merged 9 commits intoelastic:mainfrom
cauemarcondes:apm-inventory-clean-up
Oct 7, 2024
Merged

[APM][ECO] Removing Entities inventory from APM#195116
cauemarcondes merged 9 commits intoelastic:mainfrom
cauemarcondes:apm-inventory-clean-up

Conversation

@cauemarcondes
Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes commented Oct 4, 2024

closes #194114

We will no longer show the entity inventory page on the APM UI. So, I'm removing all its code.

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor v8.16.0 labels Oct 4, 2024
@cauemarcondes cauemarcondes requested a review from a team as a code owner October 4, 2024 16:03
@cauemarcondes cauemarcondes requested a review from a team October 4, 2024 16:03
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Oct 4, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Copy Markdown
Contributor

@iblancof iblancof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹🧹🧹

Copy link
Copy Markdown
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Copy Markdown
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kibana.json looks 🆗

@cauemarcondes cauemarcondes enabled auto-merge (squash) October 7, 2024 08:43
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 7, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1848 1843 -5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.4MB 3.4MB +141.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 40.2KB 36.4KB -3.7KB
Unknown metric groups

ESLint disabled line counts

id before after diff
apm 70 68 -2

Total ESLint disabled count

id before after diff
apm 83 81 -2

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cauemarcondes cauemarcondes merged commit c44b7de into elastic:main Oct 7, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11213909758

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 7, 2024
closes elastic#194114

We will no longer show the entity inventory page on the APM UI. So, I'm
removing all its code.

(cherry picked from commit c44b7de)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 7, 2024
)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[APM][ECO] Removing Entities inventory from APM
(#195116)](#195116)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"55978943+cauemarcondes@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-07T10:46:47Z","message":"[APM][ECO]
Removing Entities inventory from APM (#195116)\n\ncloses
https://github.com/elastic/kibana/issues/194114\r\n\r\nWe will no longer
show the entity inventory page on the APM UI. So, I'm\r\nremoving all
its
code.","sha":"c44b7de7a23fbd5b11b31cc8d39c5baffb6c8d6f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"title":"[APM][ECO]
Removing Entities inventory from
APM","number":195116,"url":"https://github.com/elastic/kibana/pull/195116","mergeCommit":{"message":"[APM][ECO]
Removing Entities inventory from APM (#195116)\n\ncloses
https://github.com/elastic/kibana/issues/194114\r\n\r\nWe will no longer
show the entity inventory page on the APM UI. So, I'm\r\nremoving all
its
code.","sha":"c44b7de7a23fbd5b11b31cc8d39c5baffb6c8d6f"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195116","number":195116,"mergeCommit":{"message":"[APM][ECO]
Removing Entities inventory from APM (#195116)\n\ncloses
https://github.com/elastic/kibana/issues/194114\r\n\r\nWe will no longer
show the entity inventory page on the APM UI. So, I'm\r\nremoving all
its
code.","sha":"c44b7de7a23fbd5b11b31cc8d39c5baffb6c8d6f"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[APM] Clean up the code to remove all references to entities.

7 participants