[Security Solution] Fix flaky unified component test #189791#195093
Merged
logeekal merged 5 commits intoelastic:mainfrom Oct 7, 2024
Merged
[Security Solution] Fix flaky unified component test #189791#195093logeekal merged 5 commits intoelastic:mainfrom
logeekal merged 5 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
janmonschke
approved these changes
Oct 7, 2024
Contributor
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 7, 2024
…lastic#195093) ## Summary Fixes elastic#189791 Pagination test suite was timing out because huge number of records in data grid was rendering in JSDOM which were creating performance issues. This PR fixes that so that test does not times out. (cherry picked from commit 67f2b7c)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 7, 2024
…195093) (#195238) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Fix flaky unified component test #189791 (#195093)](#195093) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jatin Kathuria","email":"jatin.kathuria@elastic.co"},"sourceCommit":{"committedDate":"2024-10-07T12:15:31Z","message":"[Security Solution] Fix flaky unified component test #189791 (#195093)\n\n## Summary\r\n\r\nFixes #189791\r\n\r\nPagination test suite was timing out because huge number of records in\r\ndata grid was rendering in JSDOM which were creating performance issues.\r\nThis PR fixes that so that test does not times out.","sha":"67f2b7cad2df49dbfec4a9603f01fbd6e76f8cb9","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","backport:prev-minor"],"title":"[Security Solution] Fix flaky unified component test #189791","number":195093,"url":"https://github.com/elastic/kibana/pull/195093","mergeCommit":{"message":"[Security Solution] Fix flaky unified component test #189791 (#195093)\n\n## Summary\r\n\r\nFixes #189791\r\n\r\nPagination test suite was timing out because huge number of records in\r\ndata grid was rendering in JSDOM which were creating performance issues.\r\nThis PR fixes that so that test does not times out.","sha":"67f2b7cad2df49dbfec4a9603f01fbd6e76f8cb9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195093","number":195093,"mergeCommit":{"message":"[Security Solution] Fix flaky unified component test #189791 (#195093)\n\n## Summary\r\n\r\nFixes #189791\r\n\r\nPagination test suite was timing out because huge number of records in\r\ndata grid was rendering in JSDOM which were creating performance issues.\r\nThis PR fixes that so that test does not times out.","sha":"67f2b7cad2df49dbfec4a9603f01fbd6e76f8cb9"}}]}] BACKPORT--> Co-authored-by: Jatin Kathuria <jatin.kathuria@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #189791
Pagination test suite was timing out because huge number of records in data grid was rendering in JSDOM which were creating performance issues. This PR fixes that so that test does not times out.