[Monitoring] Fix system index label in Stack Monitoring screen#194839
Merged
consulthys merged 1 commit intomainfrom Oct 3, 2024
Merged
[Monitoring] Fix system index label in Stack Monitoring screen#194839consulthys merged 1 commit intomainfrom
consulthys merged 1 commit intomainfrom
Conversation
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: cc @consulthys |
tiansivive
pushed a commit
to tiansivive/kibana
that referenced
this pull request
Oct 7, 2024
…ic#194839) Closes elastic#194838 ## Summary This PR wraps up the change made in elastic#76946 (issue elastic#77492) The change was about relabeling the "Show system indices" toggle showing below to "Filter for system indices", but when no indices show up, the warning message still contains the old text, i.e. "Show system indices"   ### Checklist - [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [X] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [X] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #194838
Summary
This PR wraps up the change made in #76946 (issue #77492)
The change was about relabeling the "Show system indices" toggle showing below to "Filter for system indices", but when no indices show up, the warning message still contains the old text, i.e. "Show system indices"
Checklist