fix: [Obs Services > Create Service Group modal][KEYBOARD]: Focus should not be auto-set on first input when modal appears#194696
Merged
alexwizp merged 8 commits intoelastic:mainfrom Oct 7, 2024
Merged
Conversation
…uld not be auto-set on first input when modal appears Closes: https://github.com/elastic/observability-accessibility/issues/25 Closes: https://github.com/elastic/observability-accessibility/issues/26
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Contributor
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
...ility_solution/apm/public/components/app/service_groups/service_group_save/group_details.tsx
Show resolved
Hide resolved
...ility_solution/apm/public/components/app/service_groups/service_group_save/group_details.tsx
Show resolved
Hide resolved
...ility_solution/apm/public/components/app/service_groups/service_group_save/group_details.tsx
Show resolved
Hide resolved
...ility_solution/apm/public/components/app/service_groups/service_group_save/group_details.tsx
Outdated
Show resolved
Hide resolved
...ility_solution/apm/public/components/app/service_groups/service_group_save/group_details.tsx
Show resolved
Hide resolved
...ity_solution/apm/public/components/app/service_groups/service_group_save/select_services.tsx
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Contributor
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 7, 2024
…uld not be auto-set on first input when modal appears (elastic#194696) Closes: elastic#194965 Closes: elastic#194966 # Description - [x] elastic#194965 <br /> Focus is currently being set on the first input in the "Create group" modal. Screen reader users will hear the input name, but not get the title of the modal read aloud this way, and it could be confusing. We should be letting the EuiModal set focus naturally on the modal or close button so screen reader users hear the title as expected. - [x] elastic#194966 <br /> Focus must be returned properly when I cancel the "Create group" workflow in Services > Create service group modal. # Changes Made 1. Removed: ```diff - inputRef.current?.focus(); // autofocus on initial render ``` 2. Added `aria-labelledby={modalTitleId}` for `EuiModal`. See https://eui.elastic.co/#/layout/modal. 3. Slightly updated `Name` and `Color` validation. # Screen https://github.com/user-attachments/assets/6636f2dc-b9b7-4d4d-8144-90249f8327e7 (cherry picked from commit d576365)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 7, 2024
…Focus should not be auto-set on first input when modal appears (#194696) (#195235) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [Obs Services > Create Service Group modal][KEYBOARD]: Focus should not be auto-set on first input when modal appears (#194696)](#194696) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"alexwizp@gmail.com"},"sourceCommit":{"committedDate":"2024-10-07T12:04:39Z","message":"fix: [Obs Services > Create Service Group modal][KEYBOARD]: Focus should not be auto-set on first input when modal appears (#194696)\n\nCloses: #194965 \r\nCloses: https://github.com/elastic/kibana/issues/194966\r\n\r\n# Description \r\n\r\n- [x] #194965 <br /> Focus is\r\ncurrently being set on the first input in the \"Create group\" modal.\r\nScreen reader users will hear the input name, but not get the title of\r\nthe modal read aloud this way, and it could be confusing. We should be\r\nletting the EuiModal set focus naturally on the modal or close button so\r\nscreen reader users hear the title as expected.\r\n\r\n\r\n- [x] #194966 <br /> Focus must\r\nbe returned properly when I cancel the \"Create group\" workflow in\r\nServices > Create service group modal.\r\n\r\n# Changes Made\r\n\r\n1. Removed:\r\n\r\n```diff \r\n- inputRef.current?.focus(); // autofocus on initial render\r\n```\r\n\r\n2. Added `aria-labelledby={modalTitleId}` for `EuiModal`. See\r\nhttps://eui.elastic.co/#/layout/modal.\r\n3. Slightly updated `Name` and `Color` validation.\r\n\r\n\r\n# Screen\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6636f2dc-b9b7-4d4d-8144-90249f8327e7","sha":"d5763658c39856aefb5e15fa9e3e771f8bb0d613","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","apm:review"],"title":"fix: [Obs Services > Create Service Group modal][KEYBOARD]: Focus should not be auto-set on first input when modal appears","number":194696,"url":"https://github.com/elastic/kibana/pull/194696","mergeCommit":{"message":"fix: [Obs Services > Create Service Group modal][KEYBOARD]: Focus should not be auto-set on first input when modal appears (#194696)\n\nCloses: #194965 \r\nCloses: https://github.com/elastic/kibana/issues/194966\r\n\r\n# Description \r\n\r\n- [x] #194965 <br /> Focus is\r\ncurrently being set on the first input in the \"Create group\" modal.\r\nScreen reader users will hear the input name, but not get the title of\r\nthe modal read aloud this way, and it could be confusing. We should be\r\nletting the EuiModal set focus naturally on the modal or close button so\r\nscreen reader users hear the title as expected.\r\n\r\n\r\n- [x] #194966 <br /> Focus must\r\nbe returned properly when I cancel the \"Create group\" workflow in\r\nServices > Create service group modal.\r\n\r\n# Changes Made\r\n\r\n1. Removed:\r\n\r\n```diff \r\n- inputRef.current?.focus(); // autofocus on initial render\r\n```\r\n\r\n2. Added `aria-labelledby={modalTitleId}` for `EuiModal`. See\r\nhttps://eui.elastic.co/#/layout/modal.\r\n3. Slightly updated `Name` and `Color` validation.\r\n\r\n\r\n# Screen\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6636f2dc-b9b7-4d4d-8144-90249f8327e7","sha":"d5763658c39856aefb5e15fa9e3e771f8bb0d613"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194696","number":194696,"mergeCommit":{"message":"fix: [Obs Services > Create Service Group modal][KEYBOARD]: Focus should not be auto-set on first input when modal appears (#194696)\n\nCloses: #194965 \r\nCloses: https://github.com/elastic/kibana/issues/194966\r\n\r\n# Description \r\n\r\n- [x] #194965 <br /> Focus is\r\ncurrently being set on the first input in the \"Create group\" modal.\r\nScreen reader users will hear the input name, but not get the title of\r\nthe modal read aloud this way, and it could be confusing. We should be\r\nletting the EuiModal set focus naturally on the modal or close button so\r\nscreen reader users hear the title as expected.\r\n\r\n\r\n- [x] #194966 <br /> Focus must\r\nbe returned properly when I cancel the \"Create group\" workflow in\r\nServices > Create service group modal.\r\n\r\n# Changes Made\r\n\r\n1. Removed:\r\n\r\n```diff \r\n- inputRef.current?.focus(); // autofocus on initial render\r\n```\r\n\r\n2. Added `aria-labelledby={modalTitleId}` for `EuiModal`. See\r\nhttps://eui.elastic.co/#/layout/modal.\r\n3. Slightly updated `Name` and `Color` validation.\r\n\r\n\r\n# Screen\r\n\r\n\r\nhttps://github.com/user-attachments/assets/6636f2dc-b9b7-4d4d-8144-90249f8327e7","sha":"d5763658c39856aefb5e15fa9e3e771f8bb0d613"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #194965
Closes: #194966
Description
[Obs Services > Create Service Group modal][KEYBOARD]: Focus should not be auto-set on first input when modal appears #194965
Focus is currently being set on the first input in the "Create group" modal. Screen reader users will hear the input name, but not get the title of the modal read aloud this way, and it could be confusing. We should be letting the EuiModal set focus naturally on the modal or close button so screen reader users hear the title as expected.
[Obs Services > Create Service Group modal][KEYBOARD]: Focus must be returned to Create group button when cancelled #194966
Focus must be returned properly when I cancel the "Create group" workflow in Services > Create service group modal.
Changes Made
- inputRef.current?.focus(); // autofocus on initial renderaria-labelledby={modalTitleId}forEuiModal. See https://eui.elastic.co/#/layout/modal.NameandColorvalidation.Screen
Screen.Recording.2024-10-02.at.15.32.49.mov