[Migrations] Fix integration tests that use ZIP archives that are not compatible with 9.0.0 by gsoldevila · Pull Request #193856 · elastic/kibana

gsoldevila · 2024-09-24T12:09:44Z

Summary

Part of https://github.com/elastic/kibana-team/issues/1113

elasticmachine · 2024-09-24T12:09:47Z

Pinging @elastic/kibana-core (Team:Core)

afharo

LGTM. I just added a few nits for your consideration.

afharo · 2024-09-24T13:21:51Z

src/core/server/integration_tests/saved_objects/migrations/group2/multi_node_split.test.ts

@@ -0,0 +1,292 @@
+/*


nit: this one might need its own group, as starting multiple Kibanas, with delays increase the execution time, and the chances of failing due to timeouts (and retrying the whole CI job).

It already has its own group, there aren't any other tests in group2 anymore 😛 .
I will increase jest timeout though, thanks for raising the poing

afharo · 2024-09-24T13:22:46Z

src/core/server/integration_tests/saved_objects/migrations/group2/multi_node_split.test.ts

+  afterEach(async () => {
+    checkMigratorsResults();
+    await checkIndicesInfo();
+    await checkSavedObjectDocuments();
+    await checkMigratorsSteps();
+    await checkUpToDateOnRestart();
+  });
+
+  afterEach(async () => {
+    await esServer?.stop();
+    await delay(5); // give it a few seconds... cause we always do ¯\_(ツ)_/¯
+  });


2 afterEach where esServer can be stopped before completing the checks in the other afterEach.

Oh, that's a good catch, will put them together + finally block.

afharo · 2024-09-24T13:23:21Z

src/core/server/integration_tests/saved_objects/migrations/group2/multi_node_split.test.ts

+  afterEach(async () => {
+    checkMigratorsResults();
+    await checkIndicesInfo();
+    await checkSavedObjectDocuments();
+    await checkMigratorsSteps();
+    await checkUpToDateOnRestart();
+  });


I love the shared piece of code, but it feels weird to run the validations in the after phase.

I wonder if an it.each with a table format (description and delay) that runs startWithDelay + these checks is better.

I like the idea, will update it

afharo · 2024-09-24T13:28:40Z

src/core/server/integration_tests/saved_objects/migrations/group2/multi_node_split.test.ts

@@ -0,0 +1,292 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one


nit: there's another file multiple_es_nodes. Should we specify this one to be multi_kb_node_split?

Accepted proposal, will rename to to multiple_kb_nodes

…not find those)

… failing on next minor)

gsoldevila · 2024-09-26T08:09:53Z

Already backported with #194013

afharo · 2024-09-26T08:42:32Z

Already backported with #194013

I think you meant to post that comment in #193328, right?

kibana-ci · 2024-09-26T09:46:12Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 600d336

Failed CI Steps

Jest Integration Tests #2

Test Failures

[job] [logs] Jest Integration Tests #2 / migration actions reindex & waitForReindexTask resolves left wait_for_task_completion_timeout when the task does not finish within the timeout

Metrics [docs]

✅ unchanged

History

💛 Build #237005 was flaky e7deb81
💔 Build #236955 failed 21808e1
💔 Build #236687 failed 28a0326
💔 Build #236635 failed a85edf6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gsoldevila · 2024-09-26T10:23:09Z

I think you meant to post that comment in #193328, right?

In fact #194013 will backport multiple of the tests' updates:

[Migrations] Provide testing archives + tooling for migrations integration tests #193328
[Migrations] Fix integration tests that use ZIP archives that are not compatible with 9.0.0 #193856
[Migrations] Upgrade tests to use 9.x compatible archives #193696

There are dependencies between them, and on top of that I need to generate the 8.16.0 baseline zip archives (wrote a test for that). If I backport them one by one it'll take ages.

# Backport This will backport the following PRs from `main` to `8.x`: - #193328 - #193856 - #193696 - #194151

Create multi_node_split test

a85edf6

gsoldevila added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes Feature:Migrations labels Sep 24, 2024

gsoldevila requested a review from a team as a code owner September 24, 2024 12:09

gsoldevila added the backport:prev-major label Sep 24, 2024

afharo approved these changes Sep 24, 2024

View reviewed changes

gsoldevila added backport:prev-minor and removed backport:prev-major labels Sep 24, 2024

Address PR feedback

28a0326

gsoldevila changed the title ~~[Migrations] Create multi_node_split test~~ [Migrations] Create multiple_kb_nodes test Sep 24, 2024

gsoldevila added 4 commits September 25, 2024 10:33

Fix failing test

92dbfaf

Fix split_failed_to_clone test

782615b

Fix read_batch_size test

985f186

Fix actions test

21808e1

gsoldevila changed the title ~~[Migrations] Create multiple_kb_nodes test~~ [Migrations] Fix integration tests that use ZIP archives that are not compatible with 9.0.0 Sep 25, 2024

gsoldevila added 2 commits September 25, 2024 15:08

Only check the steps for the first node (the rest of the nodes might …

e7deb81

…not find those)

Use a fixed version for the archive utils (otherwise tests will start…

600d336

… failing on next minor)

gsoldevila added backport:skip This PR does not require backporting and removed backport:prev-minor labels Sep 26, 2024

gsoldevila enabled auto-merge (squash) September 26, 2024 08:09

gsoldevila mentioned this pull request Sep 26, 2024

[8.x] [Migrations] Backport ALL updates to integration tests #194013

Merged

gsoldevila merged commit ac96a4c into elastic:main Sep 26, 2024

kibanamachine added the v9.0.0 label Sep 26, 2024

gsoldevila added a commit that referenced this pull request Sep 27, 2024

[8.x] [Migrations] Backport ALL updates to integration tests (#194013)

c7b29d1

# Backport This will backport the following PRs from `main` to `8.x`: - #193328 - #193856 - #193696 - #194151

gsoldevila mentioned this pull request Oct 1, 2024

Saved object migrations using 7.x indices are not able to run against 9.0.0 #192633

Closed

		@@ -0,0 +1,292 @@
		/*
		* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one

Conversation

gsoldevila commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Sep 24, 2024

Uh oh!

afharo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gsoldevila commented Sep 26, 2024

Uh oh!

afharo commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kibana-ci commented Sep 26, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

History

Uh oh!

gsoldevila commented Sep 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gsoldevila commented Sep 24, 2024 •

edited

Loading

afharo commented Sep 26, 2024 •

edited

Loading