Remove feature flag for manual rule run#193833
Merged
nkhristinin merged 9 commits intoelastic:mainfrom Oct 9, 2024
Merged
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
dplumlee
approved these changes
Sep 25, 2024
Contributor
dplumlee
left a comment
There was a problem hiding this comment.
Rule management changes lgtm
Contributor
Author
|
@elasticmachine merge upstream |
rylnd
approved these changes
Sep 26, 2024
Contributor
rylnd
left a comment
There was a problem hiding this comment.
I think there are some additional comments that can/should be deleted, here, but otherwise LGTM!
| const es = getService('es'); | ||
|
|
||
| // Currently FF are not supported on MKI environments, so this test should be skipped from MKI environments. | ||
| // Once `manualRuleRunEnabled` FF is removed, we can remove `@skipInServerlessMKI` as well |
Contributor
There was a problem hiding this comment.
I think the comment line before this one can also be removed.
| 'Detection rules, preview', | ||
| { | ||
| // Currently FF are not supported on MKI environments, so this test should be skipped from MKI environments. | ||
| // Once `manualRuleRunEnabled` FF is removed, we can remove `@skipInServerlessMKI` as well |
Contributor
There was a problem hiding this comment.
I think the comment line before this one can also be removed.
| import { login } from '../../../../tasks/login'; | ||
|
|
||
| // Currently FF are not supported on MKI environments, so this test should be skipped from MKI environments. | ||
| // Once `manualRuleRunEnabled` FF is removed, we can remove `@skipInServerlessMKI` as well |
Contributor
There was a problem hiding this comment.
I think the comment line before this one can also be removed.
| import { login } from '../../../../tasks/login'; | ||
|
|
||
| // Currently FF are not supported on MKI environments, so this test should be skipped from MKI environments. | ||
| // Once `manualRuleRunEnabled` FF is removed, we can remove `@skipInServerlessMKI` as well |
Contributor
There was a problem hiding this comment.
I think the comment line before this one can also be removed.
Contributor
Author
|
@elasticmachine merge upstream |
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
…in/kibana into remove-feature-flag-manual-run
MadameSheema
approved these changes
Oct 9, 2024
Contributor
MadameSheema
left a comment
There was a problem hiding this comment.
sec-eng-prod changes LGTM!!
Please check if any of the tests meet the criteria to be added to the Kibana QA quality gate. Thanks!
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
⏳ Build in-progress
History
|
Contributor
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 9, 2024
## Summary Remove feature flag for manual rule run --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 3f75a1d)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 9, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Remove feature flag for manual rule run (#193833)](#193833) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Khristinin Nikita","email":"nikita.khristinin@elastic.co"},"sourceCommit":{"committedDate":"2024-10-09T17:23:46Z","message":"Remove feature flag for manual rule run (#193833)\n\n## Summary\r\n\r\nRemove feature flag for manual rule run\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"3f75a1d3d56e1d2c84ed0d4c5b18b3beb8357d3b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:cloud-deploy","ci:cloud-persist-deployment","ci:project-deploy-security"],"title":"Remove feature flag for manual rule run","number":193833,"url":"https://github.com/elastic/kibana/pull/193833","mergeCommit":{"message":"Remove feature flag for manual rule run (#193833)\n\n## Summary\r\n\r\nRemove feature flag for manual rule run\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"3f75a1d3d56e1d2c84ed0d4c5b18b3beb8357d3b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193833","number":193833,"mergeCommit":{"message":"Remove feature flag for manual rule run (#193833)\n\n## Summary\r\n\r\nRemove feature flag for manual rule run\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"3f75a1d3d56e1d2c84ed0d4c5b18b3beb8357d3b"}}]}] BACKPORT--> Co-authored-by: Khristinin Nikita <nikita.khristinin@elastic.co>
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove feature flag for manual rule run