Skip to content

[Response Ops][Rules] Rule Model Version Forward Compat#193233

Merged
JiaweiWu merged 3 commits intoelastic:mainfrom
JiaweiWu:rule-schema-forward-compat
Sep 20, 2024
Merged

[Response Ops][Rules] Rule Model Version Forward Compat#193233
JiaweiWu merged 3 commits intoelastic:mainfrom
JiaweiWu:rule-schema-forward-compat

Conversation

@JiaweiWu
Copy link
Copy Markdown
Contributor

@JiaweiWu JiaweiWu commented Sep 17, 2024

Summary

This PR implements the forwardCompatibility field for the rule model version in preparation for the flapping PR (#190019). We're doing this so we have the point to revert back to if we need to where the forwardCompatibility is defined.

@JiaweiWu JiaweiWu added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.16.0 labels Sep 17, 2024
@JiaweiWu JiaweiWu requested a review from a team as a code owner September 17, 2024 23:42
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

… src/core/server/integration_tests/ci_checks'
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner September 18, 2024 00:21
@JiaweiWu JiaweiWu enabled auto-merge (squash) September 20, 2024 07:16
@JiaweiWu
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #40 / Journey[many_fields_discover] Expand the first document

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@JiaweiWu JiaweiWu merged commit bb18996 into elastic:main Sep 20, 2024
@delanni
Copy link
Copy Markdown
Member

delanni commented Sep 20, 2024

@JiaweiWu - the PR has the v.8.16 label, yet it wasn't backported to 8.16 (8.x) - if this PR is not meant for 9.0 only, please remove the backport:skip label, and use backport:prev-minor or backport:version

@delanni delanni added backport:prev-minor and removed backport:skip This PR does not require backporting labels Sep 23, 2024
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 23, 2024
## Summary

This PR implements the `forwardCompatibility` field for the rule model
version in preparation for the flapping PR
(elastic#190019). We're doing this so we
have the point to revert back to if we need to where the
`forwardCompatibility` is defined.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit bb18996)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 23, 2024
… (#193695)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Response Ops][Rules] Rule Model Version Forward Compat
(#193233)](#193233)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jiawei
Wu","email":"74562234+JiaweiWu@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-20T08:50:54Z","message":"[Response
Ops][Rules] Rule Model Version Forward Compat (#193233)\n\n##
Summary\r\n\r\nThis PR implements the `forwardCompatibility` field for
the rule model\r\nversion in preparation for the flapping
PR\r\n(#190019). We're doing this
so we\r\nhave the point to revert back to if we need to where
the\r\n`forwardCompatibility` is
defined.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"bb1899653f6fc077d443a600bce6c6f2fc775964","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Response
Ops][Rules] Rule Model Version Forward
Compat","number":193233,"url":"https://github.com/elastic/kibana/pull/193233","mergeCommit":{"message":"[Response
Ops][Rules] Rule Model Version Forward Compat (#193233)\n\n##
Summary\r\n\r\nThis PR implements the `forwardCompatibility` field for
the rule model\r\nversion in preparation for the flapping
PR\r\n(#190019). We're doing this
so we\r\nhave the point to revert back to if we need to where
the\r\n`forwardCompatibility` is
defined.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"bb1899653f6fc077d443a600bce6c6f2fc775964"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193233","number":193233,"mergeCommit":{"message":"[Response
Ops][Rules] Rule Model Version Forward Compat (#193233)\n\n##
Summary\r\n\r\nThis PR implements the `forwardCompatibility` field for
the rule model\r\nversion in preparation for the flapping
PR\r\n(#190019). We're doing this
so we\r\nhave the point to revert back to if we need to where
the\r\n`forwardCompatibility` is
defined.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"bb1899653f6fc077d443a600bce6c6f2fc775964"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Jiawei Wu <74562234+JiaweiWu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.16.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants