[Response Ops][Rules] Rule Model Version Forward Compat#193233
Merged
JiaweiWu merged 3 commits intoelastic:mainfrom Sep 20, 2024
Merged
[Response Ops][Rules] Rule Model Version Forward Compat#193233JiaweiWu merged 3 commits intoelastic:mainfrom
JiaweiWu merged 3 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
adcoelho
approved these changes
Sep 17, 2024
… src/core/server/integration_tests/ci_checks'
cnasikas
approved these changes
Sep 18, 2024
jloleysens
approved these changes
Sep 18, 2024
Contributor
Author
|
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
To update your PR or re-run it, just comment with: |
Member
|
@JiaweiWu - the PR has the v.8.16 label, yet it wasn't backported to 8.16 ( |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 23, 2024
## Summary This PR implements the `forwardCompatibility` field for the rule model version in preparation for the flapping PR (elastic#190019). We're doing this so we have the point to revert back to if we need to where the `forwardCompatibility` is defined. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit bb18996)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 23, 2024
… (#193695) # Backport This will backport the following commits from `main` to `8.x`: - [[Response Ops][Rules] Rule Model Version Forward Compat (#193233)](#193233) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Jiawei Wu","email":"74562234+JiaweiWu@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-20T08:50:54Z","message":"[Response Ops][Rules] Rule Model Version Forward Compat (#193233)\n\n## Summary\r\n\r\nThis PR implements the `forwardCompatibility` field for the rule model\r\nversion in preparation for the flapping PR\r\n(#190019). We're doing this so we\r\nhave the point to revert back to if we need to where the\r\n`forwardCompatibility` is defined.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bb1899653f6fc077d443a600bce6c6f2fc775964","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"[Response Ops][Rules] Rule Model Version Forward Compat","number":193233,"url":"https://github.com/elastic/kibana/pull/193233","mergeCommit":{"message":"[Response Ops][Rules] Rule Model Version Forward Compat (#193233)\n\n## Summary\r\n\r\nThis PR implements the `forwardCompatibility` field for the rule model\r\nversion in preparation for the flapping PR\r\n(#190019). We're doing this so we\r\nhave the point to revert back to if we need to where the\r\n`forwardCompatibility` is defined.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bb1899653f6fc077d443a600bce6c6f2fc775964"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193233","number":193233,"mergeCommit":{"message":"[Response Ops][Rules] Rule Model Version Forward Compat (#193233)\n\n## Summary\r\n\r\nThis PR implements the `forwardCompatibility` field for the rule model\r\nversion in preparation for the flapping PR\r\n(#190019). We're doing this so we\r\nhave the point to revert back to if we need to where the\r\n`forwardCompatibility` is defined.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"bb1899653f6fc077d443a600bce6c6f2fc775964"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Jiawei Wu <74562234+JiaweiWu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the
forwardCompatibilityfield for the rule model version in preparation for the flapping PR (#190019). We're doing this so we have the point to revert back to if we need to where theforwardCompatibilityis defined.