[dev/precommitHook] log all failures, don't stop at first#19271
Merged
spalger merged 4 commits intoelastic:masterfrom Jun 22, 2018
Merged
[dev/precommitHook] log all failures, don't stop at first#19271spalger merged 4 commits intoelastic:masterfrom
spalger merged 4 commits intoelastic:masterfrom
Conversation
Contributor
💚 Build Succeeded |
Contributor
|
You have conflicts here |
…tiple-precommit-failures
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins, test this |
Contributor
💚 Build Succeeded |
…tiple-precommit-failures
Contributor
Author
|
@epixa can you take a look at this? |
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
|
@spalger Yep, I will take a look, but it won't be for a couple of days. I'm working through some higher priority PRs first. |
…tiple-precommit-failures
Contributor
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jun 22, 2018
spalger
pushed a commit
that referenced
this pull request
Jun 22, 2018
Contributor
Author
|
6.x/6.4: c6a9b3c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in #19105, if there are multiple failures in the precommit hook only the first failure is logged. Instead, this implementation collects the errors rom all tasks and ensures that all are logged.
Perhaps once #19105 goes in we can migrate this to use
listrand merge errors that way.