[kbn-expandable-flyout] - refactor internal redux store#192644
Merged
PhilippeOberti merged 2 commits intoelastic:mainfrom Sep 16, 2024
Merged
[kbn-expandable-flyout] - refactor internal redux store#192644PhilippeOberti merged 2 commits intoelastic:mainfrom
PhilippeOberti merged 2 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
b52b00f to
3b1d961
Compare
1 task
3b1d961 to
19a1195
Compare
christineweng
approved these changes
Sep 16, 2024
Contributor
christineweng
left a comment
There was a problem hiding this comment.
Desk tested and LGTM! Thanks for cleaning up those casting too!
…e new ui changes coming soon
19a1195 to
4d58918
Compare
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 16, 2024
(cherry picked from commit d776e39)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 16, 2024
… (#193096) # Backport This will backport the following commits from `main` to `8.x`: - [[kbn-expandable-flyout] - refactor internal redux store (#192644)](#192644) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-09-16T21:37:36Z","message":"[kbn-expandable-flyout] - refactor internal redux store (#192644)","sha":"d776e390b013b57badafa7951c19f279cdf0f59d","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[kbn-expandable-flyout] - refactor internal redux store","number":192644,"url":"https://github.com/elastic/kibana/pull/192644","mergeCommit":{"message":"[kbn-expandable-flyout] - refactor internal redux store (#192644)","sha":"d776e390b013b57badafa7951c19f279cdf0f59d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192644","number":192644,"mergeCommit":{"message":"[kbn-expandable-flyout] - refactor internal redux store (#192644)","sha":"d776e390b013b57badafa7951c19f279cdf0f59d"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR performs a small refactor work on the way the redux store is setup on the
kbn-expandable-flyoutpackage. We're currently making changes to the package to save more values to the redux store (see this draft PR for a sneak peak of the final result) and @christineweng had a great idea to refactor the top level properties of the redux store to better reflect the values saved.The 2 top level properties will be:
data: stores all the flyout panels information. This is basically all the flyout was storing until nowui: this is coming soon, it will store all the UI related information (push/overlay, collapsed and expanded widths...)This is how the store will look once finished:
Notes
This PR does not impact any of the places where the package is being used, the changes are purely internal.
Also, there aren't any behavior changes whatsoever. Here are the main code changes:
storefolderdatalevel2 PRs are incoming:
uitop level property to the redux storeuitop level of the redux storeTODO
Checklist
Will help #182526