chore(NA): upgrade to webpack 5#191106
Conversation
jughosta
left a comment
There was a problem hiding this comment.
Data Discovery changes LGTM 👍
Thanks!!
💚 Build SucceededMetrics [docs]Module Count
Public APIs missing comments
Any counts in public APIs
Async chunks
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled in files
ESLint disabled line counts
miscellaneous assets size
Total ESLint disabled count
History
cc @mistic |
|
Starting backport for target branches: 7.17, 8.16, 8.17, 8.18, 8.x, 9.0 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x, 9.0 |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
Summary
This PR contains the resulting work of a massive effort that ports our on top bundler abstraction (called @kbn/optimizer) from Webpack v4 into Webpack v5. It's essential in terms of long term maintenance since v4 was not receiving updates any longer but will also unblock some new features that could be beneficial for our future DevEx endeavours.
Next you can find a small list of all the accomplished tasks on this journey.
Completed Tasks
@kbn/optimizer-webpack-helpersto support webpack v5data.plugin.chunk.0.js/ciand make sure we get our first green CI, otherwise work on the errors until we donode scripts/build_kibana_platform_plugins --no-cache).--openssl-legacy-providerflagsNodePolyfillPlugin(here) and add each polyfill needed individually per each webpack config to check if we get smaller bundles. If we do it's better to go with the case by case need approach instead of deploying a bunch of polyfills with NodePolyfillPlugin. As another alternative, create a custom smaller plugin with only the union of all needed polyfills.@import 'src/core/public/mixins'does not work anymore (not a problem, we should use relative paths anyway but we want to track why it changed from v4 to v5)resourceQuery: { not: /raw/ }is not necessary on other webpack configs like storybook one__kbnBootstrap__can't be found