Skip to content

[Links] Fix positioning of dragged link in links editor#189122

Merged
nickpeihl merged 1 commit intoelastic:mainfrom
nickpeihl:fix-dragDrop-linksEditor
Jul 24, 2024
Merged

[Links] Fix positioning of dragged link in links editor#189122
nickpeihl merged 1 commit intoelastic:mainfrom
nickpeihl:fix-dragDrop-linksEditor

Conversation

@nickpeihl
Copy link
Copy Markdown
Contributor

@nickpeihl nickpeihl commented Jul 24, 2024

Summary

Fixes positioning of dragged links in the Links panel editor.

The issue was caused by the transform: translateZ(0) workaround in EUI to fix a mask image bug in Chromium. We fix this by overriding the transform for in the FlyoutBody of the Links panel editor.

Before:

links-drag-offset.mp4

After:

links-offset-fixed.mp4

@nickpeihl nickpeihl added release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v8.15.0 v8.16.0 labels Jul 24, 2024
@nickpeihl nickpeihl requested a review from cee-chen July 24, 2024 18:17
@nickpeihl nickpeihl requested a review from a team as a code owner July 24, 2024 18:17
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Copy link
Copy Markdown
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, this sounds like it was a nightmare bug to pin down!! Well done. Fix LGTM - code review only (plus looked at the videos) 👍

@nickpeihl nickpeihl enabled auto-merge (squash) July 24, 2024 18:28
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
links 48.0KB 48.1KB +77.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nickpeihl nickpeihl merged commit e566abf into elastic:main Jul 24, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 24, 2024
## Summary

Fixes positioning of dragged links in the Links panel editor.

The issue was caused by the `transform: translateZ(0)` workaround in EUI
to fix a [mask image bug](elastic/eui#7855) in
Chromium. We fix this by overriding the `transform` for in the
`FlyoutBody` of the Links panel editor.

Before:

https://github.com/user-attachments/assets/8ad10732-dfaa-4464-845b-0a9c4fc6b173

After:

https://github.com/user-attachments/assets/e6f0bffe-7eb0-4590-affc-a89bc86b973d
(cherry picked from commit e566abf)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 24, 2024
…) (#189129)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Links] Fix positioning of dragged link in links editor
(#189122)](#189122)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nick
Peihl","email":"nick.peihl@elastic.co"},"sourceCommit":{"committedDate":"2024-07-24T19:49:43Z","message":"[Links]
Fix positioning of dragged link in links editor (#189122)\n\n##
Summary\r\n\r\nFixes positioning of dragged links in the Links panel
editor.\r\n\r\nThe issue was caused by the `transform: translateZ(0)`
workaround in EUI\r\nto fix a [mask image
bug](elastic/eui#7855) in\r\nChromium. We fix
this by overriding the `transform` for in the\r\n`FlyoutBody` of the
Links panel
editor.\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8ad10732-dfaa-4464-845b-0a9c4fc6b173\r\n\r\nAfter:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e6f0bffe-7eb0-4590-affc-a89bc86b973d","sha":"e566abf1cb6317c381431c4902abd5554fea6217","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v8.15.0","v8.16.0"],"title":"[Links]
Fix positioning of dragged link in links
editor","number":189122,"url":"https://github.com/elastic/kibana/pull/189122","mergeCommit":{"message":"[Links]
Fix positioning of dragged link in links editor (#189122)\n\n##
Summary\r\n\r\nFixes positioning of dragged links in the Links panel
editor.\r\n\r\nThe issue was caused by the `transform: translateZ(0)`
workaround in EUI\r\nto fix a [mask image
bug](elastic/eui#7855) in\r\nChromium. We fix
this by overriding the `transform` for in the\r\n`FlyoutBody` of the
Links panel
editor.\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8ad10732-dfaa-4464-845b-0a9c4fc6b173\r\n\r\nAfter:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e6f0bffe-7eb0-4590-affc-a89bc86b973d","sha":"e566abf1cb6317c381431c4902abd5554fea6217"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189122","number":189122,"mergeCommit":{"message":"[Links]
Fix positioning of dragged link in links editor (#189122)\n\n##
Summary\r\n\r\nFixes positioning of dragged links in the Links panel
editor.\r\n\r\nThe issue was caused by the `transform: translateZ(0)`
workaround in EUI\r\nto fix a [mask image
bug](elastic/eui#7855) in\r\nChromium. We fix
this by overriding the `transform` for in the\r\n`FlyoutBody` of the
Links panel
editor.\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8ad10732-dfaa-4464-845b-0a9c4fc6b173\r\n\r\nAfter:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e6f0bffe-7eb0-4590-affc-a89bc86b973d","sha":"e566abf1cb6317c381431c4902abd5554fea6217"}}]}]
BACKPORT-->

Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v8.15.0 v8.16.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants