[Links] Fix positioning of dragged link in links editor#189122
Merged
nickpeihl merged 1 commit intoelastic:mainfrom Jul 24, 2024
Merged
[Links] Fix positioning of dragged link in links editor#189122nickpeihl merged 1 commit intoelastic:mainfrom
nickpeihl merged 1 commit intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Heenawter
approved these changes
Jul 24, 2024
Contributor
Heenawter
left a comment
There was a problem hiding this comment.
Oof, this sounds like it was a nightmare bug to pin down!! Well done. Fix LGTM - code review only (plus looked at the videos) 👍
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jul 24, 2024
## Summary Fixes positioning of dragged links in the Links panel editor. The issue was caused by the `transform: translateZ(0)` workaround in EUI to fix a [mask image bug](elastic/eui#7855) in Chromium. We fix this by overriding the `transform` for in the `FlyoutBody` of the Links panel editor. Before: https://github.com/user-attachments/assets/8ad10732-dfaa-4464-845b-0a9c4fc6b173 After: https://github.com/user-attachments/assets/e6f0bffe-7eb0-4590-affc-a89bc86b973d (cherry picked from commit e566abf)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jul 24, 2024
…) (#189129) # Backport This will backport the following commits from `main` to `8.15`: - [[Links] Fix positioning of dragged link in links editor (#189122)](#189122) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nick Peihl","email":"nick.peihl@elastic.co"},"sourceCommit":{"committedDate":"2024-07-24T19:49:43Z","message":"[Links] Fix positioning of dragged link in links editor (#189122)\n\n## Summary\r\n\r\nFixes positioning of dragged links in the Links panel editor.\r\n\r\nThe issue was caused by the `transform: translateZ(0)` workaround in EUI\r\nto fix a [mask image bug](elastic/eui#7855) in\r\nChromium. We fix this by overriding the `transform` for in the\r\n`FlyoutBody` of the Links panel editor.\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8ad10732-dfaa-4464-845b-0a9c4fc6b173\r\n\r\nAfter:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e6f0bffe-7eb0-4590-affc-a89bc86b973d","sha":"e566abf1cb6317c381431c4902abd5554fea6217","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:Presentation","v8.15.0","v8.16.0"],"title":"[Links] Fix positioning of dragged link in links editor","number":189122,"url":"https://github.com/elastic/kibana/pull/189122","mergeCommit":{"message":"[Links] Fix positioning of dragged link in links editor (#189122)\n\n## Summary\r\n\r\nFixes positioning of dragged links in the Links panel editor.\r\n\r\nThe issue was caused by the `transform: translateZ(0)` workaround in EUI\r\nto fix a [mask image bug](elastic/eui#7855) in\r\nChromium. We fix this by overriding the `transform` for in the\r\n`FlyoutBody` of the Links panel editor.\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8ad10732-dfaa-4464-845b-0a9c4fc6b173\r\n\r\nAfter:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e6f0bffe-7eb0-4590-affc-a89bc86b973d","sha":"e566abf1cb6317c381431c4902abd5554fea6217"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189122","number":189122,"mergeCommit":{"message":"[Links] Fix positioning of dragged link in links editor (#189122)\n\n## Summary\r\n\r\nFixes positioning of dragged links in the Links panel editor.\r\n\r\nThe issue was caused by the `transform: translateZ(0)` workaround in EUI\r\nto fix a [mask image bug](elastic/eui#7855) in\r\nChromium. We fix this by overriding the `transform` for in the\r\n`FlyoutBody` of the Links panel editor.\r\n\r\nBefore:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8ad10732-dfaa-4464-845b-0a9c4fc6b173\r\n\r\nAfter:\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e6f0bffe-7eb0-4590-affc-a89bc86b973d","sha":"e566abf1cb6317c381431c4902abd5554fea6217"}}]}] BACKPORT--> Co-authored-by: Nick Peihl <nick.peihl@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes positioning of dragged links in the Links panel editor.
The issue was caused by the
transform: translateZ(0)workaround in EUI to fix a mask image bug in Chromium. We fix this by overriding thetransformfor in theFlyoutBodyof the Links panel editor.Before:
links-drag-offset.mp4
After:
links-offset-fixed.mp4