Skip to content

[8.15] [Security Solution ] Unified Timeline - Enables unified components by default and inverts the feature flag. (#187460)#188352

Closed
logeekal wants to merge 2 commits intoelastic:8.15from
logeekal:backport/8.15/pr-187460
Closed

[8.15] [Security Solution ] Unified Timeline - Enables unified components by default and inverts the feature flag. (#187460)#188352
logeekal wants to merge 2 commits intoelastic:8.15from
logeekal:backport/8.15/pr-187460

Conversation

@logeekal
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

Copy link
Copy Markdown
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this backport in!

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 15, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #13 / useTimelineColumns augmentedColumnHeaders should return the default columns
  • [job] [logs] Jest Tests #13 / useTimelineColumns augmentedColumnHeaders should return the default columns
  • [job] [logs] Jest Tests #13 / useTimelineColumns augmentedColumnHeaders should return the default unified data table (udt) columns
  • [job] [logs] Jest Tests #13 / useTimelineColumns augmentedColumnHeaders should return the default unified data table (udt) columns
  • [job] [logs] Jest Tests #13 / useTimelineColumns augmentedColumnHeaders should return the provided columns
  • [job] [logs] Jest Tests #13 / useTimelineColumns augmentedColumnHeaders should return the provided columns
  • [job] [logs] Jest Tests #13 / useTimelineColumns getTimelineQueryFieldsFromColumns should return the list of all the fields
  • [job] [logs] Jest Tests #13 / useTimelineColumns getTimelineQueryFieldsFromColumns should return the list of all the fields

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 16.7MB 16.7MB -1.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 86.7KB 86.7KB +1.0B

History

@logeekal logeekal disabled auto-merge July 16, 2024 08:40
@logeekal logeekal force-pushed the backport/8.15/pr-187460 branch from 463e415 to f85036d Compare July 16, 2024 09:03
logeekal added 2 commits July 16, 2024 12:45
… default and inverts the feature flag. (elastic#187460)

This PR inverts the feature flag from
`unifiedComponentsInTimelineEnabled` to
`unifiedComponentsInTimelineDisabled` with a defualt value of false.

- This is done so that users have the option to turn off the **unified
components**.
- This also adapts all relevant jest and cypress tests to assume that
`unified components` are enabled.

(cherry picked from commit 7d6c18a)
@logeekal logeekal force-pushed the backport/8.15/pr-187460 branch from f85036d to 54907e1 Compare July 16, 2024 10:45
@logeekal logeekal enabled auto-merge (squash) July 16, 2024 10:46
@logeekal logeekal closed this Jul 16, 2024
auto-merge was automatically disabled July 16, 2024 11:58

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants