[Security Solution ] Unified Timeline - Enables unified components by default and inverts the feature flag. by logeekal · Pull Request #187460 · elastic/kibana

logeekal · 2024-07-03T11:12:57Z

Summary

This PR inverts the feature flag from unifiedComponentsInTimelineEnabled to unifiedComponentsInTimelineDisabled with a defualt value of false.

This is done so that users have the option to turn off the unified components.
This also adapts all relevant jest and cypress tests to assume that unified components are enabled.

…neDisabled

logeekal · 2024-07-03T11:13:04Z

/ci

logeekal · 2024-07-03T14:46:49Z

/ci

logeekal · 2024-07-04T10:36:58Z

/ci

logeekal · 2024-07-10T07:44:35Z

/ci

elasticmachine · 2024-07-10T10:47:18Z

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

PhilippeOberti

code LGTM for the Threat Hunting Investigations team!

One small note though, there are a few places in the code where you changed

const something = unifiedComponentsInTimelineEnabled ? this : that;

into

const something = !!unifiedComponentsInTimelineDisabled ? this : that;

but for readability I feel like this would be easier on the eye?

const something = unifiedComponentsInTimelineDisabled ? that : this;

But maybe that's just me...

logeekal · 2024-07-10T14:07:28Z

@PhilippeOberti

One small note though, there are a few places in the code where you changed
const something = !!unifiedComponentsInTimelineDisabled ? this : that;

You are right. It is mistake most probably. I will change it. Thanks for the feedback.

logeekal · 2024-07-10T15:57:48Z

/ci

logeekal · 2024-07-11T16:49:38Z

const something = !!unifiedComponentsInTimelineDisabled ? this : that;

@PhilippeOberti , I could not find double exclamation in the code as you mentioned above. I think you meant single exclamation.

I kept it like it because it will be easier to remove as when removing we will automatically keep only the truthy value. ( because !unifiedComponentsInTimelineDisabled is the truth). That is why I kept it like this. Let me know if it makes sense.

semd

LGTM!

dplumlee

Rule management changes lgtm!

PhilippeOberti · 2024-07-15T07:33:43Z

const something = !!unifiedComponentsInTimelineDisabled ? this : that;
@PhilippeOberti , I could not find double exclamation in the code as you mentioned above. I think you meant single exclamation.

I kept it like it because it will be easier to remove as when removing we will automatically keep only the truthy value. ( because !unifiedComponentsInTimelineDisabled is the truth). That is why I kept it like this. Let me know if it makes sense.

I'm so sorry I didn't mean to have 2 exclamation marks. My original message was about switching !unifiedComponentsInTimelineDisabled to unifiedComponentsInTimelineDisabled as I felt the double negation was harder to read. But like you said it's meant to be short lived so it's ok!

elasticmachine · 2024-07-15T09:30:27Z

⏳ Build in-progress, with failures

Buildkite Build
Commit: 28c2c72

Failed CI Steps

Test Failures

[job] [logs] Jest Tests #8 / query tab with unified timeline columns should move column left/right correctly
[job] [logs] Jest Tests #8 / query tab with unified timeline columns should move column left/right correctly
[job] [logs] Jest Tests #8 / query tab with unified timeline columns should remove column
[job] [logs] Jest Tests #8 / query tab with unified timeline columns should remove column
[job] [logs] Jest Tests #8 / query tab with unified timeline columns should sort date column
[job] [logs] Jest Tests #8 / query tab with unified timeline columns should sort date column
[job] [logs] Jest Tests #8 / query tab with unified timeline columns should sort number column
[job] [logs] Jest Tests #8 / query tab with unified timeline columns should sort number column
[job] [logs] Jest Tests #8 / query tab with unified timeline columns should sort string column correctly
[job] [logs] Jest Tests #8 / query tab with unified timeline columns should sort string column correctly
[job] [logs] Jest Tests #8 / query tab with unified timeline Leading actions - notes securitySolutionNotesEnabled = false should have the notification dot & correct tooltip
[job] [logs] Jest Tests #8 / query tab with unified timeline Leading actions - notes securitySolutionNotesEnabled = false should have the notification dot & correct tooltip
[job] [logs] Jest Tests #8 / query tab with unified timeline Leading actions - notes securitySolutionNotesEnabled = true should be able to add notes through expandable flyout
[job] [logs] Jest Tests #8 / query tab with unified timeline Leading actions - notes securitySolutionNotesEnabled = true should be able to add notes through expandable flyout
[job] [logs] Jest Tests #8 / query tab with unified timeline Leading actions - notes securitySolutionNotesEnabled = true should have the notification dot & correct tooltip
[job] [logs] Jest Tests #8 / query tab with unified timeline Leading actions - notes securitySolutionNotesEnabled = true should have the notification dot & correct tooltip
[job] [logs] Jest Tests #8 / query tab with unified timeline left controls should be able to sort by multiple columns
[job] [logs] Jest Tests #8 / query tab with unified timeline left controls should be able to sort by multiple columns
[job] [logs] Jest Tests #8 / query tab with unified timeline left controls should clear all sorting
[job] [logs] Jest Tests #8 / query tab with unified timeline left controls should clear all sorting
[job] [logs] Jest Tests #8 / query tab with unified timeline pagination should load more records according to sample size correctly
[job] [logs] Jest Tests #8 / query tab with unified timeline pagination should load more records according to sample size correctly
[job] [logs] Jest Tests #8 / query tab with unified timeline pagination should paginate correctly
[job] [logs] Jest Tests #8 / query tab with unified timeline pagination should paginate correctly
[job] [logs] Jest Tests #8 / query tab with unified timeline render should hide row-renderers when disabled
[job] [logs] Jest Tests #8 / query tab with unified timeline render should hide row-renderers when disabled
[job] [logs] Jest Tests #8 / query tab with unified timeline render should render unified-field-list in timeline
[job] [logs] Jest Tests #8 / query tab with unified timeline render should render unified-field-list in timeline
[job] [logs] Jest Tests #8 / query tab with unified timeline render should render unifiedDataTable in timeline
[job] [logs] Jest Tests #8 / query tab with unified timeline render should render unifiedDataTable in timeline
[job] [logs] Jest Tests #8 / query tab with unified timeline render should show row-renderers correctly by default
[job] [logs] Jest Tests #8 / query tab with unified timeline render should show row-renderers correctly by default
[job] [logs] Jest Tests #8 / query tab with unified timeline unified fields list should add the column when clicked on ⊕ sign
[job] [logs] Jest Tests #8 / query tab with unified timeline unified fields list should add the column when clicked on ⊕ sign
[job] [logs] Jest Tests #8 / query tab with unified timeline unified fields list should remove the column when clicked on X sign
[job] [logs] Jest Tests #8 / query tab with unified timeline unified fields list should remove the column when clicked on X sign
[job] [logs] Jest Tests #8 / query tab with unified timeline unified fields list should should show callout when field search does not matches any field
[job] [logs] Jest Tests #8 / query tab with unified timeline unified fields list should should show callout when field search does not matches any field
[job] [logs] Jest Tests #8 / query tab with unified timeline unified fields list should toggle side bar correctly
[job] [logs] Jest Tests #8 / query tab with unified timeline unified fields list should toggle side bar correctly

History

MadameSheema · 2024-07-15T12:19:10Z

...ity_solution_cypress/cypress/e2e/investigations/timelines/unified_components/query_tab.cy.ts

  'Unsaved Timeline query tab',
  {
    tags: ['@ess', '@serverless', '@skipInServerlessMKI'],
-    env: {


If the FF is not needed anymore, consider to remove the @skipInServerlessMKI.

MadameSheema · 2024-07-15T12:19:15Z

...tion_cypress/cypress/e2e/investigations/timelines/unified_components/table_row_actions.cy.ts

  'Unified Timeline table Row Actions',
  {
    tags: ['@ess', '@serverless', '@skipInServerlessMKI'],
-    env: {


If the FF is not needed anymore, consider to remove the @skipInServerlessMKI.

paul-tavares

Changes owned by security-defend-workflows team looks good 👍

kibanamachine · 2024-07-15T17:29:51Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6547

[✅] Security Solution Investigations - Cypress: 25/25 tests passed.
[❌] [Serverless] Security Solution Investigations - Cypress: 12/25 tests passed.

see run history

logeekal · 2024-07-15T18:48:56Z

💚 All backports created successfully

Status	Branch	Result
✅	8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

logeekal · 2024-07-16T12:04:57Z

💚 All backports created successfully

Status	Branch	Result
✅	8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

invert unifiedComponentInTimelineEnabled to unifiedComponentsInTimeli…

59e33e6

…neDisabled

logeekal added backport:skip This PR does not require backporting Team:Threat Hunting:Investigations Security Solution Threat Hunting Investigations Team v8.15.0 labels Jul 3, 2024

fix: jest tests for new feature flag

302a530

fix: more tests

8cd9842

fix: cypress tests

92963c8

fix: more cypress tests

085a370

logeekal marked this pull request as ready for review July 10, 2024 10:47

logeekal requested review from a team as code owners July 10, 2024 10:47

logeekal requested a review from xcrzx July 10, 2024 10:47

logeekal requested review from a team, MadameSheema and patrykkopycinski as code owners July 10, 2024 11:35

logeekal removed request for a team July 10, 2024 11:38

logeekal added 2 commits July 10, 2024 13:39

fix: defend workflow cypress

304be51

Merge branch 'main' into fix/unified_feature_flag_invert

389e4c2

PhilippeOberti approved these changes Jul 10, 2024

View reviewed changes

fix: tests

8276849

logeekal added 2 commits July 11, 2024 12:36

fix: tests

164b9e0

fix: osquery cypress

4f51db6

semd approved these changes Jul 12, 2024

View reviewed changes

Merge branch 'main' into fix/unified_feature_flag_invert

30e51a5

dplumlee approved these changes Jul 12, 2024

View reviewed changes

logeekal added 2 commits July 12, 2024 17:59

Merge branch 'main' into fix/unified_feature_flag_invert

15e5e93

Merge branch 'main' into fix/unified_feature_flag_invert

8cde005

fix: dnd warnings

28c2c72

fix: dnd warnings repeat

0342e66

MadameSheema reviewed Jul 15, 2024

View reviewed changes

paul-tavares approved these changes Jul 15, 2024

View reviewed changes

kibanamachine mentioned this pull request Jul 15, 2024

[Bug][Investigations] - Fix timeline column reset #188240

Merged

logeekal mentioned this pull request Jul 15, 2024

[8.15] [Security Solution ] Unified Timeline - Enables unified components by default and inverts the feature flag. (#187460) #188352

Closed

logeekal mentioned this pull request Jul 16, 2024

[8.15] [Security Solution ] Unified Timeline - Enables unified components by default and inverts the feature flag. (#187460) #188421

Merged

PhilippeOberti mentioned this pull request Jul 18, 2024

[Security solution][Alert Details] Enable preview feature flag and cypress tests #188580

Merged

1 task

Conversation

logeekal commented Jul 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

logeekal commented Jul 3, 2024

Uh oh!

logeekal commented Jul 3, 2024

Uh oh!

logeekal commented Jul 4, 2024

Uh oh!

logeekal commented Jul 10, 2024

Uh oh!

elasticmachine commented Jul 10, 2024

Uh oh!

PhilippeOberti left a comment

Choose a reason for hiding this comment

Uh oh!

logeekal commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

logeekal commented Jul 10, 2024

Uh oh!

logeekal commented Jul 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

semd left a comment

Choose a reason for hiding this comment

Uh oh!

dplumlee left a comment

Choose a reason for hiding this comment

Uh oh!

PhilippeOberti commented Jul 15, 2024

Uh oh!

elasticmachine commented Jul 15, 2024

⏳ Build in-progress, with failures

Failed CI Steps

Test Failures

History

Uh oh!

MadameSheema Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

MadameSheema Jul 15, 2024

Choose a reason for hiding this comment

Uh oh!

paul-tavares left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jul 15, 2024

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#6547

Uh oh!

logeekal commented Jul 15, 2024

💚 All backports created successfully

Questions ?

Uh oh!

logeekal commented Jul 16, 2024

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

logeekal commented Jul 3, 2024 •

edited

Loading

logeekal commented Jul 10, 2024 •

edited

Loading

logeekal commented Jul 11, 2024 •

edited

Loading