Merged
Conversation
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
Contributor
|
/ci |
stratoula
reviewed
Jun 10, 2024
| testErrorsAndWarnings('from a_index | eval mv_zip(booleanField, booleanField)', [ | ||
| 'Argument of [mv_zip] must be [string], found value [booleanField] type [boolean]', | ||
| 'Argument of [mv_zip] must be [string], found value [booleanField] type [boolean]', | ||
| ]); |
Contributor
There was a problem hiding this comment.
Why are all these mv_zip tests have been added here? It only added the repeat function 🤔 cc @drewdaemon
Contributor
There was a problem hiding this comment.
I must not have run make:tests manually after updating the mv_zip definition. I don't think we need to worry.
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
stratoula
approved these changes
Jun 10, 2024
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Jun 13, 2024
This PR updates the function definitions based on the latest metadata from Elasticsearch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the function definitions based on the latest metadata from Elasticsearch.