[Storybook][i18n] initialize i18n with english locale#185033
Merged
Bamieh merged 4 commits intoelastic:mainfrom Jun 7, 2024
Merged
[Storybook][i18n] initialize i18n with english locale#185033Bamieh merged 4 commits intoelastic:mainfrom
Bamieh merged 4 commits intoelastic:mainfrom
Conversation
PhilippeOberti
approved these changes
Jun 7, 2024
Contributor
PhilippeOberti
left a comment
There was a problem hiding this comment.
Tested for 2 plugin Storybook (Security Solution and Threat Intelligence) and 1 package Storybook (kbn-expandable-flyout) and they all work now!
Thanks for fixing this!
jbudz
approved these changes
Jun 7, 2024
Contributor
Author
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Jun 13, 2024
## Summary We added a check to ensure that `i18n` is initialized on the browser before any javascript code uses `i18n`. We need to do the same in the storybook so it works properly. To summarize in a couple of pictures 😄 **Before PR:**  **After PR:**  cc @petrklapka
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We added a check to ensure that
i18nis initialized on the browser before any javascript code usesi18n. We need to do the same in the storybook so it works properly.To summarize in a couple of pictures 😄
Before PR:
After PR:
cc @petrklapka