Skip to content

[i18n] Fix broken i18n messages#185011

Merged
lukeelmers merged 2 commits intoelastic:mainfrom
Bamieh:i18n_fix_messages
Jun 7, 2024
Merged

[i18n] Fix broken i18n messages#185011
lukeelmers merged 2 commits intoelastic:mainfrom
Bamieh:i18n_fix_messages

Conversation

@Bamieh
Copy link
Copy Markdown
Contributor

@Bamieh Bamieh commented Jun 7, 2024 •
edited
Loading

Summary

We have recently upgraded the i18n packages which has some breaking changes.
The tooling upgrade to ensure that no malformed strings are in the codebase is still in progress.
The new code for the i18n_check is ready and I used it against main to detect all i18n issues we currently have in the codebase.

These are the resulting fixes we need to have in place.
I am doing this before the i18n tools are merged into main to give the core team the time to merge the PR without rushing into the code review. Additionally this ensures that the next serverless release does not contain any malformed strings.

Please filter code by team and check the changes.
The changes are:

  1. Update the message id (removing duplicate ids)
  2. Add ignoreTag: true where there is xml like tags that are not HTML.
  3. Add other case to plural and select ICU
  4. Escaped variables that needs to be unescaped

For more details about the i18n changes:

  1. Checkout the original PR summary [i18n][system upgrade] Upgrade Intl Packages from v2 to v6 #179506
  2. or the WIP docs https://docs.google.com/document/d/1sp71019HXKiUPKIXU1-_0x4I4jjHdM_EtJQlglm8KJc/edit
  3. Reach out to #kibana-localization or check the

@Bamieh Bamieh added release_note:skip Skip the PR/issue when compiling release notes 8.15 candidate labels Jun 7, 2024
@Bamieh Bamieh requested review from a team as code owners June 7, 2024 13:47
@Bamieh Bamieh requested a review from a team June 7, 2024 13:47
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Feature:Drilldowns Embeddable panel Drilldowns Team:Fleet Team label for Observability Data Collection Fleet team Team:Obs AI Assistant Observability AI Assistant labels Jun 7, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 7, 2024

Pinging @elastic/fleet (Team:Fleet)

peteharverson
peteharverson approved these changes Jun 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML edit LGTM

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Jun 7, 2024 •
edited
Loading

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
data 497 498 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiAssistantManagementSelection 44.6KB 44.6KB +27.0B
canvas 1.1MB 1.1MB +2.0B
console 455.9KB 455.9KB +32.0B
data 46.7KB 46.7KB +17.0B
dataViews 5.0KB 5.0KB +1.0B
enterpriseSearch 2.7MB 2.7MB +13.0B
fleet 1.3MB 1.3MB +2.0B
infra 1.5MB 1.5MB +25.0B
ml 4.1MB 4.1MB +13.0B
observabilityAiAssistantManagement 87.3KB 87.3KB +13.0B
stackAlerts 79.7KB 79.7KB -10.0B
triggersActionsUi 1.6MB 1.6MB -10.0B
total +125.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5500 +5500
total size - 8.9MB +8.9MB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 415.3KB 415.3KB +13.0B
dashboardEnhanced 17.7KB 17.7KB +2.0B
data 421.5KB 418.4KB -3.1KB
dataViews 61.8KB 61.6KB -213.0B
total -3.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kc13greiner kc13greiner self-requested a review June 7, 2024 15:48
alisonelizabeth
alisonelizabeth approved these changes Jun 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Management team changes LGTM (Console & UA)

nickofthyme
nickofthyme approved these changes Jun 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vis code changes LGTM 🎉

kc13greiner
kc13greiner reviewed Jun 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@kc13greiner kc13greiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question; maybe I set it up wrong though

@Bamieh Bamieh requested a review from kc13greiner June 7, 2024 17:01
@lukeelmers lukeelmers merged commit ae1d883 into elastic:main Jun 7, 2024
@kibanamachine kibanamachine added v8.15.0 backport:skip This PR does not require backporting labels Jun 7, 2024
@Bamieh Bamieh deleted the i18n_fix_messages branch June 7, 2024 20:21
@lukeelmers
Copy link
Copy Markdown
Contributor

lukeelmers commented Jun 7, 2024

We are making an exception and force-merging this as @Bamieh previously communicated:

  • we've passed the TTL for review
  • these are small, low-risk changes
  • it is critical to get these fixed on main quickly so we don't have missing translations

eokoneyo pushed a commit to eokoneyo/kibana that referenced this pull request Jun 13, 2024
@Bamieh @eokoneyo
[i18n] Fix broken i18n messages (elastic#185011)
0be47ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasolson lukasolson lukasolson approved these changes

@efegurkan efegurkan efegurkan approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@mikecote mikecote mikecote approved these changes

@alisonelizabeth alisonelizabeth alisonelizabeth approved these changes

@afharo afharo afharo approved these changes

@peteharverson peteharverson peteharverson approved these changes

@ThomThomson ThomThomson ThomThomson approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

@kc13greiner kc13greiner kc13greiner approved these changes

@elena-shostak elena-shostak elena-shostak approved these changes

+1 more reviewer

@jen-huang jen-huang jen-huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.15 candidate backport:skip This PR does not require backporting ci:project-deploy-observability Create an Observability project Feature:Drilldowns Embeddable panel Drilldowns release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:Obs AI Assistant Observability AI Assistant v8.15.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.