[Security Solution] DetectionRulesClient: various refactorings#184954
Merged
banderror merged 4 commits intoelastic:mainfrom Jun 7, 2024
Merged
[Security Solution] DetectionRulesClient: various refactorings#184954banderror merged 4 commits intoelastic:mainfrom
DetectionRulesClient: various refactorings#184954banderror merged 4 commits intoelastic:mainfrom
Conversation
17 tasks
Contributor
Author
|
/ci |
d9d33a5 to
63ecace
Compare
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
banderror
approved these changes
Jun 7, 2024
Contributor
banderror
left a comment
There was a problem hiding this comment.
Very nice and straightforward changes @nikitaindik 😉 Let's ship it! 🚢
.../lib/detection_engine/rule_management/logic/detection_rules_client/detection_rules_client.ts
Show resolved
Hide resolved
…ule_management/logic/detection_rules_client/detection_rules_client.ts 🤦 Copy-pasted typo fix Co-authored-by: Georgii Gorbachev <banderror@gmail.com>
rylnd
approved these changes
Jun 7, 2024
Contributor
rylnd
left a comment
There was a problem hiding this comment.
Detection engine changes LGTM!
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @nikitaindik |
eokoneyo
pushed a commit
to eokoneyo/kibana
that referenced
this pull request
Jun 13, 2024
…stic#184954) **Partially addresses: elastic#184364 ## Summary This PR contains various smaller-scale refactorings for the recently added `DetectionsRuleClient`. **Changes**: - Renamed `DetectionRulesClient` containing directory from `rule_management` to `detection_rules_client` - Moved `DetectionRulesClient` methods into the `detection_rules_client/methods` dir - Moved the TS interface of `DetectionRulesClient` into a separate file `detection_rules_client_interface.ts` - Simplified `importRule` method parameters - Added memoization to `getDetectionRulesClient` --------- Co-authored-by: Georgii Gorbachev <banderror@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses: #184364
Summary
This PR contains various smaller-scale refactorings for the recently added
DetectionsRuleClient.Changes:
DetectionRulesClientcontaining directory fromrule_managementtodetection_rules_clientDetectionRulesClientmethods into thedetection_rules_client/methodsdirDetectionRulesClientinto a separate filedetection_rules_client_interface.tsimportRulemethod parametersgetDetectionRulesClient