Skip to content

[Obs AI Assistant] Move alert context from apm to obs api#182243

Merged
sorenlouv merged 6 commits intoelastic:mainfrom
sorenlouv:move-alert-context-from-apm-to-obs-api
May 2, 2024
Merged

[Obs AI Assistant] Move alert context from apm to obs api#182243
sorenlouv merged 6 commits intoelastic:mainfrom
sorenlouv:move-alert-context-from-apm-to-obs-api

Conversation

@sorenlouv
Copy link
Copy Markdown
Contributor

@sorenlouv sorenlouv commented May 1, 2024

Follow-up to #181501

This moves the alert details context used by the AI Assistant from the apm api GET /internal/apm/assistant/get_obs_alert_details_context to the Obs api /internal/observability/assistant/alert_details_contextual_insights.

This also involves adding a type safe API client to the observability API tests

Other changes:

  • Rename synthtraceEsClient to apmSynthtraceEsClient to indicate it is specific to APM

@ghost
Copy link
Copy Markdown

ghost commented May 1, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@sorenlouv sorenlouv force-pushed the move-alert-context-from-apm-to-obs-api branch from d5889a5 to b7eadfa Compare May 1, 2024 12:59
@sorenlouv sorenlouv force-pushed the move-alert-context-from-apm-to-obs-api branch from b7eadfa to b4ab511 Compare May 1, 2024 16:03
@sorenlouv sorenlouv added v8.14.0 release_note:skip Skip the PR/issue when compiling release notes labels May 1, 2024
@sorenlouv
Copy link
Copy Markdown
Contributor Author

buildkite test this

@sorenlouv sorenlouv marked this pull request as ready for review May 1, 2024 22:03
@sorenlouv sorenlouv requested a review from a team as a code owner May 1, 2024 22:03
@sorenlouv sorenlouv requested a review from a team May 1, 2024 22:03
@sorenlouv sorenlouv requested review from a team as code owners May 1, 2024 22:03
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels May 1, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@sorenlouv sorenlouv removed request for a team May 1, 2024 22:10
@sorenlouv sorenlouv force-pushed the move-alert-context-from-apm-to-obs-api branch from 3d98f08 to 98ac418 Compare May 1, 2024 22:12
Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some suggestions

Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM !!

@sorenlouv sorenlouv enabled auto-merge (squash) May 2, 2024 12:47
@sorenlouv sorenlouv removed the request for review from a team May 2, 2024 12:47
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented May 2, 2024

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 669 670 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 285.7KB 285.9KB +208.0B

Canvas Sharable Runtime

The Canvas "shareable runtime" is an bundle produced to enable running Canvas workpads outside of Kibana. This bundle is included in third-party webpages that embed canvas and therefor should be as slim as possible.

id before after diff
module count - 5887 +5887
total size - 6.7MB +6.7MB
Unknown metric groups

API count

id before after diff
observability 678 679 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@sorenlouv sorenlouv deleted the move-alert-context-from-apm-to-obs-api branch May 2, 2024 15:10
sorenlouv added a commit to kibanamachine/kibana that referenced this pull request May 2, 2024
…2243)

Follow-up to elastic#181501

This moves the alert details context used by the AI Assistant from the
apm api `GET /internal/apm/assistant/get_obs_alert_details_context` to
the Obs api
`/internal/observability/assistant/alert_details_contextual_insights`.

This also involves adding a type safe API client to the observability
API tests

### Other changes:

- Rename `synthtraceEsClient` to `apmSynthtraceEsClient` to indicate it
is specific to APM

(cherry picked from commit 0c9a323)
kibanamachine added a commit that referenced this pull request May 2, 2024
…2243) (#182375)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Obs AI Assistant] Move alert context from apm to obs api
(#182243)](#182243)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Søren
Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2024-05-02T14:03:23Z","message":"[Obs
AI Assistant] Move alert context from apm to obs api
(#182243)\n\nFollow-up to
https://github.com/elastic/kibana/pull/181501\r\n\r\nThis moves the
alert details context used by the AI Assistant from the\r\napm api `GET
/internal/apm/assistant/get_obs_alert_details_context` to\r\nthe Obs
api\r\n`/internal/observability/assistant/alert_details_contextual_insights`.\r\n\r\nThis
also involves adding a type safe API client to the observability\r\nAPI
tests\r\n\r\n### Other changes:\r\n\r\n- Rename `synthtraceEsClient` to
`apmSynthtraceEsClient` to indicate it\r\nis specific to
APM","sha":"0c9a323816beedaa32f928312f3cefe8ea66e316","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.14.0","v8.15.0"],"title":"[Obs
AI Assistant] Move alert context from apm to obs
api","number":182243,"url":"https://github.com/elastic/kibana/pull/182243","mergeCommit":{"message":"[Obs
AI Assistant] Move alert context from apm to obs api
(#182243)\n\nFollow-up to
https://github.com/elastic/kibana/pull/181501\r\n\r\nThis moves the
alert details context used by the AI Assistant from the\r\napm api `GET
/internal/apm/assistant/get_obs_alert_details_context` to\r\nthe Obs
api\r\n`/internal/observability/assistant/alert_details_contextual_insights`.\r\n\r\nThis
also involves adding a type safe API client to the observability\r\nAPI
tests\r\n\r\n### Other changes:\r\n\r\n- Rename `synthtraceEsClient` to
`apmSynthtraceEsClient` to indicate it\r\nis specific to
APM","sha":"0c9a323816beedaa32f928312f3cefe8ea66e316"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182243","number":182243,"mergeCommit":{"message":"[Obs
AI Assistant] Move alert context from apm to obs api
(#182243)\n\nFollow-up to
https://github.com/elastic/kibana/pull/181501\r\n\r\nThis moves the
alert details context used by the AI Assistant from the\r\napm api `GET
/internal/apm/assistant/get_obs_alert_details_context` to\r\nthe Obs
api\r\n`/internal/observability/assistant/alert_details_contextual_insights`.\r\n\r\nThis
also involves adding a type safe API client to the observability\r\nAPI
tests\r\n\r\n### Other changes:\r\n\r\n- Rename `synthtraceEsClient` to
`apmSynthtraceEsClient` to indicate it\r\nis specific to
APM","sha":"0c9a323816beedaa32f928312f3cefe8ea66e316"}}]}] BACKPORT-->

Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.14.0 v8.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants