[Obs AI Assistant] Move alert context from apm to obs api#182243
[Obs AI Assistant] Move alert context from apm to obs api#182243sorenlouv merged 6 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
d5889a5 to
b7eadfa
Compare
b7eadfa to
b4ab511
Compare
|
buildkite test this |
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
3d98f08 to
98ac418
Compare
cauemarcondes
left a comment
There was a problem hiding this comment.
LGTM, just some suggestions
x-pack/test/observability_api_integration/trial/tests/obs_alert_details_context.ts
Outdated
Show resolved
Hide resolved
x-pack/test/observability_api_integration/trial/tests/obs_alert_details_context.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Cauê Marcondes <55978943+cauemarcondes@users.noreply.github.com>
x-pack/test/observability_api_integration/trial/tests/obs_alert_details_context.ts
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Async chunks
Canvas Sharable Runtime
History
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…2243) Follow-up to elastic#181501 This moves the alert details context used by the AI Assistant from the apm api `GET /internal/apm/assistant/get_obs_alert_details_context` to the Obs api `/internal/observability/assistant/alert_details_contextual_insights`. This also involves adding a type safe API client to the observability API tests ### Other changes: - Rename `synthtraceEsClient` to `apmSynthtraceEsClient` to indicate it is specific to APM (cherry picked from commit 0c9a323)
…2243) (#182375) # Backport This will backport the following commits from `main` to `8.14`: - [[Obs AI Assistant] Move alert context from apm to obs api (#182243)](#182243) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Søren Louv-Jansen","email":"soren.louv@elastic.co"},"sourceCommit":{"committedDate":"2024-05-02T14:03:23Z","message":"[Obs AI Assistant] Move alert context from apm to obs api (#182243)\n\nFollow-up to https://github.com/elastic/kibana/pull/181501\r\n\r\nThis moves the alert details context used by the AI Assistant from the\r\napm api `GET /internal/apm/assistant/get_obs_alert_details_context` to\r\nthe Obs api\r\n`/internal/observability/assistant/alert_details_contextual_insights`.\r\n\r\nThis also involves adding a type safe API client to the observability\r\nAPI tests\r\n\r\n### Other changes:\r\n\r\n- Rename `synthtraceEsClient` to `apmSynthtraceEsClient` to indicate it\r\nis specific to APM","sha":"0c9a323816beedaa32f928312f3cefe8ea66e316","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","ci:project-deploy-observability","Team:obs-ux-infra_services","Team:obs-ux-management","v8.14.0","v8.15.0"],"title":"[Obs AI Assistant] Move alert context from apm to obs api","number":182243,"url":"https://github.com/elastic/kibana/pull/182243","mergeCommit":{"message":"[Obs AI Assistant] Move alert context from apm to obs api (#182243)\n\nFollow-up to https://github.com/elastic/kibana/pull/181501\r\n\r\nThis moves the alert details context used by the AI Assistant from the\r\napm api `GET /internal/apm/assistant/get_obs_alert_details_context` to\r\nthe Obs api\r\n`/internal/observability/assistant/alert_details_contextual_insights`.\r\n\r\nThis also involves adding a type safe API client to the observability\r\nAPI tests\r\n\r\n### Other changes:\r\n\r\n- Rename `synthtraceEsClient` to `apmSynthtraceEsClient` to indicate it\r\nis specific to APM","sha":"0c9a323816beedaa32f928312f3cefe8ea66e316"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182243","number":182243,"mergeCommit":{"message":"[Obs AI Assistant] Move alert context from apm to obs api (#182243)\n\nFollow-up to https://github.com/elastic/kibana/pull/181501\r\n\r\nThis moves the alert details context used by the AI Assistant from the\r\napm api `GET /internal/apm/assistant/get_obs_alert_details_context` to\r\nthe Obs api\r\n`/internal/observability/assistant/alert_details_contextual_insights`.\r\n\r\nThis also involves adding a type safe API client to the observability\r\nAPI tests\r\n\r\n### Other changes:\r\n\r\n- Rename `synthtraceEsClient` to `apmSynthtraceEsClient` to indicate it\r\nis specific to APM","sha":"0c9a323816beedaa32f928312f3cefe8ea66e316"}}]}] BACKPORT--> Co-authored-by: Søren Louv-Jansen <soren.louv@elastic.co>
Follow-up to #181501
This moves the alert details context used by the AI Assistant from the apm api
GET /internal/apm/assistant/get_obs_alert_details_contextto the Obs api/internal/observability/assistant/alert_details_contextual_insights.This also involves adding a type safe API client to the observability API tests
Other changes:
synthtraceEsClienttoapmSynthtraceEsClientto indicate it is specific to APM