Skip to content

Upgrade EUI to v94.2.1#182023

Merged
cee-chen merged 13 commits intoelastic:mainfrom
cee-chen:eui/v94.2.0
May 3, 2024
Merged

Upgrade EUI to v94.2.1#182023
cee-chen merged 13 commits intoelastic:mainfrom
cee-chen:eui/v94.2.0

Conversation

@cee-chen
Copy link
Copy Markdown
Contributor

@cee-chen cee-chen commented Apr 29, 2024 •
edited
Loading

v94.1.0-backport.0 ⏩ v94.2.1-backport.0

Questions? Please see our Kibana upgrade FAQ.

v94.2.1-backport.0

This is a backport release only intended for use by Kibana.

  • Reverted the EuiFlexGroup/EuiFlexItem component prop feature due to Kibana typing issues

v94.2.1

Bug fixes

  • Fixed an EuiTabbedContent edge case bug that occurred when updated with a completely different set of tabs (#7713)
  • Fixed the @storybook/test dependency to be listed in devDependencies and not dependencies (#7719)

v94.2.0

  • Updated getDefaultEuiMarkdownPlugins() to allow excluding the following plugins in addition to tooltip: (#7676)
    • checkbox
    • linkValidator
    • lineBreaks
    • emoji
  • Updated EuiSelectable's isPreFiltered prop to allow passing a configuration object, which allows disabling search highlighting in addition to search filtering (#7683)
  • Updated EuiFlexGroup and EuiFlexItem prop types to support passing any valid React component type to the component prop and ensure proper type checking of the extra props forwarded to the component. (#7688)
  • Updated EuiSearchBar to allow the @ special character in query string searches (#7702)
  • Added a new, optional optionMatcher prop to EuiSelectable and EuiComboBox allowing passing a custom option matcher function to these components and controlling option filtering for given search string (#7709)

Bug fixes

  • Fixed an EuiPageTemplate bug where prop updates would not cascade down to child sections (#7648)
    • To cascade props down to the sidebar, EuiPageTemplate now explicitly requires using the EuiPageTemplate.Sidebar rather than EuiPageSidebar
  • Fixed EuiFieldNumber's typing to accept an icon configuration shape (#7666)
  • Fixed EuiFieldText and EuiFieldNumber to render the correct paddings for icon shapes set to side: 'right' (#7666)
  • Fixed EuiFieldText and EuiFieldNumber to fully ignore icon/prepend/append when controlOnly is set to true (#7666)
  • Fixed EuiColorPicker's input not setting the correct right padding for the number of icons displayed (#7666)
  • Visual fixes for EuiRanges with showInput: (#7678)
    • Longer append/prepend labels no longer cause a background bug
    • Inputs can no longer overwhelm the actual range in width
  • Fixed a visual text alignment regression in EuiTableRowCells with the row header scope (#7681)
  • Fixed toolTipProps type on EuiSuperUpdateButton to use Partial<EuiToolTipProps> (#7692)
  • Fixes missing prop type for popperProps on EuiDatePicker (#7694)
  • Fixed a focus bug with EuiDataGrids with leadingControlColumns when moving columns to the left/right (#7701) (#7698)
  • Fixed EuiSuperDatePicker to validate date string with respect of locale on EuiAbsoluteTab. (#7705)
  • Fixed a visual bug with EuiSuperDatePicker's absolute tab on small mobile screens (#7708)
  • Fixed i18n of empty and loading state messages for the FieldValueSelectionFilter component (#7718)

Dependency updates

  • Updated @hello-pangea/dnd to v16.6.0 (#7599)
  • Updated remark-rehype to v8.1.0 (#7601)

Accessibility

  • Improved EuiBasicTable and EuiInMemoryTable's selection checkboxes to have unique aria-labels per row (#7672)
  • Added aria-valuetext attributes to EuiRanges with tick labels for improved screen reader UX (#7675)
  • Updated EuiAccordion to keep focus on accordion trigger instead of moving to content on click/keypress (#7696)
  • Added aria-disabled attribute to EuiHorizontalSteps when status is "disabled" (#7699)

@cee-chen cee-chen mentioned this pull request Apr 29, 2024
Merged
2 tasks
@cee-chen cee-chen changed the title Upgrade EUI to v94.2.0 Upgrade EUI to v94.2.1 Apr 29, 2024
@cee-chen
Copy link
Copy Markdown
Contributor Author

cee-chen commented Apr 30, 2024 •
edited
Loading

@tkajtoch Please handle the EuiFlex* and optionMatcher related failures in this PR tomorrow!

@cee-chen cee-chen added release_note:skip Skip the PR/issue when compiling release notes EUI v8.15.0 labels Apr 30, 2024
@sakurai-youhei sakurai-youhei mentioned this pull request Apr 30, 2024
Closed
@tkajtoch
Copy link
Copy Markdown
Member

tkajtoch commented Apr 30, 2024

buildkite test this

@cee-chen cee-chen mentioned this pull request May 1, 2024
Closed
@cee-chen
Copy link
Copy Markdown
Contributor Author

cee-chen commented May 1, 2024

/ci

@cee-chen cee-chen marked this pull request as ready for review May 1, 2024 23:10
@cee-chen cee-chen requested review from a team as code owners May 1, 2024 23:10
@cee-chen cee-chen requested review from a team as code owners May 1, 2024 23:10
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 1, 2024

Pinging @elastic/eui-team (EUI)

ymao1
ymao1 approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response ops changes LGTM

peteharverson
peteharverson approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM

e40pud
e40pud approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@e40pud e40pud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DE changes LGTM

cqliu1
cqliu1 approved these changes May 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@cqliu1 cqliu1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presentation team snapshot updates LGTM 👍

gergoabraham
gergoabraham approved these changes May 3, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elastic/security-defend-workflows related changes look good to me. thanks for the fix there!

@cee-chen cee-chen enabled auto-merge (squash) May 3, 2024 14:50
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented May 3, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 2268 2276 +8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.2MB 3.2MB +1.0B
enterpriseSearch 2.7MB 2.7MB +248.0B
ml 4.1MB 4.1MB +1.0B
securitySolution 13.7MB 13.7MB +18.0B
total +268.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 407.1KB 407.6KB +489.0B
kbnUiSharedDeps-css 254.2KB 253.9KB -223.0B
kbnUiSharedDeps-npmDll 6.3MB 6.3MB +8.5KB
total +8.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cee-chen cee-chen merged commit 31e8c54 into elastic:main May 3, 2024
@cee-chen cee-chen deleted the eui/v94.2.0 branch May 3, 2024 16:27
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label May 3, 2024
@darnautov darnautov mentioned this pull request May 6, 2024
Merged
@cee-chen cee-chen mentioned this pull request May 6, 2024
Merged
cee-chen added a commit that referenced this pull request May 9, 2024
@cee-chen
[Enterprise Search] Fix EuiPageTemplate child usages (#182711)
03a65d2 
👋 Hey y'all ent search folks! I missed this fix/update update in our
latest EUI upgrade (#182023). It's directly related to this change in
EUI v94.2.0:

> - Fixed an `EuiPageTemplate` bug where prop updates would not cascade
down to child sections
([#7648](elastic/eui#7648))
> - To cascade props down to the sidebar, `EuiPageTemplate` now
explicitly requires using the `EuiPageTemplate.Sidebar` rather than
`EuiPageSidebar`

In general, it's also a best practice to use EuiPageTemplate's
namespaced children instead of the direct `EuiPage*` components (which
are meant for direct usage within a`EuiPage` component instead), so I've
made similar changes to your code as well. I would suggest pulling down
this PR to QA that your page still looks as expected/as before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

@cqliu1 cqliu1 cqliu1 approved these changes

@azasypkin azasypkin azasypkin approved these changes

@e40pud e40pud e40pud approved these changes

@jbudz jbudz jbudz approved these changes

@peteharverson peteharverson peteharverson approved these changes

@ymao1 ymao1 ymao1 approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

@gergoabraham gergoabraham gergoabraham approved these changes

@parkiino parkiino Awaiting requested review from parkiino parkiino was automatically assigned from elastic/security-defend-workflows

@nkhristinin nkhristinin Awaiting requested review from nkhristinin nkhristinin was automatically assigned from elastic/security-detection-engine

+1 more reviewer

@sebelga sebelga sebelga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v8.15.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.