[ML] AIOps: Fix text field candidate selection for log rate analysis.#179699
Merged
walterra merged 4 commits intoelastic:mainfrom Mar 29, 2024
Merged
[ML] AIOps: Fix text field candidate selection for log rate analysis.#179699walterra merged 4 commits intoelastic:mainfrom
walterra merged 4 commits intoelastic:mainfrom
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
qn895
approved these changes
Mar 29, 2024
Member
|
Code LGTM 🎉 |
💚 Build Succeeded
Metrics [docs]
To update your PR or re-run it, just comment with: cc @walterra |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Mar 29, 2024
…elastic#179699) (cherry picked from commit a8e2581) # Conflicts: # x-pack/plugins/aiops/server/routes/log_rate_analysis/queries/__mocks__/field_caps_ecommerce.ts # x-pack/plugins/aiops/server/routes/log_rate_analysis/queries/__mocks__/field_caps_large_arrays.ts # x-pack/plugins/aiops/server/routes/log_rate_analysis/queries/__mocks__/field_caps_pgbench.ts # x-pack/plugins/aiops/server/routes/log_rate_analysis/queries/fetch_index_info.ts
walterra
added a commit
that referenced
this pull request
Mar 29, 2024
…alysis. (#179699) (#179719) # Backport This will backport the following commits from `main` to `8.13`: - [[ML] AIOps: Fix text field candidate selection for log rate analysis. (#179699)](#179699) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Walter Rafelsberger","email":"walter.rafelsberger@elastic.co"},"sourceCommit":{"committedDate":"2024-03-29T19:43:36Z","message":"[ML] AIOps: Fix text field candidate selection for log rate analysis. (#179699)","sha":"a8e2581f65cf587f019fbcc863184f2743a4afce","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:fix",":ml","Feature:ML/AIOps","v8.14.0","v8.13.1"],"number":179699,"url":"https://github.com/elastic/kibana/pull/179699","mergeCommit":{"message":"[ML] AIOps: Fix text field candidate selection for log rate analysis. (#179699)","sha":"a8e2581f65cf587f019fbcc863184f2743a4afce"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/179699","number":179699,"mergeCommit":{"message":"[ML] AIOps: Fix text field candidate selection for log rate analysis. (#179699)","sha":"a8e2581f65cf587f019fbcc863184f2743a4afce"}},{"branch":"8.13","label":"v8.13.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
11 tasks
Contributor
|
This PR didn't land on time of the latest BC for v8.13.1. Updating the labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to the investigation in elastic/elasticsearch#106166.
We had code in place that would check if a field was both mapped as
keywordandtextbut it turns out there was a bug so we selected text fields even with a corresponding keyword field present.This PR fixes the problem and adds a jest test that covers it.
Checklist