Skip to content

[Discover] Unskip runtime field tests#179627

Merged
jughosta merged 3 commits intoelastic:mainfrom
jughosta:179297-unskip-runtime-field-test
Mar 31, 2024
Merged

[Discover] Unskip runtime field tests#179627
jughosta merged 3 commits intoelastic:mainfrom
jughosta:179297-unskip-runtime-field-test

Conversation

@jughosta jughosta added release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// backport:prev-minor labels Mar 28, 2024
@jughosta jughosta self-assigned this Mar 28, 2024
@jughosta
Copy link
Copy Markdown
Contributor Author

/ci

@jughosta jughosta marked this pull request as ready for review March 28, 2024 19:19
@jughosta jughosta requested a review from a team as a code owner March 28, 2024 19:19
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Copy link
Copy Markdown
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing these!

@jughosta jughosta enabled auto-merge (squash) March 31, 2024 17:11
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta merged commit cd9a0c2 into elastic:main Mar 31, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.13 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 179627

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 1, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 179627 locally

@jughosta jughosta deleted the 179297-unskip-runtime-field-test branch April 2, 2024 11:43
@jughosta
Copy link
Copy Markdown
Contributor Author

jughosta commented Apr 2, 2024

💚 All backports created successfully

Status Branch Result
8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jughosta added a commit to jughosta/kibana that referenced this pull request Apr 2, 2024
- Closes elastic#179297
- Closes elastic#179310

90x
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5582

(cherry picked from commit cd9a0c2)

# Conflicts:
#	test/functional/apps/discover/group4/_runtime_fields_editor.ts
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

jughosta added a commit that referenced this pull request Apr 2, 2024
# Backport

This will backport the following commits from `main` to `8.13`:
- [[Discover] Unskip runtime field tests
(#179627)](#179627)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Rechkunova","email":"julia.rechkunova@elastic.co"},"sourceCommit":{"committedDate":"2024-03-31T18:22:32Z","message":"[Discover]
Unskip runtime field tests (#179627)\n\n- Closes
https://github.com/elastic/kibana/issues/179297\r\n- Closes
https://github.com/elastic/kibana/issues/179310\r\n\r\n90x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5582","sha":"cd9a0c294d34052df3659882d33fd6dd480788d0","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport
missing","Team:DataDiscovery","backport:prev-minor","v8.14.0"],"number":179627,"url":"https://github.com/elastic/kibana/pull/179627","mergeCommit":{"message":"[Discover]
Unskip runtime field tests (#179627)\n\n- Closes
https://github.com/elastic/kibana/issues/179297\r\n- Closes
https://github.com/elastic/kibana/issues/179310\r\n\r\n90x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5582","sha":"cd9a0c294d34052df3659882d33fd6dd480788d0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","labelRegex":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/179627","number":179627,"mergeCommit":{"message":"[Discover]
Unskip runtime field tests (#179627)\n\n- Closes
https://github.com/elastic/kibana/issues/179297\r\n- Closes
https://github.com/elastic/kibana/issues/179310\r\n\r\n90x\r\nhttps://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5582","sha":"cd9a0c294d34052df3659882d33fd6dd480788d0"}}]}]
BACKPORT-->
@kibanamachine kibanamachine added v8.13.2 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v8.13.2 v8.14.0

Projects

None yet

5 participants