[Ent Search] Fix connector client UI copy#179579
Merged
leemthompo merged 12 commits intoelastic:mainfrom Apr 2, 2024
Merged
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
efegurkan
reviewed
Mar 28, 2024
...plications/enterprise_search_content/components/connector_detail/connector_configuration.tsx
Outdated
Show resolved
Hide resolved
…ibana into delete-useless-copy
leemthompo
commented
Mar 28, 2024
...plications/enterprise_search_content/components/connector_detail/connector_configuration.tsx
Show resolved
Hide resolved
florent-leborgne
approved these changes
Mar 29, 2024
chriscressman
approved these changes
Apr 1, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @leemthompo |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 2, 2024
Fixes broken copy instructions and updates links (cherry picked from commit a381966)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Apr 2, 2024
# Backport This will backport the following commits from `main` to `8.13`: - [[Ent Search] Fix connector client UI copy (#179579)](#179579) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Liam Thompson","email":"32779855+leemthompo@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-04-02T09:12:33Z","message":"[Ent Search] Fix connector client UI copy (#179579)\n\nFixes broken copy instructions and updates links","sha":"a38196699eddc283b41d259c64c70b0162736ab3","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.14.0","v8.13.1"],"title":"[Ent Search] Fix connector client UI copy","number":179579,"url":"https://github.com/elastic/kibana/pull/179579","mergeCommit":{"message":"[Ent Search] Fix connector client UI copy (#179579)\n\nFixes broken copy instructions and updates links","sha":"a38196699eddc283b41d259c64c70b0162736ab3"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"main","label":"v8.14.0","branchLabelMappingKey":"^v8.14.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/179579","number":179579,"mergeCommit":{"message":"[Ent Search] Fix connector client UI copy (#179579)\n\nFixes broken copy instructions and updates links","sha":"a38196699eddc283b41d259c64c70b0162736ab3"}},{"branch":"8.13","label":"v8.13.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Contributor
|
This PR didn't land on time of the latest BC for v8.13.1. Updating the labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes broken copy instructions and updates links