[Security Solution][Endpoint][Admin][Trusted Apps] Fix warning for fields that do not support matches that use wildcards#178688
Merged
parkiino merged 12 commits intoelastic:mainfrom Apr 1, 2024
Conversation
bb95ec9 to
48d4896
Compare
…ldcard-warning-with-field-supports-matches-only
…atches-only' of github.com:parkiino/kibana into bug/trusted-apps-wildcard-warning-with-field-supports-matches-only
…ldcard-warning-with-field-supports-matches-only
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
gergoabraham
approved these changes
Mar 20, 2024
Contributor
gergoabraham
left a comment
There was a problem hiding this comment.
looks and works great! 🚢
…ldcard-warning-with-field-supports-matches-only
…ldcard-warning-with-field-supports-matches-only
…-supports-matches-only
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
that referenced
this pull request
Apr 1, 2024
…elds that do not support matches that use wildcards (#178688) ## Summary - [x] Fixes a bug where the Trusted Apps `Hash` and `Signature` field show a warning message telling the user to switch to the `matches` operator if they use a wildcard (* or ?) in the value. These two fields do not support `matches` so we are instead showing a different warning message notifying them of this. - [x] Unit Tests NOTE: will be merged after v8.13.0 release # Screenshots   (cherry picked from commit b5c9db9)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kibanamachine
added a commit
that referenced
this pull request
Apr 1, 2024
… for fields that do not support matches that use wildcards (#178688) (#179777) # Backport This will backport the following commits from `main` to `8.13`: - [[Security Solution][Endpoint][Admin][Trusted Apps] Fix warning for fields that do not support matches that use wildcards (#178688)](#178688) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Candace Park","email":"56409205+parkiino@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-04-01T22:07:44Z","message":"[Security Solution][Endpoint][Admin][Trusted Apps] Fix warning for fields that do not support matches that use wildcards (#178688)\n\n## Summary\r\n\r\n- [x] Fixes a bug where the Trusted Apps `Hash` and `Signature` field\r\nshow a warning message telling the user to switch to the `matches`\r\noperator if they use a wildcard (* or ?) in the value. These two fields\r\ndo not support `matches` so we are instead showing a different warning\r\nmessage notifying them of this.\r\n- [x] Unit Tests\r\n\r\nNOTE: will be merged after v8.13.0 release\r\n\r\n# Screenshots\r\n\r\n\r\n\r\n","sha":"b5c9db91101ab2915177cfc9710c7db0756ceef6","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend Workflows","auto-backport","v8.13.1"],"number":178688,"url":"https://github.com/elastic/kibana/pull/178688","mergeCommit":{"message":"[Security Solution][Endpoint][Admin][Trusted Apps] Fix warning for fields that do not support matches that use wildcards (#178688)\n\n## Summary\r\n\r\n- [x] Fixes a bug where the Trusted Apps `Hash` and `Signature` field\r\nshow a warning message telling the user to switch to the `matches`\r\noperator if they use a wildcard (* or ?) in the value. These two fields\r\ndo not support `matches` so we are instead showing a different warning\r\nmessage notifying them of this.\r\n- [x] Unit Tests\r\n\r\nNOTE: will be merged after v8.13.0 release\r\n\r\n# Screenshots\r\n\r\n\r\n\r\n","sha":"b5c9db91101ab2915177cfc9710c7db0756ceef6"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com>
Contributor
|
This PR didn't land on time of the latest BC for v8.13.1. Updating the labels. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HashandSignaturefield show a warning message telling the user to switch to thematchesoperator if they use a wildcard (* or ?) in the value. These two fields do not supportmatchesso we are instead showing a different warning message notifying them of this.NOTE: will be merged after v8.13.0 release
Screenshots