Skip to content

[Security Solution][Endpoint][Admin][Trusted Apps] Fix warning for fields that do not support matches that use wildcards#178688

Merged
parkiino merged 12 commits intoelastic:mainfrom
parkiino:bug/trusted-apps-wildcard-warning-with-field-supports-matches-only
Apr 1, 2024
Merged

[Security Solution][Endpoint][Admin][Trusted Apps] Fix warning for fields that do not support matches that use wildcards#178688
parkiino merged 12 commits intoelastic:mainfrom
parkiino:bug/trusted-apps-wildcard-warning-with-field-supports-matches-only

Conversation

@parkiino
Copy link
Copy Markdown
Contributor

@parkiino parkiino commented Mar 14, 2024

Summary

  • Fixes a bug where the Trusted Apps Hash and Signature field show a warning message telling the user to switch to the matches operator if they use a wildcard (* or ?) in the value. These two fields do not support matches so we are instead showing a different warning message notifying them of this.
  • Unit Tests

NOTE: will be merged after v8.13.0 release

Screenshots

image
image

@parkiino parkiino force-pushed the bug/trusted-apps-wildcard-warning-with-field-supports-matches-only branch from bb95ec9 to 48d4896 Compare March 14, 2024 05:19
…ldcard-warning-with-field-supports-matches-only
@parkiino parkiino added Team:Defend Workflows “EDR Workflows” sub-team of Security Solution auto-backport Deprecated - use backport:version if exact versions are needed v8.13.0 v8.13.1 labels Mar 20, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@parkiino parkiino added release_note:skip Skip the PR/issue when compiling release notes and removed v8.13.0 labels Mar 20, 2024
Copy link
Copy Markdown
Contributor

@gergoabraham gergoabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks and works great! 🚢

@parkiino parkiino enabled auto-merge (squash) March 29, 2024 21:27
@parkiino parkiino merged commit b5c9db9 into elastic:main Apr 1, 2024
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 16.6MB 16.6MB +301.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine pushed a commit that referenced this pull request Apr 1, 2024
…elds that do not support matches that use wildcards (#178688)

## Summary

- [x] Fixes a bug where the Trusted Apps `Hash` and `Signature` field
show a warning message telling the user to switch to the `matches`
operator if they use a wildcard (* or ?) in the value. These two fields
do not support `matches` so we are instead showing a different warning
message notifying them of this.
- [x] Unit Tests

NOTE: will be merged after v8.13.0 release

# Screenshots

![image](https://github.com/elastic/kibana/assets/56409205/6698b9b8-a465-4419-bcc8-f57d688e365d)

![image](https://github.com/elastic/kibana/assets/56409205/be40b4a9-791f-417d-ad59-6929c6ea9eb2)

(cherry picked from commit b5c9db9)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.13

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

kibanamachine added a commit that referenced this pull request Apr 1, 2024
… for fields that do not support matches that use wildcards (#178688) (#179777)

# Backport

This will backport the following commits from `main` to `8.13`:
- [[Security Solution][Endpoint][Admin][Trusted Apps] Fix warning for
fields that do not support matches that use wildcards
(#178688)](#178688)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Candace
Park","email":"56409205+parkiino@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-04-01T22:07:44Z","message":"[Security
Solution][Endpoint][Admin][Trusted Apps] Fix warning for fields that do
not support matches that use wildcards (#178688)\n\n## Summary\r\n\r\n-
[x] Fixes a bug where the Trusted Apps `Hash` and `Signature`
field\r\nshow a warning message telling the user to switch to the
`matches`\r\noperator if they use a wildcard (* or ?) in the value.
These two fields\r\ndo not support `matches` so we are instead showing a
different warning\r\nmessage notifying them of this.\r\n- [x] Unit
Tests\r\n\r\nNOTE: will be merged after v8.13.0 release\r\n\r\n#
Screenshots\r\n\r\n![image](https://github.com/elastic/kibana/assets/56409205/6698b9b8-a465-4419-bcc8-f57d688e365d)\r\n\r\n![image](https://github.com/elastic/kibana/assets/56409205/be40b4a9-791f-417d-ad59-6929c6ea9eb2)","sha":"b5c9db91101ab2915177cfc9710c7db0756ceef6","branchLabelMapping":{"^v8.14.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Defend
Workflows","auto-backport","v8.13.1"],"number":178688,"url":"https://github.com/elastic/kibana/pull/178688","mergeCommit":{"message":"[Security
Solution][Endpoint][Admin][Trusted Apps] Fix warning for fields that do
not support matches that use wildcards (#178688)\n\n## Summary\r\n\r\n-
[x] Fixes a bug where the Trusted Apps `Hash` and `Signature`
field\r\nshow a warning message telling the user to switch to the
`matches`\r\noperator if they use a wildcard (* or ?) in the value.
These two fields\r\ndo not support `matches` so we are instead showing a
different warning\r\nmessage notifying them of this.\r\n- [x] Unit
Tests\r\n\r\nNOTE: will be merged after v8.13.0 release\r\n\r\n#
Screenshots\r\n\r\n![image](https://github.com/elastic/kibana/assets/56409205/6698b9b8-a465-4419-bcc8-f57d688e365d)\r\n\r\n![image](https://github.com/elastic/kibana/assets/56409205/be40b4a9-791f-417d-ad59-6929c6ea9eb2)","sha":"b5c9db91101ab2915177cfc9710c7db0756ceef6"}},"sourceBranch":"main","suggestedTargetBranches":["8.13"],"targetPullRequestStates":[{"branch":"8.13","label":"v8.13.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com>
@parkiino parkiino deleted the bug/trusted-apps-wildcard-warning-with-field-supports-matches-only branch April 2, 2024 03:55
@mistic
Copy link
Copy Markdown
Contributor

mistic commented Apr 2, 2024

This PR didn't land on time of the latest BC for v8.13.1. Updating the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution v8.13.2 v8.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants