Skip to content

[Actions] Support of system actions feature privilege in the sub-action framework#178600

Merged
cnasikas merged 3 commits intoelastic:mainfrom
cnasikas:enable_system_actions_saf
Mar 13, 2024
Merged

[Actions] Support of system actions feature privilege in the sub-action framework#178600
cnasikas merged 3 commits intoelastic:mainfrom
cnasikas:enable_system_actions_saf

Conversation

@cnasikas
Copy link
Copy Markdown
Member

Summary

This PR adds support for setting the required feature privileges for system actions in the sub-action framework

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cnasikas cnasikas added release_note:skip Skip the PR/issue when compiling release notes Feature:Actions Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.14.0 labels Mar 13, 2024
@cnasikas cnasikas self-assigned this Mar 13, 2024
@cnasikas cnasikas requested a review from a team as a code owner March 13, 2024 08:55
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@cnasikas
Copy link
Copy Markdown
Member Author

/ci

@cnasikas cnasikas mentioned this pull request Mar 13, 2024
3 tasks
@cnasikas
Copy link
Copy Markdown
Member Author

@elasticmachine merge upstream

@cnasikas cnasikas enabled auto-merge (squash) March 13, 2024 09:07
@cnasikas
Copy link
Copy Markdown
Member Author

/ci

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

The CI Stats report is too large to be displayed here, check out the CI build annotation for this information.

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

@cnasikas cnasikas merged commit 6834702 into elastic:main Mar 13, 2024
@cnasikas cnasikas deleted the enable_system_actions_saf branch March 13, 2024 14:27
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Mar 13, 2024
cnasikas added a commit that referenced this pull request Apr 12, 2024
## Summary

Depends on: #166267,
#170326,
#169484,
#173740,
#173763,
#178068,
#178307,
#178600,
#180437

PRs:
- #168370
- #169229
- #171754
- #172709
- #173012
- #175107
- #175452
- #175505
- #177033
- #178277
- #177139
- #179796

Fixes: #153837

## Testing

Run Kibana with `--run-examples` if you want to use the "Always firing"
rule.

Create a rule with a case action in observability and the stack. The
security solution is not supported. You should not be able to assign a
case action in a security solution rule.

1. Test the "Reopen closed cases" configuration.
2. Test the "Grouping by" configuration. Only one field is allowed. Not
all fields are persisted in alerts. If you select a field not part of
the alert the case action will create a case where the grouping value is
set to `unknow`.
3. Test the "Time window" feature. You can comment out the validation to
test for shorter times.
4. Verify that the case action is experimental.
5. Verify that based on the rule type the case is created in the correct
solution.
6. Verify that you cannot create a rule with the case action on the
basic license.
7. Verify that the execution of the case action fails if you do not have
permission for cases. Pending work on the system actions framework level
to not allow users to create rules with system actions where they do not
have permission.
8. Stress test the case action by creating multiple rules.

### Checklist

Delete any items that are not applicable to this PR.

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

### For maintainers

- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

## Release notes

Automatically create cases when an alert is triggered.

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: adcoelho <antonio.coelho@elastic.co>
Co-authored-by: Janki Salvi <117571355+js-jankisalvi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:Actions release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.14.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants