[Status] Organize metrics stuff into metrics_collector, tests into __test__ directories, remove mock-fs for the cgroup test#17788
Merged
tsullivan merged 8 commits intoelastic:masterfrom Apr 25, 2018
Conversation
Contributor
💚 Build Succeeded |
tsullivan
commented
Apr 19, 2018
| readCPUAcctUsage(cpuAcctPath).catch(rejectUnlessFileNotFound), | ||
| readCPUFsPeriod(cpuPath).catch(rejectUnlessFileNotFound), | ||
| readCPUFsQuota(cpuPath).catch(rejectUnlessFileNotFound), | ||
| readCPUStat(cpuPath).catch(rejectUnlessFileNotFound) |
Member
Author
There was a problem hiding this comment.
@tylersmalley I could use advice here - can we chat about this?
Without these changes, I was getting unhandled rejection warnings. They weren't causing the tests to fail, but they were pretty messy. Not sure what I've changed that makes the warnings quiet down after putting the catches up here.
Member
Author
There was a problem hiding this comment.
I just went ahead and undid this because I don't want to hack the code to get it to not complain about my mock module.
I still would really like to understand why the unhandled rejections are happening. This code is exactly like https://runkit.com/miu/5ad8d36c36503a0012574310
Contributor
💚 Build Succeeded |
Member
Author
|
Currently there are unhandled exception thrown in Appreciate any advice here, or LMK if this can be ignored. |
Contributor
💔 Build Failed |
Member
Author
jenkins test this |
Contributor
💚 Build Succeeded |
tylersmalley
approved these changes
Apr 23, 2018
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Apr 25, 2018
…_test__ directories, remove mock-fs for the cgroup test (elastic#17788) * [Status] Organize tests into __test__ directories * custom mock for fs in cgroups test * work around unhandled rejection errors * simplify fserror construct * put fs readFile mockImpl in beforeAll for pretty * undo hacking the code to suppress unhandled promise rejections * test files back to sibling of the module
tsullivan
added a commit
that referenced
this pull request
Apr 30, 2018
…_test__ directories, remove mock-fs for the cgroup test (#17788) (#18578) * [Status] Organize tests into __test__ directories * custom mock for fs in cgroups test * work around unhandled rejection errors * simplify fserror construct * put fs readFile mockImpl in beforeAll for pretty * undo hacking the code to suppress unhandled promise rejections * test files back to sibling of the module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a standalone PR to make #17773 more of an atomic PR.
Replacing
mock-fswith a custom inline Jest mock is necessary because the next PR will mockos, and that was causing conflicts withmock-fs.