Skip to content

[DOCS] Adds new installation package details#17781

Merged
lcawl merged 6 commits intoelastic:masterfrom
lcawl:lcawley-install
Apr 25, 2018
Merged

[DOCS] Adds new installation package details#17781
lcawl merged 6 commits intoelastic:masterfrom
lcawl:lcawley-install

Conversation

@lcawl
Copy link
Copy Markdown
Contributor

@lcawl lcawl commented Apr 18, 2018

This PR updates the Kibana User Guide with respect to changes in the installation packages.

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

Copy link
Copy Markdown
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without more context, this statement kind of gives the impression that you must pay for a license to use the default image, but that's not the case. The term "commercial" is appropriate, but in the vast majority of situations that term refers to things that cost money, and that's not the case here.

Perhaps we can use this opportunity to elaborate about how the images come baked in with all of our free features by default, including apache2 licensed features and elastic licensed features. Folks can also choose to opt-in to a 30 day free trial of our platinum features as well.

Then alternatively folks can get oss-only images.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we phrase this more like "open source only distribution" rather than simply "open source distribution"?

@lcawl
Copy link
Copy Markdown
Contributor Author

lcawl commented Apr 19, 2018

Thanks for the feedback! I've updated the text based on suggestions here and in elastic/elasticsearch#29590

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really accurate. The distributions as a whole are offered under the apache2 license, but the code within them is licensed under many different apache2-compatible licenses, like MIT, BSD, etc. I think a simple fix here is referring to the license of the distribution itself rather than the code within it, since that's the important detail for the sake of installation. Perhaps:

Alternatively, you can download the following package, which contains only features that are available under the Apache 2.0 license.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I totally thought I added this comment before, but apparently not:

nit: Perhaps "and access to paid commercial features" would be more clear?

@lcawl
Copy link
Copy Markdown
Contributor Author

lcawl commented Apr 21, 2018

Thanks @epixa! I've implemented those changes in elastic/elasticsearch#29590 and elastic/logstash#9404 too.

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@epixa
Copy link
Copy Markdown
Contributor

epixa commented Apr 23, 2018

That'll work!

@epixa
Copy link
Copy Markdown
Contributor

epixa commented Apr 23, 2018

Err, LGTM

@lcawl lcawl force-pushed the lcawley-install branch from 5ad2536 to d72d53a Compare April 25, 2018 05:23
@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@lcawl lcawl merged commit ce039a4 into elastic:master Apr 25, 2018
@lcawl lcawl deleted the lcawley-install branch April 25, 2018 06:14
@lcawl lcawl added the v6.4.0 label Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants