Skip to content

Revert "set tooltip width so div is centered around triggering elemen…#17580

Merged
w33ble merged 1 commit intoelastic:masterfrom
w33ble:fix/tooltip-class
Apr 11, 2018
Merged

Revert "set tooltip width so div is centered around triggering elemen…#17580
w33ble merged 1 commit intoelastic:masterfrom
w33ble:fix/tooltip-class

Conversation

@w33ble
Copy link
Copy Markdown
Contributor

@w33ble w33ble commented Apr 5, 2018

Closes #17557

This reverts commit c06b445, effectively undoing #15542.

This seems safe since 6.2+ uses EUI now.

@w33ble w33ble added review Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v7.0.0 v6.3.0 v6.2.4 labels Apr 5, 2018
@w33ble w33ble requested review from cjcenizal and nreese April 5, 2018 16:35
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 5, 2018

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 5, 2018

💚 Build Succeeded

nreese
nreese approved these changes Apr 7, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@w33ble
Copy link
Copy Markdown
Contributor Author

w33ble commented Apr 10, 2018

@cjcenizal I'd like to get this in this week. If you're swamped, let me know and I can try to find someone else to review.

@cjcenizal
Copy link
Copy Markdown
Contributor

cjcenizal commented Apr 10, 2018

@w33ble Sorry! Didn't realize this was waiting on me. Yes, I won't be able to review this. Removing myself as reviewer.

@cjcenizal cjcenizal removed their request for review April 10, 2018 16:48
@w33ble w33ble requested a review from stacey-gammon April 10, 2018 17:27
stacey-gammon
stacey-gammon approved these changes Apr 11, 2018
View reviewed changes
Copy link
Copy Markdown

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Monitoring is using PuiTooltip but I suppose that won't be affected by this? Unless they were somehow inheriting this style?

@tsullivan
Copy link
Copy Markdown
Member

tsullivan commented Apr 11, 2018

Monitoring is using PuiTooltip but I suppose that won't be affected by this? Unless they were somehow inheriting this style?

Things are looking ok in Monitoring with this change. We have a lot of style overrides for the tooltips on our side.

This seems safe since 6.2+ uses EUI now.

Woah, I didn't realize EUI has tooltip now. 👍

@w33ble
Copy link
Copy Markdown
Contributor Author

w33ble commented Apr 11, 2018

Thanks for chiming in @tsullivan, now I don't have to go digging. 🏆

@w33ble w33ble merged commit eb22e37 into elastic:master Apr 11, 2018
w33ble added a commit that referenced this pull request Apr 11, 2018
@w33ble
Revert "set tooltip width so div is centered around triggering element (
0ffb385 
#15542)" (#17580)

This reverts commit c06b445.
w33ble added a commit that referenced this pull request Apr 11, 2018
@w33ble
Revert "set tooltip width so div is centered around triggering element (
ee501cf 
#15542)" (#17580)

This reverts commit c06b445.
@w33ble
Copy link
Copy Markdown
Contributor Author

w33ble commented Apr 11, 2018

6.x/6.3.0: 0ffb385
6.2/6.2.4: ee501cf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nreese nreese nreese approved these changes

+1 more reviewer

@stacey-gammon stacey-gammon stacey-gammon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

review Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v6.2.4 v6.3.0 v7.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@w33ble @elasticmachine @cjcenizal @tsullivan @nreese @stacey-gammon