Skip to content

[ES|QL] Add st_centroid agg function#175506

Merged
dej611 merged 7 commits intoelastic:mainfrom
dej611:fix/std_centroid
Jan 29, 2024
Merged

[ES|QL] Add st_centroid agg function#175506
dej611 merged 7 commits intoelastic:mainfrom
dej611:fix/std_centroid

Conversation

@dej611
Copy link
Copy Markdown
Contributor

@dej611 dej611 commented Jan 25, 2024

Summary

Adds new agg function as in elastic/elasticsearch#104218

Checklist

@dej611 dej611 added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes Feature:ES|QL ES|QL related features in Kibana v8.13.0 labels Jan 25, 2024
@dej611
Copy link
Copy Markdown
Contributor Author

dej611 commented Jan 25, 2024

/ci

@dej611 dej611 marked this pull request as ready for review January 25, 2024 15:20
@dej611 dej611 requested a review from a team as a code owner January 25, 2024 15:20
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@dej611
Copy link
Copy Markdown
Contributor Author

dej611 commented Jan 25, 2024

/ci

Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only

@dej611
Copy link
Copy Markdown
Contributor Author

dej611 commented Jan 25, 2024

Self five

@dej611 dej611 enabled auto-merge (squash) January 25, 2024 16:57
@dej611
Copy link
Copy Markdown
Contributor Author

dej611 commented Jan 29, 2024

The validation logic had one issue after the STATS support of nested functions merge, so it had to be adjusted.
Also the testing framework didn't support new types (cartesian_point and geo_point) so now the logic has been updated to support them.

@dej611
Copy link
Copy Markdown
Contributor Author

dej611 commented Jan 29, 2024

/ci

@dej611 dej611 merged commit 877c562 into elastic:main Jan 29, 2024
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 2.9MB 2.9MB +608.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Jan 29, 2024
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this pull request Feb 15, 2024
## Summary

Adds new agg function as in
elastic/elasticsearch#104218


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
fkanout pushed a commit to fkanout/kibana that referenced this pull request Mar 4, 2024
## Summary

Adds new agg function as in
elastic/elasticsearch#104218


### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.13.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants