[ES|QL] Add support for STATS BY nested function#175288
Merged
dej611 merged 12 commits intoelastic:mainfrom Jan 24, 2024
Merged
[ES|QL] Add support for STATS BY nested function#175288dej611 merged 12 commits intoelastic:mainfrom
dej611 merged 12 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
Contributor
|
@elasticmachine merge upstream |
Contributor
|
/ci |
Contributor
|
@dej611 as this is a very cool feature, can we suggest also all the eval functions (as they are supported). 
|
Contributor
Author
|
I wasn't sure whether to suggest them or not, but I can enable that.
Does it make sense to you @stratoula ? |
Contributor
|
Yes!!! I think is cool to suggest them even if the list goes long! |
Contributor
Author
|
/ci |
Contributor
Author
|
Updated logic to propose also functions.
|
stratoula
approved these changes
Jan 24, 2024
Contributor
stratoula
left a comment
There was a problem hiding this comment.
This looks great Marco! LGTM, thanx a ton
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
Contributor
Author
|
I've completely missed the support for nested functions in the |
1 task
dej611
added a commit
that referenced
this pull request
Jan 29, 2024
## Summary This is the second part of #175288 where nested expressions are supported in STATS scope as well. I've tweaked the previous test suite here to check all agg functions with nested expressions in various scenarios. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary Add support for the validation and autocomplete engine for the feature introduced in elastic/elasticsearch#104387 The validation engine should not mark the syntax as invalid now. The autocomplete changes are a little bit more subtle: * after the `by` option command a `varX` and functions are now suggested in additions to `[columns]` * when typing an expression within the `by` scope the autocomplete should now understand and help with that, without promoting it when not needed.  ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
## Summary This is the second part of elastic#175288 where nested expressions are supported in STATS scope as well. I've tweaked the previous test suite here to check all agg functions with nested expressions in various scenarios. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
## Summary This is the second part of elastic#175288 where nested expressions are supported in STATS scope as well. I've tweaked the previous test suite here to check all agg functions with nested expressions in various scenarios. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for the validation and autocomplete engine for the feature introduced in elastic/elasticsearch#104387
The validation engine should not mark the syntax as invalid now.
The autocomplete changes are a little bit more subtle:
byoption command avarXand functions are now suggested in additions to[columns]byscope the autocomplete should now understand and help with that, without promoting it when not needed.Checklist