[Lens] Prevent overwriting managed content from editor by drewdaemon · Pull Request #175062 · elastic/kibana

drewdaemon · 2024-01-17T18:42:29Z

Summary

I marked this a breaking change since it is preventing users from doing something they have been able to do before. They can no longer save changes to managed Lens visualizations. Instead, they have to save changes to a new visualization.

To test, import this ndjson file which includes both a managed and an unmanaged visualization:

Details

{"attributes":{"allowHidden":false,"fieldAttrs":"{}","fieldFormatMap":"{\"hour_of_day\":{}}","fields":"[]","name":"Kibana Sample Data Logs","runtimeFieldMap":"{\"hour_of_day\":{\"type\":\"long\",\"script\":{\"source\":\"emit(doc['timestamp'].value.getHour());\"}}}","sourceFilters":"[]","timeFieldName":"timestamp","title":"kibana_sample_data_logs"},"coreMigrationVersion":"8.8.0","created_at":"2024-01-22T15:27:04.601Z","id":"90943e30-9a47-11e8-b64d-95841ca0b247","managed":false,"references":[],"type":"index-pattern","typeMigrationVersion":"8.0.0","updated_at":"2024-01-22T18:34:19.022Z","version":"WzI1MiwxXQ=="}
{"attributes":{"description":"","state":{"adHocDataViews":{},"datasourceStates":{"formBased":{"layers":{"e633b1af-3ab4-4bf5-8faa-fefde06c4a4a":{"columnOrder":["2c32f558-7549-44a5-9954-0578aa19642a","d229daf9-9658-4579-99af-01d8adb2f25f"],"columns":{"2c32f558-7549-44a5-9954-0578aa19642a":{"dataType":"date","isBucketed":true,"label":"timestamp","operationType":"date_histogram","params":{"dropPartials":false,"includeEmptyRows":true,"interval":"auto"},"scale":"interval","sourceField":"timestamp"},"d229daf9-9658-4579-99af-01d8adb2f25f":{"dataType":"number","isBucketed":false,"label":"Median of bytes","operationType":"median","params":{"emptyAsNull":true},"scale":"ratio","sourceField":"bytes"}},"incompleteColumns":{},"sampling":1}}},"indexpattern":{"layers":{}},"textBased":{"layers":{}}},"filters":[],"internalReferences":[],"query":{"language":"kuery","query":""},"visualization":{"axisTitlesVisibilitySettings":{"x":true,"yLeft":true,"yRight":true},"fittingFunction":"None","gridlinesVisibilitySettings":{"x":true,"yLeft":true,"yRight":true},"labelsOrientation":{"x":0,"yLeft":0,"yRight":0},"layers":[{"accessors":["d229daf9-9658-4579-99af-01d8adb2f25f"],"layerId":"e633b1af-3ab4-4bf5-8faa-fefde06c4a4a","layerType":"data","position":"top","seriesType":"bar_stacked","showGridlines":false,"xAccessor":"2c32f558-7549-44a5-9954-0578aa19642a"}],"legend":{"isVisible":true,"position":"right"},"preferredSeriesType":"bar_stacked","tickLabelsVisibilitySettings":{"x":true,"yLeft":true,"yRight":true},"valueLabels":"hide"}},"title":"Lens vis (managed)","visualizationType":"lnsXY"},"coreMigrationVersion":"8.8.0","created_at":"2024-01-17T18:36:58.721Z","id":"abc16953-36db-4a3b-a4ba-7a64ab8f130c","managed":true,"references":[{"id":"90943e30-9a47-11e8-b64d-95841ca0b247","name":"indexpattern-datasource-layer-e633b1af-3ab4-4bf5-8faa-fefde06c4a4a","type":"index-pattern"}],"type":"lens","typeMigrationVersion":"8.9.0","updated_at":"2024-01-17T18:36:58.721Z","version":"Wzk0LDFd"}
{"attributes":{"description":"","state":{"adHocDataViews":{},"datasourceStates":{"formBased":{"layers":{"e633b1af-3ab4-4bf5-8faa-fefde06c4a4a":{"columnOrder":["2c32f558-7549-44a5-9954-0578aa19642a","d229daf9-9658-4579-99af-01d8adb2f25f"],"columns":{"2c32f558-7549-44a5-9954-0578aa19642a":{"dataType":"date","isBucketed":true,"label":"timestamp","operationType":"date_histogram","params":{"dropPartials":false,"includeEmptyRows":true,"interval":"auto"},"scale":"interval","sourceField":"timestamp"},"d229daf9-9658-4579-99af-01d8adb2f25f":{"dataType":"number","isBucketed":false,"label":"Median of bytes","operationType":"median","params":{"emptyAsNull":true},"scale":"ratio","sourceField":"bytes"}},"incompleteColumns":{},"sampling":1}}},"indexpattern":{"layers":{}},"textBased":{"layers":{}}},"filters":[],"internalReferences":[],"query":{"language":"kuery","query":""},"visualization":{"axisTitlesVisibilitySettings":{"x":true,"yLeft":true,"yRight":true},"fittingFunction":"None","gridlinesVisibilitySettings":{"x":true,"yLeft":true,"yRight":true},"labelsOrientation":{"x":0,"yLeft":0,"yRight":0},"layers":[{"accessors":["d229daf9-9658-4579-99af-01d8adb2f25f"],"layerId":"e633b1af-3ab4-4bf5-8faa-fefde06c4a4a","layerType":"data","position":"top","seriesType":"bar_stacked","showGridlines":false,"xAccessor":"2c32f558-7549-44a5-9954-0578aa19642a"}],"legend":{"isVisible":true,"position":"right"},"preferredSeriesType":"bar_stacked","tickLabelsVisibilitySettings":{"x":true,"yLeft":true,"yRight":true},"valueLabels":"hide"}},"title":"Lens vis (unmanaged)","visualizationType":"lnsXY"},"coreMigrationVersion":"8.8.0","created_at":"2024-01-17T18:34:06.341Z","id":"49616953-36db-4a3b-a4ba-7a64ab8f130b","managed":false,"references":[{"id":"90943e30-9a47-11e8-b64d-95841ca0b247","name":"indexpattern-datasource-layer-e633b1af-3ab4-4bf5-8faa-fefde06c4a4a","type":"index-pattern"}],"type":"lens","typeMigrationVersion":"8.9.0","updated_at":"2024-01-17T18:34:06.341Z","version":"Wzg5LDFd"}
{"excludedObjects":[],"excludedObjectsCount":0,"exportedCount":3,"missingRefCount":0,"missingReferences":[]}

This is how the UI should look for the managed visualization.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials — going to happen in [Docs] Add documentation for managed content #175150
Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed — https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/4922
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)

drewdaemon · 2024-01-18T18:40:48Z

/ci

…fix'

…kibana into lens-respect-managed-content

drewdaemon · 2024-01-18T19:03:38Z

/ci

…fix'

drewdaemon · 2024-01-18T19:45:00Z

@elasticmachine merge upstream

drewdaemon · 2024-01-18T19:45:08Z

/ci

drewdaemon · 2024-01-18T20:30:39Z

@elasticmachine merge upstream

drewdaemon · 2024-01-18T20:30:45Z

/ci

drewdaemon · 2024-01-18T21:28:37Z

/ci

drewdaemon · 2024-01-18T21:30:16Z

/ci

drewdaemon · 2024-01-18T21:31:05Z

/ci

drewdaemon · 2024-01-18T23:16:22Z

/ci

drewdaemon · 2024-01-21T04:24:42Z

/ci

drewdaemon · 2024-01-21T20:19:26Z

@elasticmachine merge upstream

jbudz

ftr_configs.yml

nreese

kibana-presentation changes LGTM
code review only

elasticmachine · 2024-01-22T20:10:53Z

Pinging @elastic/kibana-visualizations (Team:Visualizations)

…fix'

pheyos

test_subjects service changes LGTM

…naged-content

…kibana into lens-respect-managed-content

stratoula · 2024-01-24T06:40:50Z

/ci

stratoula

@drewdaemon this works great in the editor. Just one question and I will approve depending on the answer.

I can still edit this from a dashboard (inline editing). You going to address this in another PR, do I understand this correctly? I didn't see it in the description so I wonder if this is a next step or something we forgot to address!!

stratoula · 2024-01-24T06:42:16Z

packages/kbn-managed-content-badge/README.md

@@ -0,0 +1,3 @@
+# @kbn/managed-content-badge
+
+Empty package generated by @kbn/generate


Maybe this Readme would need some love :D

stratoula · 2024-01-24T06:43:17Z

packages/kbn-managed-content-badge/index.ts

+  toolTipProps: {
+    content: tooltipText,
+    position: 'bottom',
+  } as EuiToolTipProps,


Do we need this casting?

kibana-ci · 2024-01-24T08:35:30Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: fb14547

Failed CI Steps

Test Failures

[job] [logs] Jest Tests #9 / UserActionPropertyActions renders the property actions

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`dashboard`	418	419	+1
`lens`	1238	1239	+1
total			+2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/managed-content-badge`	-	2	+2
`presentationUtil`	164	165	+1
total			+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dashboard`	382.3KB	382.3KB	+41.0B
`lens`	1.4MB	1.4MB	+958.0B
`presentationUtil`	82.1KB	82.2KB	+46.0B
total			+1.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`savedObjects`	22.3KB	22.8KB	+499.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/managed-content-badge`	-	2	+2
`presentationUtil`	219	220	+1
total			+3

History

💛 Build #188758 was flaky 46f8f65
💚 Build #188645 succeeded 1b864fb
💚 Build #188366 succeeded a67bfbf
💚 Build #188361 succeeded ee5e0b8
💔 Build #188317 failed 394db6d
💔 Build #188310 failed 7e24a6b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

drewdaemon · 2024-01-24T14:16:44Z

@stratoula

I can still edit this from a dashboard (inline editing). You going to address this in another PR, do I understand this correctly? I didn't see it in the description so I wonder if this is a next step or something we forgot to address!!

Correct. The following two issues (#172383, #172384) will prevent managed visualizations from being added to unmanaged dashboards. They will cover the inline editing case.

You can see the full plan on the meta issue.

stratoula

Amazing, thanx Drew! LGTM!

## Summary Close elastic#166720 I marked this a breaking change since it is preventing users from doing something they have been able to do before. They can no longer save changes to managed Lens visualizations. Instead, they have to save changes to a new visualization. To test, import this `ndjson` file which includes both a managed and an unmanaged visualization: --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co>

drewdaemon added 5 commits January 17, 2024 11:41

detecting managed Lens visualizations

e1ec9d9

add managed badge to lens

7eb00bd

force copy-on-save for managed content

8f2588d

Add title

ce339fc

Add functional test

817742a

kibanamachine and others added 3 commits January 18, 2024 18:49

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

77d71e2

…fix'

move must copy on save message to keyboard accessible element

f7441ed

Merge branch 'lens-respect-managed-content' of github.com:drewdaemon/…

11b1daa

…kibana into lens-respect-managed-content

drewdaemon added the release_note:breaking label Jan 18, 2024

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

cb61a57

…fix'

Merge branch 'main' into lens-respect-managed-content

524d1a3

[CI] Auto-commit changed files from 'node scripts/generate codeowners'

08495b8

Merge branch 'main' into lens-respect-managed-content

e95de1b

undo managed type change

0978bc0

drewdaemon mentioned this pull request Jan 18, 2024

[Content management] make managed a required prop on the client #175157

Open

make managed prop optional

7c15f12

update snap

7e24a6b

fix translation string

394db6d

remove unused translation

ee5e0b8

drewdaemon requested review from a team as code owners January 21, 2024 20:18

Merge branch 'main' into lens-respect-managed-content

a67bfbf

jbudz approved these changes Jan 22, 2024

View reviewed changes

pgayvallet approved these changes Jan 22, 2024

View reviewed changes

nreese approved these changes Jan 22, 2024

View reviewed changes

drewdaemon added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Jan 22, 2024

drewdaemon and others added 2 commits January 22, 2024 15:35

actually save a new copy

19eda22

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

1b864fb

…fix'

pheyos approved these changes Jan 23, 2024

View reviewed changes

drewdaemon and others added 3 commits January 23, 2024 08:09

Merge branch 'main' of github.com:elastic/kibana into lens-respect-ma…

4d2f844

…naged-content

Merge branch 'lens-respect-managed-content' of github.com:drewdaemon/…

46f8f65

…kibana into lens-respect-managed-content

Merge branch 'main' into lens-respect-managed-content

fb14547

stratoula reviewed Jan 24, 2024

View reviewed changes

stratoula approved these changes Jan 24, 2024

View reviewed changes

drewdaemon merged commit 1d4b7df into elastic:main Jan 24, 2024

kibanamachine added v8.13.0 backport:skip This PR does not require backporting labels Jan 24, 2024

tsullivan mentioned this pull request Dec 5, 2024

[SharedUX] EUI visual refresh for SharedUX #202780

Merged

		@@ -0,0 +1,3 @@
		# @kbn/managed-content-badge

		Empty package generated by @kbn/generate

Conversation

drewdaemon commented Jan 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

drewdaemon commented Jan 18, 2024

Uh oh!

drewdaemon commented Jan 18, 2024

Uh oh!

drewdaemon commented Jan 18, 2024

Uh oh!

drewdaemon commented Jan 18, 2024

Uh oh!

drewdaemon commented Jan 18, 2024

Uh oh!

drewdaemon commented Jan 18, 2024

Uh oh!

drewdaemon commented Jan 18, 2024

Uh oh!

drewdaemon commented Jan 18, 2024

Uh oh!

drewdaemon commented Jan 18, 2024

Uh oh!

drewdaemon commented Jan 18, 2024

Uh oh!

drewdaemon commented Jan 21, 2024

Uh oh!

drewdaemon commented Jan 21, 2024

Uh oh!

jbudz left a comment

Choose a reason for hiding this comment

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jan 22, 2024

Uh oh!

pheyos left a comment

Choose a reason for hiding this comment

Uh oh!

stratoula commented Jan 24, 2024

Uh oh!

stratoula left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stratoula Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

stratoula Jan 24, 2024

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Jan 24, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Uh oh!

drewdaemon commented Jan 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

drewdaemon commented Jan 17, 2024 •

edited

Loading

stratoula left a comment •

edited

Loading

drewdaemon commented Jan 24, 2024 •

edited

Loading