Skip to content

[APM] Unskip apm api test suite#173055

Merged
sorenlouv merged 2 commits intoelastic:mainfrom
sorenlouv:unskip-apm-api-tests
Dec 11, 2023
Merged

[APM] Unskip apm api test suite#173055
sorenlouv merged 2 commits intoelastic:mainfrom
sorenlouv:unskip-apm-api-tests

Conversation

@sorenlouv
Copy link
Copy Markdown
Contributor

@sorenlouv sorenlouv commented Dec 11, 2023 •
edited by kibanamachine
Loading

APM api test suite was accidentally skipped in #172772.
This unskips the suite and instead skips just the flaky tests

Blocking: #173038

@sorenlouv sorenlouv requested a review from a team December 11, 2023 13:46
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Dec 11, 2023
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 11, 2023

Pinging @elastic/apm-ui (Team:APM)

@ghost
Copy link
Copy Markdown

ghost commented Dec 11, 2023

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • /oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@sorenlouv sorenlouv added release_note:skip Skip the PR/issue when compiling release notes v8.12.0 and removed Team:APM - DEPRECATED Use Team:obs-ux-infra_services. labels Dec 11, 2023
cauemarcondes
cauemarcondes approved these changes Dec 11, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Dec 11, 2023
@sorenlouv sorenlouv mentioned this pull request Dec 11, 2023
Closed
@sorenlouv sorenlouv mentioned this pull request Dec 11, 2023
Closed
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Dec 11, 2023

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sorenlouv sorenlouv merged commit cd0648c into elastic:main Dec 11, 2023
@sorenlouv sorenlouv deleted the unskip-apm-api-tests branch December 11, 2023 21:03
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 11, 2023

💔 All backports failed

Status Branch Result
❌ 8.12 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.12:
- [APM] Remove usage of internal client when fetching agent config etags metrics (#173001)

Manual backport

To create the backport manually run:

node scripts/backport --pr 173055

Questions ?

Please refer to the Backport tool documentation

@sorenlouv
Copy link
Copy Markdown
Contributor Author

sorenlouv commented Dec 11, 2023

💚 All backports created successfully

Status Branch Result
✅ 8.12

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

sorenlouv added a commit to sorenlouv/kibana that referenced this pull request Dec 11, 2023
@sorenlouv
[APM] Unskip apm api test suite (elastic#173055)
49e84a8 
APM api test suite was accidentally skipped in
elastic#172772.
This unskips the suite and instead skips just the flaky tests

Blocking: elastic#173038
(cherry picked from commit cd0648c)

# Conflicts:
#	x-pack/test/apm_api_integration/tests/index.ts
@sorenlouv sorenlouv mentioned this pull request Dec 11, 2023
Merged
sorenlouv added a commit that referenced this pull request Dec 12, 2023
@sorenlouv
[8.12] [APM] Remove usage of internal client when fetching agent conf…
837ecf8 
…ig etags metrics (#173001) | [APM] Unskip apm api test suite (#173055) (#173120)

Backports the following to `8.12`:

- #173055
- #173001

<!--BACKPORT {commits} BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.12.0 v8.13.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sorenlouv @elasticmachine @kibana-ci @kibanamachine @cauemarcondes