Upgrade EUI to v91.0.0 (with backports) by tkajtoch · Pull Request #170716 · elastic/kibana

tkajtoch · 2023-11-07T10:01:38Z

v90.0.0⏩v91.0.0-backport.0

⚠️ While this upgrade pings many teams and has a large code diff, the majority of the changes are snapshots or tests-related and do not touch source code, so should theoretically only need a code review and not dedicated QA.

The changes in EUI that required a large swathe of these updates are:

EuiPopover removed an extra unnecessary <div> wrapper on its anchors, which affected many snapshots and a few CSS overrides, which should have been updated
EuiButtonGroup now renders <button> elements instead of <input type="radio"> elements for single selection, which affected both snapshots and E2E tests
EuiSuperDatePicker's absolute date input now requires an Enter keypress when parsing dates (affected E2E tests)
EuiComboBox, when rendered with singleSelection={{ plainText: 'true' }}, no longer renders a pill (i.e. text). This combobox type now behaves more like an EuiFieldText, where the selection is rendered via input value instead. This affected a high amount of E2E tests (both FTR and Cypress), both in terms of updating assertions and changing selections, but should not significantly affect user experience - see [EuiComboBox] Refactor singleSelection.asPlainText to make greater use of the underlying input element eui#7332 for more.

`v91.0.0-backport.0`

This is a backport release only intended for use by Kibana.

Added esqlVis, pipeBreaks, and pipeNoBreaks icon glyphs.
EuiSelectable now allows configurable text truncation via listProps.truncationProps (#7388)
EuiTextTruncate now supports a new calculationDelayMs prop for working around font loading or layout shifting scenarios (#7388)

Bug fixes

Fixed a bug with EuiSelectables with custom truncationProps, where scrollbar widths were not being accounted for (#7392)

`91.0.0`

Updated the background color of EuiPopovers in dark mode to increase visibility & contrast against other page/panel backgrounds (#7310)
Memoized EuiDataGrid to prevent unneeded re-renders (#7324)
Added a configurable role prop to EuiAccordion (#7326)
Added a configurable role prop to EuiGlobalToastList (#7328)
For greater flexibility, EuiSuperDatePicker now allows users to paste ISO 8601, RFC 2822, and Unix timestamps in the Absolute tab input, in addition to timestamps in the dateFormat prop (#7331)
Plain text EuiComboBoxes now behave more like a normal text field/input. Backspacing will no longer delete the entire value, and selected values can now be double clicked and copied. (#7332)
EuiDataGrid's display settings popover now allows users to clear the "Lines per row" input before typing in a new number (#7338)
Improved the UX of EuiSuperDatePicker's Absolute tab for users manually typing in timestamps (#7341)
Updated EuiI18ns with multiple tokens to accept dynamic values (#7341)

Bug fixes

Fixed EuiComboBox's onSearchChange callback to pass the correct hasMatchingOptions value (#7334)
Fixed an EuiSelectableTemplateSitewide bug where the popoverButton behavior would break if passed a non-DOM React wrapper (#7339)

Deprecations

EuiPopover: deprecated anchorClassName. Use className instead (#7311)
EuiPopover: deprecated buttonRef. Use popoverRef instead (#7311)
EuiPopover: removed extra .euiPopover__anchor div wrapper. Target .euiPopover instead if necessary (#7311)
Deprecated EuiButtonGroup's name prop. This can safely be removed. (#7325)

Breaking changes

Removed deprecated euiPaletteComplimentary - use euiPaletteComplementary Instead (#7333)

Accessibility

Updated type="single" EuiButtonGroups to render standard buttons instead of radio buttons under the hood, per recent a11y recommendations (#7325)
EuiAccordion now defaults to a less screenreader-noisy group role instead of region. If your accordion contains significant enough content to be a document landmark role, you may re-configure it back to region. (#7326)
Reduced screen reader noisiness when sorting EuiDataGrid columns via toolbar (#7327)
EuiGlobalToastList now defaults to a log role. If your toasts will always require immediate user action, consider (with caution) using the alert role instead. (#7328)

CSS-in-JS conversions

Updated $euiFontFamily and $euiCodeFontFamily to match Emotion fonts (#7332)

- can be reverted once elastic#170716 merges

opauloh

kubernetes_security changes LGTM

peteharverson

Changes to ML tests LGTM (code review only).

azasypkin

Changes in Security/Spaces tests LGTM.

pheyos

web_element_wrapper test service change LGTM

Heenawter

Tested to ensure that the removal of anchorClassName didn't impact anything visually + looked over test changes. LGTM 👍

elasticmachine · 2023-12-13T14:53:40Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

justinkambic

Code LGTM, no smoke testing on my end

cee-chen · 2023-12-15T19:51:11Z

@elastic/security-detection-rule-management @elastic/security-threat-hunting-investigations @elastic/security-threat-hunting-explore @elastic/kibana-visualizations @elastic/kibana-data-discovery @elastic/response-ops @elastic/fleet @elastic/kibana-design - last ping for reviews. We'll be asking KibanaOps to admin merge on Monday.

banderror

Changes for the Rule Management page (x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/rules_table_filters/rule_search_field.tsx) LGTM -- tested this locally.

As long as CI is happy with the rest of the changes in tests, I'm happy too 👍

mattkime

changes lgtm

stratoula · 2023-12-18T06:39:33Z

/ci

stratoula · 2023-12-18T06:40:05Z

Wow I see some bundle sizes decrease 👏

stratoula

Visualizations team changes LGTM

stephmilovic

LGTM for explore team. thanks!

stephmilovic · 2023-12-18T14:10:21Z

@elasticmachine merge upstream

kibana-ci · 2023-12-18T15:18:29Z

💔 Build Failed

Failed CI Steps

Test Failures

[job] [logs] Defend Workflows Cypress Tests #11 / Response console From Alerts "after all" hook for "should open responder from alert details flyout" "after all" hook for "should open responder from alert details flyout"
[job] [logs] Defend Workflows Cypress Tests #11 / Response console From Alerts "after all" hook for "should open responder from alert details flyout" "after all" hook for "should open responder from alert details flyout"
[job] [logs] Defend Workflows Cypress Tests #11 / Response console From Alerts "before all" hook for "should open responder from alert details flyout" "before all" hook for "should open responder from alert details flyout"
[job] [logs] Defend Workflows Cypress Tests #11 / Response console From Alerts "before all" hook for "should open responder from alert details flyout" "before all" hook for "should open responder from alert details flyout"
[job] [logs] Defend Workflows Cypress Tests #9 / Unenroll agent from fleet changing when agent tamper protection is enabled but then is switched to a policy with it disabled "after all" hook for "should unenroll from fleet without issues" "after all" hook for "should unenroll from fleet without issues"
[job] [logs] Defend Workflows Cypress Tests #9 / Unenroll agent from fleet changing when agent tamper protection is enabled but then is switched to a policy with it disabled "after all" hook for "should unenroll from fleet without issues" "after all" hook for "should unenroll from fleet without issues"
[job] [logs] Defend Workflows Cypress Tests #9 / Unenroll agent from fleet changing when agent tamper protection is enabled but then is switched to a policy with it disabled "before each" hook for "should unenroll from fleet without issues" "before each" hook for "should unenroll from fleet without issues"
[job] [logs] Defend Workflows Cypress Tests #9 / Unenroll agent from fleet changing when agent tamper protection is enabled but then is switched to a policy with it disabled "before each" hook for "should unenroll from fleet without issues" "before each" hook for "should unenroll from fleet without issues"
[job] [logs] Defend Workflows Cypress Tests #8 / Unenroll agent from fleet when agent tamper protection is disabled but then is switched to a policy with it enabled "after all" hook for "should unenroll from fleet without issues" "after all" hook for "should unenroll from fleet without issues"
[job] [logs] Defend Workflows Cypress Tests #8 / Unenroll agent from fleet when agent tamper protection is disabled but then is switched to a policy with it enabled "after all" hook for "should unenroll from fleet without issues" "after all" hook for "should unenroll from fleet without issues"
[job] [logs] Defend Workflows Cypress Tests #8 / Unenroll agent from fleet when agent tamper protection is disabled but then is switched to a policy with it enabled "before each" hook for "should unenroll from fleet without issues" "before each" hook for "should unenroll from fleet without issues"
[job] [logs] Defend Workflows Cypress Tests #8 / Unenroll agent from fleet when agent tamper protection is disabled but then is switched to a policy with it enabled "before each" hook for "should unenroll from fleet without issues" "before each" hook for "should unenroll from fleet without issues"
[job] [logs] Defend Workflows Cypress Tests #10 / Uninstall agent from host changing agent policy when agent tamper protection is disabled but then is switched to a policy with it enabled "after all" hook for "should uninstall from host without issues" "after all" hook for "should uninstall from host without issues"
[job] [logs] Defend Workflows Cypress Tests #10 / Uninstall agent from host changing agent policy when agent tamper protection is disabled but then is switched to a policy with it enabled "after all" hook for "should uninstall from host without issues" "after all" hook for "should uninstall from host without issues"
[job] [logs] Defend Workflows Cypress Tests #10 / Uninstall agent from host changing agent policy when agent tamper protection is disabled but then is switched to a policy with it enabled "before each" hook for "should uninstall from host without issues" "before each" hook for "should uninstall from host without issues"
[job] [logs] Defend Workflows Cypress Tests #10 / Uninstall agent from host changing agent policy when agent tamper protection is disabled but then is switched to a policy with it enabled "before each" hook for "should uninstall from host without issues" "before each" hook for "should uninstall from host without issues"

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`aiops`	424	425	+1
`apm`	1541	1543	+2
`infra`	1330	1328	-2
`maps`	1097	1095	-2
`ml`	1870	1872	+2
`securitySolution`	4832	4833	+1
`securitySolutionServerless`	500	501	+1
`visTypeVega`	310	308	-2
total			+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`aiops`	390.1KB	390.2KB	+96.0B
`apm`	3.7MB	3.7MB	+138.0B
`canvas`	1013.9KB	1013.9KB	-18.0B
`cloudSecurityPosture`	451.7KB	451.7KB	-36.0B
`controls`	198.4KB	198.2KB	-167.0B
`dashboard`	377.3KB	377.2KB	-150.0B
`discover`	593.9KB	593.8KB	-54.0B
`enterpriseSearch`	2.7MB	2.7MB	-108.0B
`eventAnnotationListing`	196.9KB	196.9KB	-16.0B
`exploratoryView`	203.7KB	203.6KB	-120.0B
`fleet`	1.2MB	1.2MB	-60.0B
`graph`	388.2KB	387.9KB	-300.0B
`infra`	1.9MB	1.9MB	-4.7KB
`lens`	1.4MB	1.4MB	-48.0B
`maps`	2.9MB	2.9MB	-4.9KB
`ml`	3.6MB	3.6MB	-481.0B
`securitySolution`	13.1MB	13.1MB	-389.0B
`securitySolutionServerless`	361.1KB	361.2KB	+93.0B
`unifiedDocViewer`	58.6KB	58.4KB	-168.0B
`unifiedSearch`	215.7KB	215.4KB	-255.0B
`visTypeTimeseries`	511.8KB	511.8KB	-18.0B
`visTypeVega`	1.8MB	1.8MB	-4.7KB
total			-16.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`console`	29.2KB	29.1KB	-150.0B
`core`	375.1KB	375.3KB	+186.0B
`embeddable`	78.7KB	78.7KB	-78.0B
`kbnUiSharedDeps-css`	256.1KB	255.9KB	-273.0B
`kbnUiSharedDeps-npmDll`	6.2MB	6.2MB	-1.5KB
`unifiedSearch`	35.5KB	35.4KB	-36.0B
total			-1.9KB

Unknown metric groups

ESLint disabled line counts

id	before	after	diff
`securitySolution`	468	467	-1

Total ESLint disabled count

id	before	after	diff
`securitySolution`	538	537	-1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @tkajtoch

cee-chen · 2023-12-18T17:10:45Z

We just spoke to @jbudz and @kevinlog and received acknowledgement / approval that the failing Cypress Defend tests are not related to the EUI upgrade (thank you so much for merging in main to check however Stratoula/Steph, y'all are awesome)!

As this PR has been open for a while now, and we've alerted multiple teams at various times, we'll be moving forward with asking for an admin merge on this PR shortly.

tkajtoch added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This PR does not require backporting labels Nov 7, 2023

tkajtoch self-assigned this Nov 7, 2023

tkajtoch changed the title ~~Upgrade @elastic/eui to v91.0.0~~ Upgrade EUI to v91.0.0 Nov 7, 2023

tkajtoch force-pushed the eui-v91.x branch 15 times, most recently from 8a7a7d9 to 0e3ea13 Compare November 14, 2023 11:47

tkajtoch force-pushed the eui-v91.x branch from ce28620 to 8af6c63 Compare November 15, 2023 09:09

cee-chen added a commit to cee-chen/kibana that referenced this pull request Nov 16, 2023

[TODO] input click workaround

0798463

- can be reverted once elastic#170716 merges

tkajtoch force-pushed the eui-v91.x branch 2 times, most recently from 2c67880 to 977a4b4 Compare November 20, 2023 15:47

cee-chen mentioned this pull request Nov 20, 2023

[Unified Search] Improve accessibility of flex width comboboxes #171439

Closed

4 tasks

tkajtoch force-pushed the eui-v91.x branch 3 times, most recently from 3876821 to 53e6a31 Compare November 22, 2023 13:25

cee-chen added the ci:skip-cypress-osquery Skips osquery cypress checks label Nov 27, 2023

opauloh approved these changes Dec 12, 2023

View reviewed changes

[PR feedback] Remove RTL debug

c85649b

pgayvallet approved these changes Dec 13, 2023

View reviewed changes

peteharverson approved these changes Dec 13, 2023

View reviewed changes

azasypkin approved these changes Dec 13, 2023

View reviewed changes

sebelga approved these changes Dec 13, 2023

View reviewed changes

pheyos approved these changes Dec 13, 2023

View reviewed changes

Heenawter approved these changes Dec 13, 2023

View reviewed changes

justinkambic approved these changes Dec 13, 2023

View reviewed changes

yuliacech approved these changes Dec 14, 2023

View reviewed changes

vitaliidm approved these changes Dec 14, 2023

View reviewed changes

Merge remote-tracking branch 'upstream/main' into eui-v91.x

0330646

banderror approved these changes Dec 15, 2023

View reviewed changes

mattkime approved these changes Dec 15, 2023

View reviewed changes

cee-chen and others added 4 commits December 15, 2023 13:21

Update latest snapshots/tests from changes in main

b8005a9

Merge remote-tracking branch 'upstream/main' into eui-v91.x

902c0a0

Merge branch 'main' into eui-v91.x

1a4c4e3

Merge branch 'main' into eui-v91.x

10d0255

stratoula approved these changes Dec 18, 2023

View reviewed changes

angorayc approved these changes Dec 18, 2023

View reviewed changes

stephmilovic approved these changes Dec 18, 2023

View reviewed changes

Merge branch 'main' into eui-v91.x

9c03036

sakurai-youhei mentioned this pull request Apr 30, 2024

Time picker shows [object Object] in absolute tab #182099

Closed

Conversation

tkajtoch commented Nov 7, 2023 • edited by cee-chen Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

v91.0.0-backport.0

91.0.0

Uh oh!

opauloh left a comment

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

azasypkin left a comment

Choose a reason for hiding this comment

Uh oh!

pheyos left a comment

Choose a reason for hiding this comment

Uh oh!

Heenawter left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Dec 13, 2023

Uh oh!

justinkambic left a comment

Choose a reason for hiding this comment

Uh oh!

cee-chen commented Dec 15, 2023

Uh oh!

banderror left a comment

Choose a reason for hiding this comment

Uh oh!

mattkime left a comment

Choose a reason for hiding this comment

Uh oh!

stratoula commented Dec 18, 2023

Uh oh!

stratoula commented Dec 18, 2023

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

stephmilovic commented Dec 18, 2023

Uh oh!

kibana-ci commented Dec 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

cee-chen commented Dec 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

tkajtoch commented Nov 7, 2023 •

edited by cee-chen

Loading

`v91.0.0-backport.0`

`91.0.0`

kibana-ci commented Dec 18, 2023 •

edited

Loading