[Serverless] Add panels to side nav#167774
Conversation
14a787b to
cf626e7
Compare
cf626e7 to
91e9e49
Compare
547dc82 to
814fdea
Compare
…sebelga/kibana into serverless-chrome/add-panel-to-side-nav
semd
left a comment
There was a problem hiding this comment.
Security Solution code LGTM
Dosant
left a comment
There was a problem hiding this comment.
great work 👏
I tested storybook, search and obit.
Also tried to explore sideNavStatus option for fixing some breadcrumbs, but there are some other things that need to be done first
| ); | ||
|
|
||
| const onIconClick = useCallback(() => { | ||
| openPanel(item); |
There was a problem hiding this comment.
should clicking the icon again close the panel?
There was a problem hiding this comment.
Interesting... I didn't think about that. I might not re-launch a full CI for that but I'm adding it to my current branch
|
@elasticmachine merge upstream |
…dd-panel-to-side-nav
…sebelga/kibana into serverless-chrome/add-panel-to-side-nav
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
History
To update your PR or re-run it, just comment with: |
|
Great work, @sebelga !! |
This PR add supports for "panels" in the serverless side navigation.
Notes for reviewer
yarn storybook shared_uxAPI
renderAspropertyIn order to indicate that a group in the side navigation should open a panel we use the
renderAsproperty and set it to'panelOpener'.Tree definition
With UI components
Configure the content to render in the panel
There are 2 ways to configure the content that is rendered in the panel:
Generate automatically
To generate automatically the content of the panel we simply add nested groups with their children to the navigation tree.
Provide a custom component
If there is a need to render a custom component instead of the generated one we can pass a
panelContentProviderScreenshots