Skip to content

chore(deps): Update LaunchDarkly clients#167765

Merged
afharo merged 1 commit intoelastic:mainfrom
afharo:kbn-xxxx-update-launchdarkly-clients
Oct 2, 2023
Merged

chore(deps): Update LaunchDarkly clients#167765
afharo merged 1 commit intoelastic:mainfrom
afharo:kbn-xxxx-update-launchdarkly-clients

Conversation

@afharo
Copy link
Copy Markdown
Member

@afharo afharo commented Oct 2, 2023

Summary

Resolves #167542.

Changelog: https://docs.launchdarkly.com/sdk/client-side/javascript/migration-2-to-3

✅ Tested locally, and it still works with existing flags.

Checklist

For maintainers

@afharo afharo added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Team:Journey/Onboarding Platform Journey Onboarding team labels Oct 2, 2023
@afharo afharo self-assigned this Oct 2, 2023
@afharo afharo force-pushed the kbn-xxxx-update-launchdarkly-clients branch from f57c85d to 328f2ef Compare October 2, 2023 12:34
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #63 / serverless observability UI Configure Case Closure options change closure option successfully

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cloudExperiments 40.5KB 52.4KB +11.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
cloudExperiments 7.1KB 6.9KB -116.0B

History

  • 💔 Build #164450 failed f57c85dd24564cf2f2f46af8cc97072c93f657a3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @afharo

@afharo afharo marked this pull request as ready for review October 2, 2023 13:54
@afharo afharo requested a review from a team as a code owner October 2, 2023 13:54
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-core (Team:Core)

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

@afharo afharo merged commit b58e06b into elastic:main Oct 2, 2023
@afharo afharo deleted the kbn-xxxx-update-launchdarkly-clients branch October 2, 2023 13:58
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.10 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 167765

Questions ?

Please refer to the Backport tool documentation

@afharo
Copy link
Copy Markdown
Member Author

afharo commented Oct 3, 2023

💚 All backports created successfully

Status Branch Result
8.10

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

afharo added a commit to afharo/kibana that referenced this pull request Oct 3, 2023
(cherry picked from commit b58e06b)

# Conflicts:
#	package.json
afharo added a commit that referenced this pull request Oct 3, 2023
# Backport

This will backport the following commits from `main` to `8.10`:
- [chore(deps): Update LaunchDarkly clients
(#167765)](#167765)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alejandro Fernández
Haro","email":"alejandro.haro@elastic.co"},"sourceCommit":{"committedDate":"2023-10-02T13:58:46Z","message":"chore(deps):
Update LaunchDarkly clients
(#167765)","sha":"b58e06b2a9b5f16f348b47d911ba9a7957c4483b","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","release_note:skip","backport:prev-minor","Team:Journey/Onboarding","v8.11.0"],"number":167765,"url":"https://github.com/elastic/kibana/pull/167765","mergeCommit":{"message":"chore(deps):
Update LaunchDarkly clients
(#167765)","sha":"b58e06b2a9b5f16f348b47d911ba9a7957c4483b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167765","number":167765,"mergeCommit":{"message":"chore(deps):
Update LaunchDarkly clients
(#167765)","sha":"b58e06b2a9b5f16f348b47d911ba9a7957c4483b"}}]}]
BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// Team:Journey/Onboarding Platform Journey Onboarding team v8.10.3 v8.11.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check/update LaunchDarkly js version

5 participants