Adds api integration tests for core to serverless common#167570
Adds api integration tests for core to serverless common#167570TinaHeiligers merged 3 commits intoelastic:mainfrom
Conversation
|
Pinging @elastic/kibana-core (Team:Core) |
|
@lukeelmers I added you because I need help with adding custom config dependent tests! |
| require.resolve('../../common/scripts_tests'), | ||
| require.resolve('../../common/search_oss'), | ||
| require.resolve('../../common/search_xpack'), | ||
| require.resolve('../../common/core'), |
There was a problem hiding this comment.
The main index file was removed in favor of using common configs (#167172) to specify the common tests to run on each project.
TinaHeiligers
left a comment
There was a problem hiding this comment.
self review
| const supertest = getService('supertest'); | ||
| const svlCommonApi = getService('svlCommonApi'); | ||
| describe('/api/core/capabilities', () => { | ||
| it(`returns a 400 when an invalid app id is provided`, async () => { |
There was a problem hiding this comment.
Test passed without custom config.
| .then((response) => { | ||
| expect(response.header).to.have.property('content-encoding', 'gzip'); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
The other tests we have in test/api_integration/core are either not applicable to serverless or will be added in a follow-up PR. I'll need to figure out how to add tests that use custom configs.
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Canvas Sharable Runtime
History
To update your PR or re-run it, just comment with: |
afharo
left a comment
There was a problem hiding this comment.
LGTM. Remember to reopen the linked issue. It will be closed the moment we merge this one.
Partially fix #167314
This PR adds serverless api_integration tests for
coreas acommontest run for all project types.The tests I added are modified duplicates of those in
test/api_integration/apis/corethat don't rely on custom configuration.