Skip to content

Commit 97c7d7d

Browse files
dmlemeshkodmlemeshko
authored
[ftr] unskip serverless functional tests (#167497)
I hope the change made in #166936 allow us to unskip these tests closes #165763 closes #165386 closes #165414 closes #166448 closes #165943 closes #166461 closes #166551 Flaky-test-runner: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3242 Quick stability check of re-enabled tests: - x-pack/test_serverless/functional/test_suites/common/examples/search_examples/partial_results_example.ts 100/100 - x-pack/test_serverless/functional/test_suites/common/examples/unified_field_list_examples/existing_fields.ts 100/100 failures - x-pack/test_serverless/functional/test_suites/common/home_page.ts 100/100 - x-pack/test_serverless/functional/test_suites/common/index_management/create_enrich_policy.ts 99/100 - x-pack/test_serverless/functional/test_suites/observability/cases/configure.ts 49/50 - x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/app.ts 49/50 - x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/filter_controls.ts 49/50 - x-pack/test_serverless/functional/test_suites/security/ftr/cases/configure.ts 49/50
1 parent b888ecb commit 97c7d7d

8 files changed

Lines changed: 47 additions & 23 deletions

File tree

‎x-pack/test_serverless/functional/test_suites/common/examples/search_examples/partial_results_example.ts‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,20 @@ import type { FtrProviderContext } from '../../../../ftr_provider_context';
1010

1111
export default function ({ getService, getPageObjects }: FtrProviderContext) {
1212
const testSubjects = getService('testSubjects');
13-
const PageObjects = getPageObjects(['common']);
13+
const PageObjects = getPageObjects(['common', 'svlCommonPage']);
1414
const retry = getService('retry');
1515

16-
// FLAKY: https://github.com/elastic/kibana/issues/165763
17-
describe.skip('Partial results example', () => {
16+
describe('Partial results example', () => {
1817
before(async () => {
18+
await PageObjects.svlCommonPage.login();
1919
await PageObjects.common.navigateToApp('searchExamples');
2020
await testSubjects.click('/search');
2121
});
2222

23+
after(async () => {
24+
await PageObjects.svlCommonPage.forceLogout();
25+
});
26+
2327
it('should update a progress bar', async () => {
2428
await testSubjects.click('responseTab');
2529
const progressBar = await testSubjects.find('progressBar');

‎x-pack/test_serverless/functional/test_suites/common/examples/unified_field_list_examples/existing_fields.ts‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,13 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => {
2828
const retry = getService('retry');
2929
const testSubjects = getService('testSubjects');
3030
const monacoEditor = getService('monacoEditor');
31-
const PageObjects = getPageObjects(['common', 'timePicker', 'header', 'unifiedFieldList']);
31+
const PageObjects = getPageObjects([
32+
'common',
33+
'timePicker',
34+
'header',
35+
'unifiedFieldList',
36+
'svlCommonPage',
37+
]);
3238
const dataViewTitle = 'existence_index_*';
3339

3440
async function addDSLFilter(value: string) {
@@ -51,16 +57,15 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => {
5157
await PageObjects.header.waitUntilLoadingHasFinished();
5258
}
5359

54-
// Failing: See https://github.com/elastic/kibana/issues/165938
55-
// Failing: See https://github.com/elastic/kibana/issues/165927
56-
describe.skip('Fields existence info', () => {
60+
describe('Fields existence info', () => {
5761
before(async () => {
5862
await esArchiver.load(
5963
'test/api_integration/fixtures/es_archiver/index_patterns/constant_keyword'
6064
);
6165
await kibanaServer.importExport.load(
6266
'test/api_integration/fixtures/kbn_archiver/index_patterns/constant_keyword.json'
6367
);
68+
await PageObjects.svlCommonPage.login();
6469
await PageObjects.common.navigateToApp('unifiedFieldListExamples');
6570
await PageObjects.header.waitUntilLoadingHasFinished();
6671
await retry.waitFor('combobox is ready', async () => {
@@ -85,6 +90,7 @@ export default ({ getService, getPageObjects }: FtrProviderContext) => {
8590
);
8691
await PageObjects.unifiedFieldList.cleanSidebarLocalStorage();
8792
await kibanaServer.savedObjects.cleanStandardList();
93+
await PageObjects.svlCommonPage.forceLogout();
8894
});
8995

9096
describe('existence', () => {

‎x-pack/test_serverless/functional/test_suites/common/home_page/home_page.ts‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,15 @@ export default function ({ getPageObject, getService }: FtrProviderContext) {
1111
const svlCommonPage = getPageObject('svlCommonPage');
1212
const svlCommonNavigation = getService('svlCommonNavigation');
1313

14-
// Failing: See https://github.com/elastic/kibana/issues/165386
15-
// FLAKY: https://github.com/elastic/kibana/issues/165414
16-
describe.skip('home page', function () {
14+
describe('home page', function () {
15+
before(async () => {
16+
await svlCommonPage.login();
17+
});
18+
19+
after(async () => {
20+
await svlCommonPage.forceLogout();
21+
});
22+
1723
it('has project header', async () => {
1824
await svlCommonNavigation.navigateToKibanaHome();
1925
await svlCommonPage.assertProjectHeaderExists();

‎x-pack/test_serverless/functional/test_suites/common/management/index_management/create_enrich_policy.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
2121

2222
describe('Create enrich policy', function () {
2323
before(async () => {
24-
await log.debug('Creating test index');
24+
log.debug('Creating test index');
2525
try {
2626
await es.indices.create({
2727
index: INDEX_NAME,
@@ -43,7 +43,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
4343
throw e;
4444
}
4545

46-
await log.debug('Navigating to the enrich policies tab');
46+
log.debug('Navigating to the enrich policies tab');
4747
await pageObjects.svlCommonPage.login();
4848
await security.testUser.setRoles(['index_management_user']);
4949
await pageObjects.common.navigateToApp('indexManagement');
@@ -56,7 +56,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
5656
});
5757

5858
after(async () => {
59-
await log.debug('Cleaning up created index');
59+
log.debug('Cleaning up created index');
6060

6161
try {
6262
await es.indices.delete({ index: INDEX_NAME });

‎x-pack/test_serverless/functional/test_suites/observability/cases/configure.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
1717
const cases = getService('cases');
1818
const toasts = getService('toasts');
1919

20-
// Failing: See https://github.com/elastic/kibana/issues/166448
21-
describe.skip('Configure Case', function () {
20+
describe('Configure Case', function () {
2221
before(async () => {
2322
await svlCommonPage.login();
2423

‎x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/app.ts‎

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,22 @@
77
import expect from '@kbn/expect';
88
import { FtrProviderContext } from '../../../ftr_provider_context';
99

10-
export default function ({ getService, getPageObjects }: FtrProviderContext) {
11-
const PageObjects = getPageObjects(['observabilityLogExplorer', 'svlCommonNavigation']);
10+
export default function ({ getPageObjects }: FtrProviderContext) {
11+
const PageObjects = getPageObjects([
12+
'observabilityLogExplorer',
13+
'svlCommonNavigation',
14+
'svlCommonPage',
15+
]);
16+
17+
describe('Application', () => {
18+
before(async () => {
19+
await PageObjects.svlCommonPage.login();
20+
});
21+
22+
after(async () => {
23+
await PageObjects.svlCommonPage.forceLogout();
24+
});
1225

13-
// FLAKY: https://github.com/elastic/kibana/issues/165943
14-
describe.skip('Application', () => {
1526
it('is shown in the global search', async () => {
1627
await PageObjects.observabilityLogExplorer.navigateTo();
1728
await PageObjects.svlCommonNavigation.search.showSearch();

‎x-pack/test_serverless/functional/test_suites/observability/observability_log_explorer/filter_controls.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
1111
const PageObjects = getPageObjects(['observabilityLogExplorer', 'svlCommonPage']);
1212
const testSubjects = getService('testSubjects');
1313

14-
// Failing: See https://github.com/elastic/kibana/issues/166461
15-
describe.skip('Filter controls customization', () => {
14+
describe('Filter controls customization', () => {
1615
before('initialize tests', async () => {
1716
await PageObjects.svlCommonPage.login();
1817
await kibanaServer.importExport.load('test/functional/fixtures/kbn_archiver/discover');

‎x-pack/test_serverless/functional/test_suites/security/ftr/cases/configure.ts‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ export default ({ getPageObject, getService }: FtrProviderContext) => {
1616
const cases = getService('cases');
1717
const toasts = getService('toasts');
1818

19-
// Failing: See https://github.com/elastic/kibana/issues/166551
20-
describe.skip('Configure Case', function () {
19+
describe('Configure Case', function () {
2120
before(async () => {
2221
await svlCommonPage.login();
2322

0 commit comments

Comments
 (0)