Merged
Conversation
…for the hellopangea/dnd dev dependency
…t recently was refactored and converted to Emotion.
… it is no longer being used after the components most recent refactor and Emotion conversion.
Contributor
Author
|
@elasticmachine merge upstream |
…g within hellopangea/dnd dev dependency
Contributor
Author
|
|
Contributor
|
Pinging @elastic/eui-team (EUI) |
jbudz
approved these changes
Sep 13, 2023
jloleysens
approved these changes
Sep 14, 2023
Merge in the latest from main
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
Contributor
|
Sorry, had to revert this with f270c31. Build Storybooks failure here https://buildkite.com/elastic/kibana-on-merge/builds/35559#018aaa65-382b-438b-a52c-b3c35b15380e/272-392 |
jbudz
added a commit
that referenced
this pull request
Sep 20, 2023
⚠️ NOTE: This PR is a copy of #166292 (which was reverted due to failing Storybook builds). This is the same exact PR but with Storybook building fixed. --- EUI `88.2.0` ➡️ `88.3.0` ## [`88.3.0`](https://github.com/elastic/eui/tree/v88.3.0) - `EuiGlobalToastList` now shows a "Clear all" button by default once above a certain number of toasts (defaults to 3). This threshold is configurable with the `showClearAllButtonAt` prop ([#7111](elastic/eui#7111)) - Added an optional `onClearAllToasts` callback to `EuiGlobalToastList` ([#7111](elastic/eui#7111)) - Added the `value`, `onChange`, and `onCancel` props that allow `EuiInlineEdit` to be used as a controlled component ([#7157](elastic/eui#7157)) - Added `grabOmnidirectional`, `transitionLeftIn`, `transitionLeftOut`, `transitionTopIn`, and `transitionTopOut` icon glyphs. ([#7168](elastic/eui#7168)) **Bug fixes** - Fixed `EuiInlineEdit` components to correctly spread `...rest` attributes to the parent wrapper ([#7157](elastic/eui#7157)) - Fixed `EuiListGroupItem` to correctly render the `extraAction` button when `showToolTip` is also passed ([#7159](elastic/eui#7159)) **Dependency updates** - Updated `@hello-pangea/dnd` to v16.3.0 ([#7125](elastic/eui#7125)) - Updated `@types/lodash` to v4.14.198 ([#7126](elastic/eui#7126)) **Accessibility** - `EuiAccordion` now correctly respects reduced motion settings ([#7161](elastic/eui#7161)) - `EuiAccordion` now shows a focus outline to keyboard users around its revealed children on open ([#7161](elastic/eui#7161)) **CSS-in-JS conversions** - Converted `EuiSplitPanel` to Emotion ([#7172](elastic/eui#7172)) --------- Co-authored-by: Bree Hall <briannajdhall@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Jon <jon@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EUI
88.2.0➡️88.3.088.3.0EuiGlobalToastListnow shows a "Clear all" button by default once above a certain number of toasts (defaults to 3). This threshold is configurable with theshowClearAllButtonAtprop (#7111)onClearAllToastscallback toEuiGlobalToastList(#7111)value,onChange, andonCancelprops that allowEuiInlineEditto be used as a controlled component (#7157)grabOmnidirectional,transitionLeftIn,transitionLeftOut,transitionTopIn, andtransitionTopOuticon glyphs. (#7168)Bug fixes
EuiInlineEditcomponents to correctly spread...restattributes to the parent wrapper (#7157)EuiListGroupItemto correctly render theextraActionbutton whenshowToolTipis also passed (#7159)Dependency updates
@hello-pangea/dndto v16.3.0 (#7125)@types/lodashto v4.14.198 (#7126)Accessibility
EuiAccordionnow correctly respects reduced motion settings (#7161)EuiAccordionnow shows a focus outline to keyboard users around its revealed children on open (#7161)CSS-in-JS conversions
EuiSplitPanelto Emotion (#7172)