[Security Solution][Unified IA] New sections with landing page by semd · Pull Request #163102 · elastic/kibana

semd · 2023-08-03T17:03:46Z

Summary

The new links and pages in Security Solution for Serverless:

Investigations
- Timelines
- Osquery
Assets
- Fleet (and all its sub-links)
- Endpoints (and all its sub-links)
- Cloud defend (and all its sub-links)
- Callout with button linking Integrations in Project Setting
Project settings
- Users & roles (Cloud UI)
- Billing & consumption (Cloud UI)
- Integrations (link to integrations with /browse/security path parameter)
- Entity risk score (link currently under the riskScoringRoutesEnabled experimental flag)
- Management accordion with a set of (stack) management categories and pages links

Sections updated:

(ESS & Serverless) Rules links have been updated according to new specs.
(ESS) The Settings page was renamed back to Manage.
(Serverless) The Dev tools link was moved to the bottom of the side navigation.

Cypress tests for serverless:

They will be implemented in a follow-up PR when the infrastructure is ready #162698

Screenshots

Serverless

Investigations:

Assets:

Rules:

Project Settings:

ESS

Side Navigation:

…-fix'

…fied_ia_assets

semd · 2023-08-08T22:30:39Z

@elasticmachine merge upstream

semd · 2023-08-10T14:52:54Z

@jpdjere

Fleet pages seem to lack a minimum padding against the navigation, when the viewport is sufficiently narrow

Good catch, Fleet folks will take care of the issue here. Thanks for the thorough review.

...k/packages/security-solution/navigation/src/landing_links/landing_links_icons_categories.tsx

x-pack/packages/security-solution/navigation/src/landing_links/landing_links.tsx

x-pack/packages/security-solution/navigation/src/landing_links/landing_links_icons.tsx

...ges/security-solution/navigation/src/landing_links/landing_links_icons_categories_groups.tsx

x-pack/packages/security-solution/navigation/src/landing_links/landing_links_images.tsx

x-pack/packages/security-solution/side_nav/src/solution_side_nav_panel.tsx

machadoum · 2023-08-10T16:10:27Z

Very nit UI issues. Definitely not a blocker:

Some pages have a grey background and it looks a bit off, is it intentional?

When this page loads it flicks a little bit.

semd · 2023-08-10T20:50:24Z

@machadoum

Some pages have a grey background and it looks a bit off, is it intentional?

This is caused by having a different layout on serverless, probably those pages miss the KibanaPageTemplate.Section wrapper. But this is unrelated to the navigation changes, it will need to be addressed by the different teams owning those pages.

…fied_ia_assets

machadoum · 2023-08-11T10:08:15Z

I noticed that the new pages don't render TrackApplicationView. Are we tracking these pages differently?

angorayc · 2023-08-11T11:28:22Z

x-pack/plugins/security_solution_serverless/public/plugin.ts

    setupDeps: SecuritySolutionServerlessPluginSetupDeps
  ): SecuritySolutionServerlessPluginSetup {
    registerUpsellings(setupDeps.securitySolution.upselling, this.config.productTypes);
+    setupDeps.securitySolution.setAppLinksSwitcher(projectAppLinksSwitcher);


I like how it adjusts the links for serverless and has permission checked. I also like that we've moved all the serverless relevent flags to plugin contract, very well organised. 👍

angorayc · 2023-08-11T11:29:19Z

x-pack/plugins/security_solution_serverless/public/navigation/links/util.ts

+
+export const isCloudLink = (linkId: string): boolean => linkId.startsWith('cloud:');
+export const getCloudLinkKey = (linkId: string): string => linkId.replace('cloud:', '');
+export const getCloudUrl = (cloudUrlKey: string, cloud: CloudStart): string | undefined => {


semd · 2023-08-11T17:39:41Z

@machadoum

I noticed that the new pages don't render TrackApplicationView. Are we tracking these pages differently?

Since I am not sure how telemetry is going to work in serverless I've just omited tracking for now, I added a task here to do it later #162072

ashokaditya

Thanks for the large set of changes. 🔥 I have got a few suggestions and notes.

I also tested it out. I think that the menu panel floating over the sub-header in serverless mode looks funky. It should be attached to the bottom of the subheader. It's not how it behaves in the ESS mode. Not sure if this is by design?

serverless

vs ESS

ashokaditya · 2023-08-10T08:29:04Z

x-pack/plugins/security_solution_serverless/public/pages/investigations.tsx

+    <KibanaPageTemplate restrictWidth={false} contentBorder={false} grow={true}>
+      <KibanaPageTemplate.Section>
+        <EuiPageHeader pageTitle={title} />
+        <EuiSpacer size="l" />
+        <EuiSpacer size="xl" />


Looks like the template props, title and spacer values are same for all the pages. Consider extracting it into a common page/wrapper component that can be used for all the pages. Something like,

<PageWrapper> <LandingLinksIcons items={links} /> </PageWrapper>

<PageWrapper> <LandingLinksIconsCategories links={links} categories={categories} /> </PageWrapper>

and so on

That's a good suggestion! But I am on PTO for the next two weeks, would you mind if we do this on a follow-up PR? So we can merge the main changes.

Sounds good @semd

x-pack/plugins/security_solution_serverless/public/navigation/links/util.ts

semd · 2023-08-14T17:30:28Z

@ashokaditya

I think that the menu panel floating over the sub-header in serverless mode looks funky

This is a known issue on the serverless top header bar, it is fixed here #162002. merging main should fix it.

semd · 2023-08-14T17:31:02Z

@elasticmachine merge upstream

kibana-ci · 2023-08-14T18:13:14Z

💛 Build succeeded, but was flaky

Failed CI Steps

Defend Workflows Cypress Tests #1

Test Failures

[job] [logs] Defend Workflows Cypress Tests #1 / Endpoint Policy Response from Fleet Agent Details page should display policy response with errors should display policy response with errors

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`fleet`	860	861	+1
`securitySolution`	4406	4410	+4
`securitySolutionServerless`	251	409	+158
total			+163

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/security-solution-navigation`	41	47	+6
`@kbn/security-solution-side-nav`	21	23	+2
total			+8

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`fleet`	1022.7KB	1022.7KB	+20.0B
`securitySolution`	15.6MB	15.6MB	+11.6KB
`securitySolutionServerless`	134.1KB	255.3KB	+121.2KB
total			+132.9KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`securitySolution`	33	34	+1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`cloudSecurityPosture`	13.0KB	13.0KB	-9.0B
`fleet`	138.8KB	140.1KB	+1.3KB
`securitySolution`	61.3KB	61.0KB	-293.0B
`securitySolutionServerless`	25.4KB	38.0KB	+12.5KB
total			+13.5KB

Unknown metric groups

API count

id	before	after	diff
`@kbn/security-solution-navigation`	44	50	+6
`@kbn/security-solution-side-nav`	27	29	+2
total			+8

async chunk count

id	before	after	diff
`securitySolution`	47	49	+2
`securitySolutionServerless`	22	35	+13
total			+15

ESLint disabled line counts

id	before	after	diff
`@kbn/security-solution-navigation`	5	6	+1
`securitySolutionServerless`	24	35	+11
total			+12

Total ESLint disabled count

id	before	after	diff
`@kbn/security-solution-navigation`	5	6	+1
`securitySolutionServerless`	24	35	+11
total			+12

History

💛 Build #149430 was flaky 1b87221
💔 Build #149409 failed 6783960
💛 Build #148969 was flaky 739750b
💚 Build #148960 succeeded 7eb89a1
💚 Build #148913 succeeded ef2c6cf

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @semd

ashokaditya

🚀

## Summary closes: #157847 The new links and pages in Security Solution for Serverless: - `Investigations` - `Timelines` - `Osquery` - `Assets` - `Fleet` (and all its sub-links) - `Endpoints` (and all its sub-links) - `Cloud defend` (and all its sub-links) - Callout with button linking `Integrations` in Project Setting - `Project settings` - `Users & roles` (Cloud UI) - `Billing & consumption` (Cloud UI) - `Integrations` (link to integrations with _/browse/security_ path parameter) - `Entity risk score` (link currently under the `riskScoringRoutesEnabled` experimental flag) - `Management` accordion with a set of (stack) management categories and pages links Sections updated: (ESS & Serverless) `Rules` links have been updated according to new specs. (ESS) The `Settings` page was renamed back to `Manage`. (Serverless) The `Dev tools` link was moved to the bottom of the side navigation. #### Cypress tests for serverless: They will be implemented in a follow-up PR when the infrastructure is ready #162698 ## Screenshots ### Serverless Investigations: ![investigations](https://github.com/elastic/kibana/assets/17747913/19b602ab-53bb-4280-b0c3-dc69255ea3ab) ![investigations_panel](https://github.com/elastic/kibana/assets/17747913/8be036fc-6095-4234-8b07-1a7149c8a92b) Assets: ![assets](https://github.com/elastic/kibana/assets/17747913/963723d5-16da-45dd-955c-a7d7b61099e6) ![assets_panel](https://github.com/elastic/kibana/assets/17747913/977c0716-7cc3-4369-acdf-0787e264a912) Rules: ![rules](https://github.com/elastic/kibana/assets/17747913/5bafbd08-508c-4b50-bd28-dc052371e76a) ![rules_panel](https://github.com/elastic/kibana/assets/17747913/ea47f8d9-4b68-44f3-8a42-6f795d05b982) Project Settings: ![project_settings](https://github.com/elastic/kibana/assets/17747913/36dbb446-3354-4519-b59c-e8b5005fbb71) ![project_settings_panel](https://github.com/elastic/kibana/assets/17747913/1315b54b-4423-41a2-b0ed-997ee77c1f6d) ## ESS Side Navigation: ![ess_side_nav](https://github.com/elastic/kibana/assets/17747913/a3687a47-3ccb-4ce8-aa53-9e962a6ef1cf) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Tomasz Ciecierski <ciecierskitomek@gmail.com> Co-authored-by: Tomasz Ciecierski <tomasz.ciecierski@elastic.co>

semd and others added 8 commits August 1, 2023 18:34

add app links switcher for more flexibility in serverless navigation

fdf842c

New Assets landing page with Fleet, Endpoint and Cloud defend links

4c679f5

translations

f13b9b7

project settings initial implementation

bdf9e2b

landing link component

55866d7

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

54a3f9e

…-fix'

management accordion links section added

3ff4d5e

conflicts solved

d72e6ad

semd changed the title ~~[Security Solution][Unified IA] New Assets section with landing page~~ [Security Solution][Unified IA] New sections with landing page Aug 4, 2023

semd added 6 commits August 7, 2023 10:49

Merge remote-tracking branch 'upstream/main' into 157847_security_uni…

bf08e8c

…fied_ia_assets

side navigation accordion category implemented

d7cbceb

investigations links and integrations callout

a349871

fix types

9167b68

translations files fixed

f2d2c1d

fix ftr test

b505f98

semd self-assigned this Aug 8, 2023

semd added 5 commits August 8, 2023 10:35

fix type errors

fee0d91

fix cypress tests

2e8c4a7

fix jest tests

9bd1270

Merge remote-tracking branch 'upstream/main' into 157847_security_uni…

0175e51

…fied_ia_assets

add new tests and storybooks

7e950cc

Merge branch 'main' into 157847_security_unified_ia_assets

a8315f4

semd added release_note:enhancement Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Explore ci:cloud-deploy Create or update a Cloud deployment v8.10.0 labels Aug 8, 2023

fix unrelated cypress test

ac3ee2e

semd marked this pull request as ready for review August 9, 2023 17:05

machadoum reviewed Aug 10, 2023

View reviewed changes

semd added 2 commits August 10, 2023 15:52

rollback uuid generation on entpoint cypress test

a7c0cf3

Merge remote-tracking branch 'upstream/main' into 157847_security_uni…

6783960

…fied_ia_assets

semd mentioned this pull request Aug 10, 2023

[Security Solution]Rule Grouping navigation showing without Access to Rule Kibana Feature #163559

Closed

update fleet limits and address PR comments

1b87221

semd requested a review from a team as a code owner August 10, 2023 22:37

jbudz approved these changes Aug 10, 2023

View reviewed changes

angorayc reviewed Aug 11, 2023

View reviewed changes

angorayc approved these changes Aug 11, 2023

View reviewed changes

semd enabled auto-merge (squash) August 11, 2023 14:59

ashokaditya reviewed Aug 14, 2023

View reviewed changes

Merge branch 'main' into 157847_security_unified_ia_assets

a86e1c1

semd mentioned this pull request Aug 15, 2023

[Security Solution]Create Rule Button name need to identical with Rule Details Page #163464

Closed

ashokaditya approved these changes Aug 15, 2023

View reviewed changes

semd merged commit 560c871 into elastic:main Aug 15, 2023

kibanamachine added the backport:skip This PR does not require backporting label Aug 15, 2023

nastasha-solomon mentioned this pull request Aug 16, 2023

[Meta] Update Security UI side nav elastic/security-docs#3694

Closed

This was referenced Aug 16, 2023

[Security Solutions] Add upselling service to security solutions ESS plugin #163406

Merged

[Security Solution]Container workload protection showing with None Access to Security Sub Features #163562

Closed

nastasha-solomon mentioned this pull request Sep 4, 2023

8.10.0 Release notes elastic/security-docs#3781

Merged

Conversation

semd commented Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Cypress tests for serverless:

Screenshots

Serverless

ESS

Uh oh!

semd commented Aug 8, 2023

Uh oh!

semd commented Aug 10, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

machadoum commented Aug 10, 2023

Uh oh!

semd commented Aug 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

machadoum commented Aug 11, 2023

Uh oh!

angorayc Aug 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

angorayc Aug 11, 2023

Choose a reason for hiding this comment

Uh oh!

semd commented Aug 11, 2023

Uh oh!

ashokaditya left a comment

Choose a reason for hiding this comment

Uh oh!

ashokaditya Aug 10, 2023

Choose a reason for hiding this comment

Uh oh!

semd Aug 14, 2023

Choose a reason for hiding this comment

Uh oh!

ashokaditya Aug 15, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

semd commented Aug 14, 2023

Uh oh!

semd commented Aug 14, 2023

Uh oh!

kibana-ci commented Aug 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

async chunk count

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

ashokaditya left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

semd commented Aug 3, 2023 •

edited

Loading

semd commented Aug 10, 2023 •

edited

Loading

angorayc Aug 11, 2023 •

edited

Loading

kibana-ci commented Aug 14, 2023 •

edited

Loading