[Fleet] Do not ignore coreMigrationVersion and typeMigrationVersion when importing saved object#161969
Merged
nchaulet merged 2 commits intoelastic:mainfrom Jul 14, 2023
Merged
Conversation
…hen importing saved object
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
juliaElastic
approved these changes
Jul 14, 2023
Contributor
juliaElastic
left a comment
There was a problem hiding this comment.
LGTM
Is there any automated test that could cover this fix?
joshdover
approved these changes
Jul 14, 2023
Member
Author
I think adding an automated test for that is probably too complex for the value it will provide, but if you have one in mind that make sense, I can try to add it. |
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
To update your PR or re-run it, just comment with: cc @nchaulet |
15 tasks
Merged
1 task
juliaElastic
added a commit
that referenced
this pull request
Aug 22, 2023
…ation version setting (#164456) ## Summary Closes #164243 Added a `typeMigrationVersion: '8.0.0'` to index patterns until #164454 is fixed. Related to #161969 Feedback from kibana core team, we should always set the migration version fields, even if `migrationVersion` is not set. It would be good to backport this to 8.9 too. How to test locally: - create a test space - install system integration in test space - restart kibana - verify that the index patterns `logs-*`, `metrics-*` are still in test space in Data Views UI ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 22, 2023
…ation version setting (elastic#164456) ## Summary Closes elastic#164243 Added a `typeMigrationVersion: '8.0.0'` to index patterns until elastic#164454 is fixed. Related to elastic#161969 Feedback from kibana core team, we should always set the migration version fields, even if `migrationVersion` is not set. It would be good to backport this to 8.9 too. How to test locally: - create a test space - install system integration in test space - restart kibana - verify that the index patterns `logs-*`, `metrics-*` are still in test space in Data Views UI ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 433d4f2)
kibanamachine
referenced
this pull request
Aug 22, 2023
…ix migration version setting (#164456) (#164484) # Backport This will backport the following commits from `main` to `8.10`: - [[Fleet] Fix index patterns being recreated in default space, fix migration version setting (#164456)](#164456) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Bardi","email":"90178898+juliaElastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-08-22T16:55:17Z","message":"[Fleet] Fix index patterns being recreated in default space, fix migration version setting (#164456)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/164243\r\nAdded a `typeMigrationVersion: '8.0.0'` to index patterns until\r\nhttps://github.com//issues/164454 is fixed.\r\n\r\nRelated to https://github.com/elastic/kibana/pull/161969\r\nFeedback from kibana core team, we should always set the migration\r\nversion fields, even if `migrationVersion` is not set.\r\n\r\nIt would be good to backport this to 8.9 too.\r\n\r\nHow to test locally:\r\n\r\n- create a test space\r\n- install system integration in test space\r\n- restart kibana\r\n- verify that the index patterns `logs-*`, `metrics-*` are still in test\r\nspace in Data Views UI\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"433d4f21c39fa7c364e3275443f673360dda5d18","branchLabelMapping":{"^v8.11.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.10.0","v8.11.0","v8.9.2"],"number":164456,"url":"https://github.com/elastic/kibana/pull/164456","mergeCommit":{"message":"[Fleet] Fix index patterns being recreated in default space, fix migration version setting (#164456)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/164243\r\nAdded a `typeMigrationVersion: '8.0.0'` to index patterns until\r\nhttps://github.com//issues/164454 is fixed.\r\n\r\nRelated to https://github.com/elastic/kibana/pull/161969\r\nFeedback from kibana core team, we should always set the migration\r\nversion fields, even if `migrationVersion` is not set.\r\n\r\nIt would be good to backport this to 8.9 too.\r\n\r\nHow to test locally:\r\n\r\n- create a test space\r\n- install system integration in test space\r\n- restart kibana\r\n- verify that the index patterns `logs-*`, `metrics-*` are still in test\r\nspace in Data Views UI\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"433d4f21c39fa7c364e3275443f673360dda5d18"}},"sourceBranch":"main","suggestedTargetBranches":["8.10","8.9"],"targetPullRequestStates":[{"branch":"8.10","label":"v8.10.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.11.0","labelRegex":"^v8.11.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/164456","number":164456,"mergeCommit":{"message":"[Fleet] Fix index patterns being recreated in default space, fix migration version setting (#164456)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/164243\r\nAdded a `typeMigrationVersion: '8.0.0'` to index patterns until\r\nhttps://github.com//issues/164454 is fixed.\r\n\r\nRelated to https://github.com/elastic/kibana/pull/161969\r\nFeedback from kibana core team, we should always set the migration\r\nversion fields, even if `migrationVersion` is not set.\r\n\r\nIt would be good to backport this to 8.9 too.\r\n\r\nHow to test locally:\r\n\r\n- create a test space\r\n- install system integration in test space\r\n- restart kibana\r\n- verify that the index patterns `logs-*`, `metrics-*` are still in test\r\nspace in Data Views UI\r\n\r\n### Checklist\r\n\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"433d4f21c39fa7c364e3275443f673360dda5d18"}},{"branch":"8.9","label":"v8.9.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
juliaElastic
added a commit
to juliaElastic/kibana
that referenced
this pull request
Aug 23, 2023
…ation version setting (elastic#164456) Closes elastic#164243 Added a `typeMigrationVersion: '8.0.0'` to index patterns until elastic#164454 is fixed. Related to elastic#161969 Feedback from kibana core team, we should always set the migration version fields, even if `migrationVersion` is not set. It would be good to backport this to 8.9 too. How to test locally: - create a test space - install system integration in test space - restart kibana - verify that the index patterns `logs-*`, `metrics-*` are still in test space in Data Views UI - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To avoid running all migrations again we should import
coreMigrationVersionandtypeMigrationVersionTests
I tested this by installing the system integration from that PR that was failing elastic/integrations#6743
And I also run locally the
node scripts/install_all_packagesto install all package.