[Actions] Set system actions on Kibana start by cnasikas · Pull Request #160983 · elastic/kibana

cnasikas · 2023-06-30T11:25:17Z

Summary

This PR:

Adds the ability to create system action types
Creates system connectors on Kibana start from the system action types
Prevents system action to be created/updated/deleted
Return system actions from the get/getAll endpoints

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

…ana into system_actions_registration

x-pack/plugins/actions/server/actions_client.test.ts

…ntext

cnasikas · 2023-07-03T11:08:44Z

x-pack/plugins/synthetics/public/apps/synthetics/state/settings/api.ts

      enabled_in_license: enabledInLicense,
      minimum_license_required: minimumLicenseRequired,
      supported_feature_ids: supportedFeatureIds,
+      is_system_action_type: isSystemActionType,


Related: #160753 (comment)

elasticmachine · 2023-07-03T11:08:50Z

Pinging @elastic/uptime (Team:uptime)

stephmilovic

Security Assistant changes LGTM, thank you!

elasticmachine · 2023-07-06T11:38:59Z

Pinging @elastic/response-ops (Team:ResponseOps)

pmuellr

LGTM, some nits with messages and some questions, no blockers

pmuellr · 2023-07-07T14:04:14Z

x-pack/plugins/actions/server/actions_client.test.ts

+    );
+  });
+
+  it('throws when creating a system connector where the action type is not registered but a system connector exists in the in-memory list', async () => {


How could this happen? Doesn't seem like it matters that there's an existing inMemoryConnector of this type, which presumably would have had to been registered before hand.

Yes, it is impossible for this to happen. I added it in case we introduce a bug in the future and somehow becomes possible. Extreme scenario though 🙂.

x-pack/plugins/actions/server/actions_client.ts

pmuellr · 2023-07-07T14:19:58Z

x-pack/plugins/actions/server/create_execute_function.test.ts

+      source: asHttpRequestExecutionSource(request),
+    });
+
+    expect(mockedActionTypeRegistry.ensureActionTypeEnabled).not.toHaveBeenCalled();


Hmmm ... this feels like we're not allowing system actions to be deny-listed (by not including them in the allow-list). I guess I can see that, but ... not sure.

We discussed it offline and it seems there is a use-case scenario where you can disallow an action type but not a preconfigured connector. This does not apply to system actions. I will address it in another PR.

kibana-ci · 2023-07-07T17:39:31Z

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

[job] [logs] Rules, Alerts and Exceptions ResponseOps Cypress Tests on Security Solution #2 / Export rules shows a modal saying that no rules can be exported if all the selected rules are prebuilt

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`actions`	265	266	+1
`triggersActionsUi`	521	522	+1
total			+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	11.0MB	11.0MB	+176.0B
`synthetics`	907.1KB	907.2KB	+45.0B
`uptime`	518.8KB	518.9KB	+45.0B
total			+266.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`triggersActionsUi`	86.8KB	86.8KB	+45.0B

Unknown metric groups

API count

id	before	after	diff
`actions`	270	271	+1
`triggersActionsUi`	547	548	+1
total			+2

ESLint disabled line counts

id	before	after	diff
`actions`	20	21	+1
`enterpriseSearch`	14	16	+2
`securitySolution`	410	414	+4
total			+7

Total ESLint disabled count

id	before	after	diff
`actions`	22	23	+1
`enterpriseSearch`	15	17	+2
`securitySolution`	489	493	+4
total			+7

History

💔 Build #141010 failed 018d83ac3d94eeb210548f4aaad3a332a88a876e
💔 Build #140995 failed a080d94
💛 Build #140525 was flaky 01f15e1
💛 Build #139759 was flaky a1b5d51
💔 Build #139720 failed cbaeb1f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @cnasikas

## Summary This PR adds the ability for system actions to be able to define their own Kibana privileges that need to be authorized before execution. Depends on: #160983 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

## Summary This PR: - Handles the references for system actions in the rule - Forbids the creation of system actions through the `kibana.yml` - Adds telemetry for system actions - Allow system action types to be disabled from the `kibana.yml` Depends on: #160983, #161341 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

## Summary This PR adds the ability for system actions to be able to define their own Kibana privileges that need to be authorized before execution. Depends on: elastic#160983 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

## Summary This PR: - Handles the references for system actions in the rule - Forbids the creation of system actions through the `kibana.yml` - Adds telemetry for system actions - Allow system action types to be disabled from the `kibana.yml` Depends on: elastic#160983, elastic#161341 ### Checklist Delete any items that are not applicable to this PR. - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

cnasikas and others added 18 commits June 28, 2023 10:51

Add isSystemAction to ActionResult type and default it to false

1352e52

Disallow registering system actions

09b82f6

Add test

dc1a2c8

Fix alerting types

bb7e9a5

Fix integration tests

774b389

Fix triggers_actions_ui types

83ee747

Fix cases types

d2b8e67

Fix cases tests

31f1f39

Fix integration tests

85ca6a4

Fix cases tests

b070bd9

Merge branch 'main' into system_actions_registration

a8e7143

Fix types from other plugins

b50a3e0

Merge branch 'system_actions_registration' of github.com:cnasikas/kib…

ee5df7b

…ana into system_actions_registration

Rename preconfiguredConnectors to inMemoryConnectors

1caf874

Create system actions

2aabeed

Prevent create/update/delete of system actions

3cf469a

Fix types

8c1246c

Merge branch 'main' into load_system_actions_in_memory

0d7aea1

cnasikas added release_note:skip Skip the PR/issue when compiling release notes Feature:Actions Feature:Actions/Framework Issues related to the Actions Framework v8.10.0 labels Jun 30, 2023

cnasikas commented Jun 30, 2023

View reviewed changes

x-pack/plugins/actions/server/actions_client.test.ts Show resolved Hide resolved

cnasikas added 7 commits June 30, 2023 21:13

Fix types

52ef0e5

Remove cases from basic

d763161

Convert preconfigured to in-memory

5c3245e

Merge branch 'main' into load_system_actions_in_memory

31bc750

Get in-memory connectors after they have been created in the route co…

d35a7f9

…ntext

Register test system action in integration tests

34ee2ab

Add integration tests

86b279c

cnasikas requested review from a team as code owners July 3, 2023 11:02

cnasikas requested a review from pmuellr July 3, 2023 11:03

cnasikas mentioned this pull request Jul 3, 2023

[Actions] System actions #160367

Closed

15 tasks

cnasikas commented Jul 3, 2023

View reviewed changes

botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jul 3, 2023

shahzad31 approved these changes Jul 3, 2023

View reviewed changes

stephmilovic approved these changes Jul 3, 2023

View reviewed changes

Merge branch 'main' into load_system_actions_in_memory

01f15e1

cnasikas added the Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// label Jul 6, 2023

This was referenced Jul 6, 2023

[Actions] System actions enhancements #161340

Merged

[Actions] System actions authorization #161341

Merged

pmuellr approved these changes Jul 7, 2023

View reviewed changes

PR feedback

a080d94

cnasikas enabled auto-merge (squash) July 7, 2023 15:01

cnasikas force-pushed the load_system_actions_in_memory branch from 018d83a to 03aab4a Compare July 7, 2023 16:24

Fix tests

abc6014

cnasikas force-pushed the load_system_actions_in_memory branch from 03aab4a to abc6014 Compare July 7, 2023 16:26

cnasikas merged commit 67fc833 into elastic:main Jul 7, 2023

cnasikas deleted the load_system_actions_in_memory branch July 7, 2023 17:39

kibanamachine added the backport:skip This PR does not require backporting label Jul 7, 2023

Conversation

cnasikas commented Jun 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

Uh oh!

cnasikas Jul 3, 2023

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 3, 2023

Uh oh!

stephmilovic left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 6, 2023

Uh oh!

pmuellr left a comment

Choose a reason for hiding this comment

Uh oh!

pmuellr Jul 7, 2023

Choose a reason for hiding this comment

Uh oh!

cnasikas Jul 7, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pmuellr Jul 7, 2023

Choose a reason for hiding this comment

Uh oh!

cnasikas Jul 7, 2023

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Jul 7, 2023

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Public APIs missing comments

Async chunks

Page load bundle

API count

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

cnasikas commented Jun 30, 2023 •

edited

Loading