Skip to content

[Discover] Show "Temporary" badge for ad-hoc data views in Alerts flyout#155717

Merged
jughosta merged 5 commits intoelastic:mainfrom
jughosta:fix-tmp-data-view-in-alerts
Apr 26, 2023
Merged

[Discover] Show "Temporary" badge for ad-hoc data views in Alerts flyout#155717
jughosta merged 5 commits intoelastic:mainfrom
jughosta:fix-tmp-data-view-in-alerts

Conversation

@jughosta
Copy link
Copy Markdown
Contributor

@jughosta jughosta commented Apr 25, 2023

Summary

This PR fixes data views list in Alerts flyout by showing "Temporary" badge for ad-hoc data views in it. It was missing before.

Screenshot 2023-04-25 at 16 04 25

@jughosta jughosta added release_note:fix backport:skip This PR does not require backporting Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// labels Apr 25, 2023
@jughosta jughosta self-assigned this Apr 25, 2023
@jughosta jughosta changed the title [Discover] Add "Temporary" badge to ad-hoc data views in Alerts flyout [Discover] Show "Temporary" badge for ad-hoc data views in Alerts flyout Apr 25, 2023
@jughosta jughosta marked this pull request as ready for review April 25, 2023 15:23
@jughosta jughosta requested a review from a team as a code owner April 25, 2023 15:23
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta jughosta requested a review from a team April 25, 2023 15:24
Copy link
Copy Markdown
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response ops changes lgtm

Copy link
Copy Markdown
Contributor

@davismcphee davismcphee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jughosta jughosta enabled auto-merge (squash) April 26, 2023 09:21
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
stackAlerts 80.1KB 80.1KB +25.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 17 19 +2
securitySolution 399 402 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 18 20 +2
securitySolution 479 482 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@jughosta jughosta merged commit 95d2604 into elastic:main Apr 26, 2023
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 26, 2023
* main: (1294 commits)
  [SecuritySolution] Refactor security packages (elastic#155365)
  [Discover] Show "Temporary" badge for ad-hoc data views in Alerts flyout (elastic#155717)
  [RAM] Conditional actions feedback on pr review (elastic#155804)
  [Files] Adds bulk delete method (elastic#155628)
  [Lens] Use proper way to generate absolute short URL (elastic#155512)
  [Guided onboarding] Use Kibana features to grant access (elastic#155065)
  [Index Management] Fix duped mock (elastic#155844)
  [Lens] Enhance visualization modifier popup with layer palette (elastic#155280)
  Fix flaky combobox tests on role management screen (elastic#155711)
  [Infrastructure UI] Create InventoryViewsService and InventoryViewsClient (elastic#155126)
  [Fleet] always create agent upload write indices (elastic#155729)
  [Fleet] [Cloud Security Posture] Add CloudFormation agent install method (elastic#155045)
  Add tech preview label for search applications (elastic#155649)
  [ML] AIOps: Stabilize flaky functional tests. (elastic#155710)
  [ES UI Shared] Migrate JsonEditor to monaco (elastic#155610)
  [Security Solution] Fixes security_solution storybooks always rendering in a flyout (elastic#155814)
  [Synthetics] Make error popover disappear `onMouseLeave` of metric item card (elastic#155800)
  Remove Exploratory View components from Observability (elastic#155629)
  [Discover] Remove redundant "Filter was added" toast (elastic#155645)
  [RAM][Security Solution][Alerts] Support the ability to trigger a rule action per alert generated (elastic#153611) (elastic#155384)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:fix Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants