Closed
Conversation
41d1110 to
d54538f
Compare
d54538f to
0d8cbb9
Compare
452a62d to
6210553
Compare
stacey-gammon
approved these changes
Dec 13, 2017
stacey-gammon
left a comment
There was a problem hiding this comment.
Dark theme looks good to me, except for modals, but I'm pretty sure that's an existing problem.
| @@ -329,11 +330,13 @@ app.directive('dashboardApp', function ($injector) { | |||
| function setDarkTheme() { | |||
| chrome.removeApplicationClass(['theme-light']); | |||
| chrome.addApplicationClass('theme-dark'); | |||
There was a problem hiding this comment.
I'm guessing this is still needed because dashboard is a combination of non-eui elements and eui elements, so for the time being we keep both dark theme applications around?
Contributor
Author
There was a problem hiding this comment.
Correct. KUI and EUI will live side-by-side as we gradually convert our UI to depend upon EUI.
Remove EUI dependency.
…e style node's CSS.
Small css fixes to adress reset changes with the introduction of EUI.
Small fix for checkbox spacing due to EUI reset.
6c7ca80 to
ecba3f8
Compare
02d4b46 to
f91b40e
Compare
988153c to
407fd24
Compare
Merged
Contributor
Author
|
Closing in favor of #15657 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #15134.
This PR:
innerHTMLTo-do:
innerHTML