Closed
Conversation
e477301 to
f2d598c
Compare
Remove EUI dependency.
f2d598c to
134ffac
Compare
Contributor
Author
|
Closing in favor of a branch on the original repo: https://github.com/elastic/kibana/tree/eui/reset-css And this issue: #15315 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've extracted the commits from #14948 which load the EUI CSS (thereby using its reset), and removing the Bootstrap, UI Framework, and custom reset CSS. Depends upon elastic/eui#153.
We'll need to complete the partial audit below and fix the regressions we find.
Partial audit
Here are a few of the visual regressions incurred by the CSS reset changes.
Notifications
Timepicker
aelements with nohrefattribute.Query bar
Discover
In "Single document" view, the tabs lack pointer cursors when hovered, possibly because they're
aelements withouthrefattributes.Note: this applies to the tabs in an expanded row of the doc table, too.
Visualize
sr-onlyaccessibility class has been deleted, which means all elements previously hidden by it are now visible. We can fix this by replacing this class witheuiScreenReaderOnlyinstead.aelements withouthrefattributes.