Switch to Yarn by spalger · Pull Request #15485 · elastic/kibana

spalger · 2017-12-07T23:33:05Z

Resubmission of #8621

This PR includes a vendored version of Yarn built from yarnpkg/yarn#5059.

spalger · 2017-12-08T01:23:41Z

package.json

By loosening our required versions (in package.json, yarn.lock makes them strict) we allow yarn to flatten our node_modules more. This is good for efficiency, but also necessary for some of our dependencies

With strict versions in Kibana yarn was installing 12 copies of moment.

# find node_modules -path '*node_modules/moment' node_modules/moment-timezone/node_modules/moment node_modules/statehood/node_modules/moment node_modules/moment node_modules/hapi/node_modules/moment node_modules/libesvm/node_modules/moment node_modules/grunt-esvm/node_modules/moment node_modules/inert/node_modules/moment node_modules/bunyan/node_modules/moment node_modules/vision/node_modules/moment node_modules/h2o2/node_modules/moment node_modules/even-better/node_modules/moment node_modules/makelogs/node_modules/moment

This caused bugs and test failures because we rely on moment having the same internal state everywhere, especially in moment-timezone, but moment-timezone depends on moment@^2.6.0. With npm this a satisfied by our dependency on moment@2.13.0, but yarn attempts to get the latest version of moment it can for moment-timezone, causing it to install moment@2.19.3 into moment-timezone/node_modules. When Kibana and moment-timezone depend on a ^ version of moment they both get the most recent version, installed once in the root node_modules directory.

With looser versions, yarn installs one version of moment

node_modules/moment

Overall, with strict versions kibana installs 2521 modules (88k files) and with looser versions kibana installs 2296 modules (82k files). A decent win.

kimjoar · 2017-12-09T00:55:41Z

I've got a PR in to fix the blocker: yarnpkg/yarn#5059. Let's see if it's accepted.

tylersmalley · 2017-12-26T17:29:09Z

@spalger, un-assigning myself until the yarn PR is merged.

spalger · 2018-01-08T22:38:38Z

NOTE: need to verify that grunt licenses:csv_report produces the same output with yarn and npm

kimjoar · 2018-01-09T22:05:23Z

I made some review fixes, plus I locked some versions specifically in the yarn.lock file so we don't have several versions of angular, moment, etc

This reverts commit 11ef811.

This reverts commit 3ade68c.

kimjoar · 2018-01-09T23:26:02Z

Discussed with @spalger, went with resolutions instead, to make sure we force one specific version of Angular, React, Moment.

e.g. because of the outdated React packages right now we get this warning because of forcing this:

warning Resolution field "react@16.0.0" is incompatible with requested version "react@^15.6.2"

kimjoar · 2018-01-10T00:38:43Z

jenkins, test this

tylersmalley · 2018-01-10T00:45:53Z

tasks/vendor/README.md

+The currently vendored version of Yarn contains the bugfix in
+https://github.com/yarnpkg/yarn/pull/5059, which handles optional dependencies.
+
+To build a new Yarn bundle, check out that pull requst and run:


tylersmalley · 2018-01-10T00:46:17Z

tasks/vendor/README.md

+To build a new Yarn bundle, check out that pull requst and run:
+
+```
+yarn run build-bundle


Can omit run

tylersmalley · 2018-01-10T00:47:34Z

src/dev/ci_setup/setup.sh

+###
+### downloading yarn
+###
+yarnVersion="$(node -e "console.log(String(require('./package.json').engines.yarn || '').replace(/^[^\d]+/,''))")"


Shouldn't we be using tasks/vendor/yarn-1.3.2-with-ignore-fix.js or am I missing something?

Yeah, we should probably do that. I'll fix.

We're going to need to put this back once yarnpkg/yarn#5059 is merged but 🤷‍♂️

tylersmalley · 2018-01-10T01:06:19Z

Some more pros, like we need more...

bundle size reduction of 6.8% (74913714 vs 69813592 bytes)
file count reduction of 7.47% (54408 vs 50344)

spalger

LGTM

* switch to yarn * cleanup misc references to npm * [yarn] loosen dependency ranges so yarn will merge more deps * fix linting error now that moment uses ESM * [licenses] font-awesome changed the format of its license id * Use local yarn * Misc fixes * eslintignore built yarn file * Remove mkdir which doesn't do what it should do * Check build without upgrading lots of versions * Fix license check * too many moments * Better description * Review fixes * Lock to angular@1.6.5 * More specific version locks * Revert "More specific version locks" This reverts commit 11ef811. * Revert "Lock to angular@1.6.5" This reverts commit 3ade68c. * rm yarn.lock; yarn * Forcing a specific version of React, Angular, Moment * Using vendored version of yarn in ci * Use --frozen-lockfile * fixes

* Switch to Yarn (#15485) * switch to yarn * cleanup misc references to npm * [yarn] loosen dependency ranges so yarn will merge more deps * fix linting error now that moment uses ESM * [licenses] font-awesome changed the format of its license id * Use local yarn * Misc fixes * eslintignore built yarn file * Remove mkdir which doesn't do what it should do * Check build without upgrading lots of versions * Fix license check * too many moments * Better description * Review fixes * Lock to angular@1.6.5 * More specific version locks * Revert "More specific version locks" This reverts commit 11ef811. * Revert "Lock to angular@1.6.5" This reverts commit 3ade68c. * rm yarn.lock; yarn * Forcing a specific version of React, Angular, Moment * Using vendored version of yarn in ci * Use --frozen-lockfile * fixes * Update lockfile

spalger · 2018-01-10T18:34:58Z

6.2/6.x: a817517

spalger added the WIP Work in progress label Dec 7, 2017

spalger force-pushed the implement/yarn branch 7 times, most recently from 99a870c to c7de861 Compare December 8, 2017 00:21

spalger added 2 commits December 7, 2017 17:44

switch to yarn

f69b9ac

cleanup misc references to npm

d50271b

spalger force-pushed the implement/yarn branch from c7de861 to d0eea10 Compare December 8, 2017 00:51

spalger commented Dec 8, 2017

View reviewed changes

spalger force-pushed the implement/yarn branch from d0eea10 to 55a0a79 Compare December 8, 2017 01:48

spalger added 3 commits December 7, 2017 19:31

[yarn] loosen dependency ranges so yarn will merge more deps

c73c34c

fix linting error now that moment uses ESM

e37bc17

[licenses] font-awesome changed the format of its license id

00aa707

spalger force-pushed the implement/yarn branch from 1a193d4 to 00aa707 Compare December 8, 2017 02:32

spalger added the blocked label Dec 8, 2017

Merge branch 'master' of github.com:elastic/kibana into implement/yarn

aa0d2b2

kimjoar changed the title ~~switch to yarn~~ Switch to yarn Dec 9, 2017

kimjoar changed the title ~~Switch to yarn~~ Switch to Yarn Dec 9, 2017

tylersmalley self-requested a review December 13, 2017 18:39

tylersmalley removed their request for review December 26, 2017 17:28

Merge branch 'master' of github.com:elastic/kibana into implement/yarn

2f0c85c

spalger force-pushed the implement/yarn branch from d6df8d9 to 2f0c85c Compare December 26, 2017 22:34

kimjoar added 2 commits January 9, 2018 00:00

Use local yarn

3614219

Merge branch 'master' into spalger-implement/yarn

a250507

kimjoar added 3 commits January 9, 2018 22:40

Review fixes

35573d1

Lock to angular@1.6.5

3ade68c

More specific version locks

11ef811

kimjoar added 4 commits January 10, 2018 00:08

Revert "More specific version locks"

ca1778b

This reverts commit 11ef811.

Revert "Lock to angular@1.6.5"

dfde46c

This reverts commit 3ade68c.

rm yarn.lock; yarn

1c91610

Forcing a specific version of React, Angular, Moment

d5f0497

tylersmalley reviewed Jan 10, 2018

View reviewed changes

kimjoar added 2 commits January 10, 2018 02:09

Using vendored version of yarn in ci

f08c194

Use --frozen-lockfile

c990e52

spalger commented Jan 10, 2018

View reviewed changes

fixes

309b462

kimjoar removed the v5.6.6 label Jan 10, 2018

kimjoar mentioned this pull request Jan 10, 2018

Switch to released version of Yarn #15952

Closed

kimjoar merged commit 0fde087 into elastic:master Jan 10, 2018

kimjoar mentioned this pull request Jan 10, 2018

[6.x] Switch to Yarn (#15485) #15955

Merged

spalger deleted the implement/yarn branch January 10, 2018 18:34

kimjoar mentioned this pull request Jan 22, 2018

Stop using resolutions in package.json #16190

Closed

spalger mentioned this pull request Jan 30, 2018

[yarn] remove locked moment resolution #16418

Merged

chandlerprall mentioned this pull request Nov 9, 2018

EUNSUPPORTEDPROTOCOL elastic/eui#1239

Closed

Conversation

spalger commented Dec 7, 2017 • edited by kimjoar Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spalger Dec 8, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kimjoar commented Dec 9, 2017

Uh oh!

tylersmalley commented Dec 26, 2017

Uh oh!

spalger commented Jan 8, 2018

Uh oh!

kimjoar commented Jan 9, 2018

Uh oh!

kimjoar commented Jan 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kimjoar commented Jan 10, 2018

Uh oh!

tylersmalley Jan 10, 2018

Choose a reason for hiding this comment

Uh oh!

tylersmalley Jan 10, 2018

Choose a reason for hiding this comment

Uh oh!

tylersmalley Jan 10, 2018

Choose a reason for hiding this comment

Uh oh!

kimjoar Jan 10, 2018

Choose a reason for hiding this comment

Uh oh!

spalger Jan 10, 2018

Choose a reason for hiding this comment

Uh oh!

tylersmalley commented Jan 10, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spalger left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spalger commented Jan 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

spalger commented Dec 7, 2017 •

edited by kimjoar

Loading

spalger Dec 8, 2017 •

edited

Loading

kimjoar commented Jan 9, 2018 •

edited

Loading

tylersmalley commented Jan 10, 2018 •

edited

Loading

spalger left a comment •

edited

Loading