[Fleet] Restrict output type for Fleet Server#149873
Merged
nchaulet merged 4 commits intoelastic:mainfrom Jan 30, 2023
Merged
Conversation
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
Member
Author
|
@elasticmachine merge upstream |
kpollich
approved these changes
Jan 30, 2023
Member
kpollich
left a comment
There was a problem hiding this comment.
Code LGTM 🚀 - Appreciate the separate module + tests
…m:nchaulet/kibana into feature-restrict-output-type-fleet-server
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @nchaulet |
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this pull request
Feb 6, 2023
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #148896
Logstash is not a valid output type for Fleet Server.
That PR fix that by disalowing settings logstash as an output type for Fleet Server (in addition of the existing restriction for APM)
UI Changes
How to test?