Fix issue where saved searches are not updated#14452
Merged
stacey-gammon merged 11 commits intoelastic:masterfrom Nov 2, 2017
Merged
Fix issue where saved searches are not updated#14452stacey-gammon merged 11 commits intoelastic:masterfrom
stacey-gammon merged 11 commits intoelastic:masterfrom
Conversation
added 3 commits
October 12, 2017 22:22
…overridden in a dashboard.
Author
|
I removed a retry that I thought should be irrelevant with the new more stabilized test code, but for some reason ran into the stale element reference. Adding debug messages to see if I can find out what is going on before putting the retry's back, as they shouldn't be needed... |
weltenwort
approved these changes
Oct 23, 2017
Member
weltenwort
left a comment
There was a problem hiding this comment.
This is a lot less confusing 👍
The problem that remains though is that there is no indication if the sorting or column set has been overridden. But that's a separate discussion.
added 4 commits
October 24, 2017 10:54
…pdate-untouched-saved-searches
…pdate-untouched-saved-searches
…pdate-untouched-saved-searches
Author
|
@Bargs, if you have time to give this a look over, just take note ofhttps://github.com//issues/14674. Tests pass here incidentally because the page is reloaded. That separate bug will require new tests to specifically catch. |
Bargs
approved these changes
Nov 2, 2017
Contributor
Bargs
left a comment
There was a problem hiding this comment.
LGTM! Feels much more intuitive. I agree with Felix that a dirty state indicator would be nice, along with some way to easily "reset" the panel back to the saved search state. But that can certainly wait for another PR.
…pdate-untouched-saved-searches
stacey-gammon
pushed a commit
to stacey-gammon/kibana
that referenced
this pull request
Nov 2, 2017
elastic#14452) * Add tests to catch error * Fix test * Don't store column and sort state in panel uiState unless explicitly overridden in a dashboard. * add debug messages * Elements can go stale between the find by and the click event so wrap in a retry * fix bad merge with master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note: There has been a long standing issue where if you add a saved search to a dashboard, then go edit and save that saved search, the updates are not propagated to the dashboard. The only way, previously, to get the new changes was to remove and re-add the search from your dashboard. With this fix, that is no longer necessary. However, there is one situation when your saved search will stop updating and that is when someone has made and saved local edits to the saved search on the dashboard. For example, if you remove a column from a saved search in a dashboard panel, then save the dashboard, that search will always show that column set, even if columns are added or removed to the underlying saved search. We did it this way to still allow users to override the configuration at the dashboard level.
Fixes #9523
The issue was that we were storing the column and sort information on the panel state all the time - not just when it was explicitly overridden in a dashboard. Now, you will only lose automatic updates if a dashboard is saved with an explicit modification of columns and sort. The columns and sort are also separate, so if you simply sort, you won't see sort updates from a saved search, but you will get column modifications.