Skip to content

[Lens] Revisit Random sampling UI#143929

Merged
dej611 merged 3 commits intoelastic:mainfrom
dej611:feature/143221-followup
Oct 27, 2022
Merged

[Lens] Revisit Random sampling UI#143929
dej611 merged 3 commits intoelastic:mainfrom
dej611:feature/143221-followup

Conversation

@dej611
Copy link
Copy Markdown
Contributor

@dej611 dej611 commented Oct 25, 2022 •
edited
Loading

Summary

Follow up from #143221

Updated with @MichaelMarcialis feedback PR.

Screenshot 2022-10-25 at 12 14 27

Changes summary:

  • Switch the slider's EuiFormRow from columnCompressed to rowCompressed to allow the slider to expand to the full available width of the flyout.
  • Show "Speed" and "Accuracy" labels at each of the slider's respective extremities to emphasize what is happening.
  • Change the slider's tick numbers to percentages for easier reading.
  • Update help text below the slider to briefly explaining what this feature does (supplied by @KOTungseth) and include a link to the full documentation.

Revisited UI design as discussed with @MichaelMarcialis .
Created a copy stub for the help text @KOTungseth

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@dej611 dej611 added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v8.6.0 labels Oct 25, 2022
@dej611 dej611 requested a review from a team as a code owner October 25, 2022 10:22
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 25, 2022

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@dej611 dej611 added the ui-copy Review of UI copy with docs team is recommended label Oct 25, 2022
MichaelMarcialis
MichaelMarcialis reviewed Oct 25, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @dej611! Thanks for making these changes. I've opened up a quick PR in your repo containing all of my design suggestions. Please give that a look when you get a moment. Once approved and merged, I can approve this PR.

@dej611
Copy link
Copy Markdown
Contributor Author

dej611 commented Oct 26, 2022

@MichaelMarcialis I wasn't sure of the EuiBetaBadge and whether it was universally recognized as Technical Preview , reverting to its long version of it. I saw you've used it, so I guess it's ok to use it to indicate also for the future.
Do you think it is worth to revisit the badge also in other contexts (like the chart switcher)?

@MichaelMarcialis
Copy link
Copy Markdown
Contributor

MichaelMarcialis commented Oct 26, 2022

@MichaelMarcialis I wasn't sure of the EuiBetaBadge and whether it was universally recognized as Technical Preview , reverting to its long version of it. I saw you've used it, so I guess it's ok to use it to indicate also for the future.
Do you think it is worth to revisit the badge also in other contexts (like the chart switcher)?

I think in most cases, we should use EuiBadge with the full Technical preview text. In certain circumstances (such as this) that require a smaller and less prominent badge, I think it's OK to switch to the EuiBetaBadge with icon. So I'd recommend we leave the chart switcher as is for now.

MichaelMarcialis
MichaelMarcialis approved these changes Oct 26, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for merging in those changes. Looks good to me!

drewdaemon
drewdaemon approved these changes Oct 26, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code review only

mbondyra
mbondyra approved these changes Oct 27, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice new feature (just reviewing this and the previous merged PR to notice the change) 👌🏼

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 27, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB +947.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dej611
Copy link
Copy Markdown
Contributor Author

dej611 commented Oct 27, 2022

Talked offline with @KOTungseth : will merge this now and a PR with docs changes will follow up if required

@dej611 dej611 merged commit 83e85bd into elastic:main Oct 27, 2022
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Oct 27, 2022
@KOTungseth KOTungseth mentioned this pull request Oct 31, 2022
Merged
KOTungseth added a commit that referenced this pull request Nov 9, 2022
@KOTungseth @kibanamachine
[Lens] Updates the UI copy for Random sampling (#144265)
64c3c63 
## Summary

Updates the Random sampling copy. 

Original PR: #143929

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drewdaemon drewdaemon drewdaemon approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

@mbondyra mbondyra mbondyra approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// ui-copy Review of UI copy with docs team is recommended v8.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dej611 @elasticmachine @MichaelMarcialis @kibana-ci @drewdaemon @mbondyra @kibanamachine