Skip to content

[Lens][Agg based XY] Navigate to lens functional tests.#143549

Merged
VladLasitsa merged 2 commits intoelastic:mainfrom
VladLasitsa:navigate-to-lens-agg-based-xy-functional-tests
Oct 19, 2022
Merged

[Lens][Agg based XY] Navigate to lens functional tests.#143549
VladLasitsa merged 2 commits intoelastic:mainfrom
VladLasitsa:navigate-to-lens-agg-based-xy-functional-tests

Conversation

@VladLasitsa
Copy link
Copy Markdown
Contributor

@VladLasitsa VladLasitsa commented Oct 18, 2022 •
edited
Loading

Summary

Completes part of #138236

  • Static value (reference lines/formula/static value column for different visualizations)
  • Count
  • Metric with source field
  • Sibling pipeline
  • Parent pipeline
  • Not supported aggregations
  • More than one axis left/right/top/bottom
  • Configured metric for dot size
  • Multiple split series
  • Sibling pipeline aggregation + split series
  • Different axis positions
  • metrics with differents chart types
  • metrics with the same chart type
  • line stacked chart
  • percentage chart
  • Defined x-axis
  • Defined one split series
  • horizontal bar

Flaky tests check: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1451

@VladLasitsa VladLasitsa self-assigned this Oct 18, 2022
@VladLasitsa VladLasitsa added Feature:XYAxis XY-Axis charts (bar, area, line) test_xpack_functional Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This PR does not require backporting v8.6.0 labels Oct 18, 2022
@VladLasitsa VladLasitsa mentioned this pull request Oct 18, 2022
Closed
28 tasks
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 19, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB -2.0B
visTypeXy 40.4KB 40.5KB +84.0B
total +82.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @VladLasitsa

@VladLasitsa VladLasitsa marked this pull request as ready for review October 19, 2022 08:44
@VladLasitsa VladLasitsa requested a review from a team as a code owner October 19, 2022 08:44
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 19, 2022

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@VladLasitsa VladLasitsa requested a review from flash1293 October 19, 2022 08:44
flash1293
flash1293 approved these changes Oct 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VladLasitsa VladLasitsa merged commit 0994b92 into elastic:main Oct 19, 2022
kc13greiner pushed a commit to kc13greiner/kibana that referenced this pull request Oct 19, 2022
@VladLasitsa @kc13greiner
[Lens][Agg based XY] Navigate to lens functional tests. (elastic#143549)
ae5d1af 
* Add functional tests for agg based XY

* Updated snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flash1293 flash1293 flash1293 approved these changes

Assignees

@VladLasitsa VladLasitsa

Labels

backport:skip This PR does not require backporting Feature:Lens Feature:XYAxis XY-Axis charts (bar, area, line) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// test_xpack_functional v8.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@VladLasitsa @kibana-ci @elasticmachine @flash1293