Skip to content

Fix typo in API preview UI#143245

Merged
hop-dev merged 1 commit intoelastic:mainfrom
dedemorton:fix_typo
Oct 13, 2022
Merged

Fix typo in API preview UI#143245
hop-dev merged 1 commit intoelastic:mainfrom
dedemorton:fix_typo

Conversation

@dedemorton
Copy link
Copy Markdown
Contributor

@dedemorton dedemorton commented Oct 12, 2022 •
edited by kibanamachine
Loading

Summary

Fixes a typo in the API preview page (beta) in Kibana.

Checklist

Delete any items that are not applicable to this PR.

@dedemorton dedemorton added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Oct 12, 2022
@dedemorton dedemorton requested a review from nchaulet October 12, 2022 22:25
@dedemorton dedemorton self-assigned this Oct 12, 2022
@dedemorton dedemorton requested a review from a team as a code owner October 12, 2022 22:25
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 12, 2022

Pinging @elastic/fleet (Team:Fleet)

@dedemorton
Copy link
Copy Markdown
Contributor Author

dedemorton commented Oct 12, 2022 •
edited
Loading

@nchaulet Which backport labels do I need to use here? I'm assuming it's too late to get this in for 8.5, but let me know.

@dedemorton dedemorton marked this pull request as draft October 12, 2022 22:32
@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 12, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 916.5KB 916.5KB -1.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dedemorton

@dedemorton dedemorton marked this pull request as ready for review October 12, 2022 23:29
hop-dev
hop-dev approved these changes Oct 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@hop-dev hop-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dedemorton , Nicolas is on leave at the min, I have added backport:prev-minor which should add this to 8.5. I am not sure when the cutoff is but this is low risk

@hop-dev hop-dev merged commit d21c5a7 into elastic:main Oct 13, 2022
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 13, 2022

💔 All backports failed

Status Branch Result
❌ 8.5 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 143245

Questions ?

Please refer to the Backport tool documentation

@hop-dev hop-dev mentioned this pull request Oct 13, 2022
Merged
@hop-dev
Copy link
Copy Markdown
Contributor

hop-dev commented Oct 13, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Oct 13, 2022
@dedemorton @hop-dev
Fix typo in API preview (elastic#143245)
d91abed 
(cherry picked from commit d21c5a7)
hop-dev added a commit that referenced this pull request Oct 13, 2022
@hop-dev @dedemorton
Fix typo in API preview (#143245) (#143289)
61abb30 
(cherry picked from commit d21c5a7)

Co-authored-by: DeDe Morton <dede.morton@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hop-dev hop-dev hop-dev approved these changes

@nchaulet nchaulet Awaiting requested review from nchaulet

Assignees

@dedemorton dedemorton

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.5.0 v8.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dedemorton @elasticmachine @kibana-ci @kibanamachine @hop-dev